Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/18
LGTM, please squash your three commits into one, and don't forget to
mention SYNCOPE-866 in the final commit log (the very first used here will
work, anyway).
I will merge this PR at
Github user tmess567 commented on the issue:
https://github.com/apache/syncope/pull/18
Done. Please check.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/18
Ok, the changes are just fine.
Now, you need to add a couple of methods like as follows
```java
@Test
public void issueSYNCOPE866() {
}
```
to the two
Github user tmess567 commented on the issue:
https://github.com/apache/syncope/pull/18
That's done. I'll commit right away.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/18
Ok, let's do things one step at a time.
Please first address my comments in code, we will come up with testing
later on, ok?
---
If your project is set up for it, you can reply to this email
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/18
Please also add a test case on
[ReportTemplateITCase](https://github.com/apache/syncope/blob/master/fit/core-reference/src/test/java/org/apache/syncope/fit/core/ReportTemplateITCase.java)
and on
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/18
Thanks for this PR @tmess567, I appreciate it very much.
I have added some comments to avoid duplicate classes and stay close to
what other Logic classes do.
Please fix with an
