[PR] [MINOR] update contributors (#143) [systemds-website]

2024-06-08 Thread via GitHub
Baunsgaard opened a new pull request, #144: URL: https://github.com/apache/systemds-website/pull/144 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [MINOR] update contributors (#143) [systemds-website]

2024-06-08 Thread via GitHub
Baunsgaard merged PR #144: URL: https://github.com/apache/systemds-website/pull/144 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [MINOR] Update contributors [systemds-website]

2024-06-08 Thread via GitHub
Baunsgaard merged PR #142: URL: https://github.com/apache/systemds-website/pull/142 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [MINOR] update contributors [systemds-website]

2024-06-08 Thread via GitHub
Baunsgaard merged PR #143: URL: https://github.com/apache/systemds-website/pull/143 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] [MINOR] update contributors [systemds-website]

2024-06-08 Thread via GitHub
Baunsgaard opened a new pull request, #143: URL: https://github.com/apache/systemds-website/pull/143 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] [MINOR] Update contributors [systemds-website]

2024-06-08 Thread via GitHub
Baunsgaard opened a new pull request, #142: URL: https://github.com/apache/systemds-website/pull/142 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [SYSTEMDS-3695] Fix frame binary append for Spark for misaligned inputs (FrameAppendRSPInstruction) [systemds]

2024-06-05 Thread via GitHub
e-strauss commented on PR #2031: URL: https://github.com/apache/systemds/pull/2031#issuecomment-2149770886 Thanks - I guessed I will be simple way to understand the test case. When you say keep the information do mean store this information in the meta data field for each RDD or a function

Re: [PR] [SYSTEMDS-3695] Fix frame binary append for Spark for misaligned inputs (FrameAppendRSPInstruction) [systemds]

2024-06-05 Thread via GitHub
mboehm7 closed pull request #2031: [SYSTEMDS-3695] Fix frame binary append for Spark for misaligned inputs (FrameAppendRSPInstruction) URL: https://github.com/apache/systemds/pull/2031 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [SYSTEMDS-3695] Fix frame binary append for Spark for misaligned inputs (FrameAppendRSPInstruction) [systemds]

2024-06-05 Thread via GitHub
mboehm7 commented on PR #2031: URL: https://github.com/apache/systemds/pull/2031#issuecomment-2149101123 LGTM - thanks for the additional improvement @e-strauss. I liked the ASCII art in the tests. During the merge I left a TODO comment to keep the information if a frame RDD is already

Re: [PR] [SYSTEMDS-3529] codecov badge + PyPI downloads badge [systemds]

2024-06-04 Thread via GitHub
mboehm7 closed pull request #2029: [SYSTEMDS-3529] codecov badge + PyPI downloads badge URL: https://github.com/apache/systemds/pull/2029 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [SYSTEMDS-3529] codecov badge + PyPI downloads badge [systemds]

2024-06-04 Thread via GitHub
mboehm7 commented on PR #2029: URL: https://github.com/apache/systemds/pull/2029#issuecomment-2147225653 Since we don't have access to the settings of the github repository, I looked around and found recent examples of Apache projects [1] using the same upload action v4. Apparently INFRA

Re: [PR] [SYSTEMDS-3213] Builtin for cluster-based quantization [systemds]

2024-06-04 Thread via GitHub
mboehm7 closed pull request #2030: [SYSTEMDS-3213] Builtin for cluster-based quantization URL: https://github.com/apache/systemds/pull/2030 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [SYSTEMDS-3213] Builtin for cluster-based quantization [systemds]

2024-06-04 Thread via GitHub
mboehm7 commented on PR #2030: URL: https://github.com/apache/systemds/pull/2030#issuecomment-2146899087 LGTM - thanks for the patch @canabdulla. The new builtin and tests very already pretty good, during the merge I just fixed some syntactic issues (tab indentation in Java code, and

[PR] [SYSTEMDS-3695] Fix frame binary append for Spark for misaligned inputs (FrameAppendRSPInstruction) [systemds]

2024-06-03 Thread via GitHub
e-strauss opened a new pull request, #2031: URL: https://github.com/apache/systemds/pull/2031 This patch fixes the binary cbind operation for the spark backend (FrameAppendRSPInstruction) for the edge case when the inputs have different block alignments. The RHS input is aligned to the

[PR] [SYSTEMDS-3213] Builtin for cluster-based quantization [systemds]

2024-06-03 Thread via GitHub
canabdulla opened a new pull request, #2030: URL: https://github.com/apache/systemds/pull/2030 The quantizeByCluster function quantizes numerical vectors via product quantization. Vectors are split into sub-vectors and ran through K-Means clustering. -- This is an automated message from

Re: [PR] [SYSTEMDS-3701] Create API for multi-modal alignment library [systemds]

2024-06-03 Thread via GitHub
mboehm7 closed pull request #2023: [SYSTEMDS-3701] Create API for multi-modal alignment library URL: https://github.com/apache/systemds/pull/2023 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [SYSTEMDS-3701] Create API for multi-modal alignment library [systemds]

2024-06-03 Thread via GitHub
mboehm7 commented on PR #2023: URL: https://github.com/apache/systemds/pull/2023#issuecomment-2144497689 LGTM - thanks @christinadionysio for getting started on this new component. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [SYSTEMDS-3695] Fix frame builtin nary append for Spark backend [systemds]

2024-06-03 Thread via GitHub
mboehm7 closed pull request #2026: [SYSTEMDS-3695] Fix frame builtin nary append for Spark backend URL: https://github.com/apache/systemds/pull/2026 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [SYSTEMDS-3695] Fix frame builtin nary append for Spark backend [systemds]

2024-06-03 Thread via GitHub
mboehm7 commented on PR #2026: URL: https://github.com/apache/systemds/pull/2026#issuecomment-2144489864 LGTM - thanks for the patch @e-strauss. During the merge I only fixes minor warnings and formatting issues. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] raSelection function implementation [systemds]

2024-06-02 Thread via GitHub
mboehm7 commented on PR #2027: URL: https://github.com/apache/systemds/pull/2027#issuecomment-2143795386 LGTM - thanks for the patch @gghsu. This contribution already looked pretty good, I just made minor changes during the merge (formatting, unnecessary imports, and additional assertions

Re: [PR] raSelection function implementation [systemds]

2024-06-02 Thread via GitHub
mboehm7 closed pull request #2027: raSelection function implementation URL: https://github.com/apache/systemds/pull/2027 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [SYSTEMDS-3529] codecov badge + PyPI downloads badge [systemds]

2024-06-02 Thread via GitHub
mboehm7 commented on PR #2029: URL: https://github.com/apache/systemds/pull/2029#issuecomment-2143787045 LGTM - thanks @evelina-gudauskayte for the patch and very detailed instructions. I'll try to setup my account and reconfigure the code next week (before merging it in). -- This is

Re: [PR] [SYSTEMDS-3529] codecov badge + PyPI downloads badge [systemds]

2024-06-01 Thread via GitHub
evelina-gudauskayte commented on PR #2029: URL: https://github.com/apache/systemds/pull/2029#issuecomment-2143643488 @mboehm7 hello! I believe you are my mentor for this task, so I'd greatly appreciate it if you could take a look and provide your feedback when you have a chance.

[PR] [SYSTEMDS-3529] codecov badge + PyPI downloads badge [systemds]

2024-06-01 Thread via GitHub
evelina-gudauskayte opened a new pull request, #2029: URL: https://github.com/apache/systemds/pull/2029 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Systemds 3529 code coverage py pi downloads [systemds]

2024-06-01 Thread via GitHub
evelina-gudauskayte closed pull request #2028: Systemds 3529 code coverage py pi downloads URL: https://github.com/apache/systemds/pull/2028 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] raSelection function implementation [systemds]

2024-05-31 Thread via GitHub
gghsu opened a new pull request, #2027: URL: https://github.com/apache/systemds/pull/2027 This raSelection-function takes a matrix data set as input from where it performs relational operations: selection -- This is an automated message from the Apache Git Service. To respond to the

[PR] [SYSTEMDS-3695] Fix frame builtin nary append for Spark backend [systemds]

2024-05-30 Thread via GitHub
e-strauss opened a new pull request, #2026: URL: https://github.com/apache/systemds/pull/2026 This patch implements the nary append operation for frames (cbind and rbind). For the cbind, there are two physical implementation: - map-size cbind (w/ broadcast) - reduce-size cbind I

[PR] [SYSTEMDS-3694] Sequence primitive for neural network layers [systemds]

2024-05-28 Thread via GitHub
Nakroma opened a new pull request, #2025: URL: https://github.com/apache/systemds/pull/2025 Draft for the student project `SYSTEMDS-3694`. - [x] Adds a Layer interface to the Python API which can be extended by nn layers - [ ] Adds the sequence primitive that is able to combine

Re: [PR] Systemds 3696/add incsliceline builtin [systemds]

2024-05-20 Thread via GitHub
mboehm7 commented on PR #2024: URL: https://github.com/apache/systemds/pull/2024#issuecomment-2120598783 In future, please also use tabs over spaces in Java tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Systemds 3696/add incsliceline builtin [systemds]

2024-05-20 Thread via GitHub
mboehm7 closed pull request #2024: Systemds 3696/add incsliceline builtin URL: https://github.com/apache/systemds/pull/2024 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Systemds 3696/add incsliceline builtin [systemds]

2024-05-20 Thread via GitHub
mboehm7 commented on PR #2024: URL: https://github.com/apache/systemds/pull/2024#issuecomment-2120594529 LGTM - thanks @fzoepffel for getting started on incremental slice line. During the merge, I left a TODO in the builtin to convert the new inputs and outputs to lists for easier

[PR] [SYSTEMDS-3701] Create API for multi-modal alignment library [systemds]

2024-05-06 Thread via GitHub
christinadionysio opened a new pull request, #2023: URL: https://github.com/apache/systemds/pull/2023 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [MINOR] Fix logic for sprase-dense matrix multiply [systemds]

2024-05-03 Thread via GitHub
mboehm7 commented on PR #2022: URL: https://github.com/apache/systemds/pull/2022#issuecomment-2093484240 LGTM - thanks for catching this issues @ReneEnjilian. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [MINOR] Fix logic for sprase-dense matrix multiply [systemds]

2024-05-03 Thread via GitHub
mboehm7 closed pull request #2022: [MINOR] Fix logic for sprase-dense matrix multiply URL: https://github.com/apache/systemds/pull/2022 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] [MINOR] Fix logic for sprase-dense matrix multiply [systemds]

2024-04-30 Thread via GitHub
ReneEnjilian opened a new pull request, #2022: URL: https://github.com/apache/systemds/pull/2022 I noticed that the fallback implementation for sparse-dense matrix multiply produces wrong results or sometimes throws an index out of bounds exception. This patch fixes this issue. Further,

Re: [PR] SYSTEMDS-3696/add-custom-JUNIT-tests-for-slicefinder [systemds]

2024-04-22 Thread via GitHub
mboehm7 closed pull request #2021: SYSTEMDS-3696/add-custom-JUNIT-tests-for-slicefinder URL: https://github.com/apache/systemds/pull/2021 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] SYSTEMDS-3696/add-custom-JUNIT-tests-for-slicefinder [systemds]

2024-04-22 Thread via GitHub
mboehm7 commented on PR #2021: URL: https://github.com/apache/systemds/pull/2021#issuecomment-2070621662 LGTM - thanks for the patch @fzoepffel. During the merge, I just made minor adjustments (deleting the slicefinder.txt output file, simplifying the matrix comparison to a single call,

Re: [PR] [MINOR] Double Buffering longer than buffer arrays [systemds]

2024-04-16 Thread via GitHub
Baunsgaard closed pull request #2019: [MINOR] Double Buffering longer than buffer arrays URL: https://github.com/apache/systemds/pull/2019 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [MINOR] Double Buffering longer than buffer arrays [systemds]

2024-04-16 Thread via GitHub
Baunsgaard commented on code in PR #2019: URL: https://github.com/apache/systemds/pull/2019#discussion_r1567400551 ## src/main/java/org/apache/sysds/runtime/util/DoubleBufferingOutputStream.java: ## @@ -75,6 +75,9 @@ public void write(byte[] b, int off, int len) throws

Re: [PR] [MINOR] Double Buffering longer than buffer arrays [systemds]

2024-04-16 Thread via GitHub
Baunsgaard commented on code in PR #2019: URL: https://github.com/apache/systemds/pull/2019#discussion_r1567401878 ## src/main/java/org/apache/sysds/runtime/util/DoubleBufferingOutputStream.java: ## @@ -75,6 +75,9 @@ public void write(byte[] b, int off, int len) throws

Re: [PR] [MINOR] Double Buffering longer than buffer arrays [systemds]

2024-04-16 Thread via GitHub
Baunsgaard commented on code in PR #2019: URL: https://github.com/apache/systemds/pull/2019#discussion_r1567400551 ## src/main/java/org/apache/sysds/runtime/util/DoubleBufferingOutputStream.java: ## @@ -75,6 +75,9 @@ public void write(byte[] b, int off, int len) throws

Re: [PR] [MINOR] Double Buffering longer than buffer arrays [systemds]

2024-04-16 Thread via GitHub
Baunsgaard commented on PR #2019: URL: https://github.com/apache/systemds/pull/2019#issuecomment-2059132375 > no, what I mean is that this code is incorrect - if somebody would allocate a large byte buffer, and repeatedly write this to the fastoutputstream, you get a race condition

Re: [PR] [MINOR] Double Buffering longer than buffer arrays [systemds]

2024-04-16 Thread via GitHub
mboehm7 commented on PR #2019: URL: https://github.com/apache/systemds/pull/2019#issuecomment-2059130469 no, what I mean is that this code is incorrect - if somebody would allocate a large byte buffer, and repeatedly write this to the fastoutputstream, you get a race condition overwrite.

Re: [PR] [MINOR] Double Buffering longer than buffer arrays [systemds]

2024-04-16 Thread via GitHub
Baunsgaard commented on PR #2019: URL: https://github.com/apache/systemds/pull/2019#issuecomment-2059118463 > OK thanks for the clarification but for a general-purpose implementation, we should write it sequentially (no pool submit) because somebody might write the same

Re: [PR] [MINOR] Add a custom LongInt hashmap [systemds]

2024-04-16 Thread via GitHub
Baunsgaard closed pull request #2020: [MINOR] Add a custom LongInt hashmap URL: https://github.com/apache/systemds/pull/2020 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [MINOR] Double Buffering longer than buffer arrays [systemds]

2024-04-16 Thread via GitHub
mboehm7 commented on PR #2019: URL: https://github.com/apache/systemds/pull/2019#issuecomment-2059109014 OK thanks for the clarification but for a general-purpose implementation, we should write it sequentially (no pool submit) because somebody might write the same byte array to the stream

Re: [PR] [MINOR] Double Buffering longer than buffer arrays [systemds]

2024-04-16 Thread via GitHub
Baunsgaard commented on code in PR #2019: URL: https://github.com/apache/systemds/pull/2019#discussion_r1567371448 ## src/main/java/org/apache/sysds/runtime/util/DoubleBufferingOutputStream.java: ## @@ -43,42 +42,49 @@ public DoubleBufferingOutputStream(OutputStream out, int

Re: [PR] [MINOR] Double Buffering longer than buffer arrays [systemds]

2024-04-16 Thread via GitHub
mboehm7 commented on code in PR #2019: URL: https://github.com/apache/systemds/pull/2019#discussion_r1567359431 ## src/main/java/org/apache/sysds/runtime/util/DoubleBufferingOutputStream.java: ## @@ -43,42 +42,49 @@ public DoubleBufferingOutputStream(OutputStream out, int num,

Re: [PR] [MINOR] Double Buffering longer than buffer arrays [systemds]

2024-04-16 Thread via GitHub
Baunsgaard commented on PR #2019: URL: https://github.com/apache/systemds/pull/2019#issuecomment-2059085091 In more detail: ```java public static void writeWritableToLocal(String fname, Writable mb, boolean doubleBuffering) throws IOException {

Re: [PR] [MINOR] Double Buffering longer than buffer arrays [systemds]

2024-04-16 Thread via GitHub
Baunsgaard commented on code in PR #2019: URL: https://github.com/apache/systemds/pull/2019#discussion_r1567338942 ## src/main/java/org/apache/sysds/runtime/util/DoubleBufferingOutputStream.java: ## @@ -43,42 +42,49 @@ public DoubleBufferingOutputStream(OutputStream out, int

Re: [PR] [MINOR] Double Buffering longer than buffer arrays [systemds]

2024-04-16 Thread via GitHub
mboehm7 commented on PR #2019: URL: https://github.com/apache/systemds/pull/2019#issuecomment-2058948951 I'm not yet getting the problem here - the double buffering is used for all evictions and works for arbitrarily large arrays. Please make sure when changing it that the pipeline

[PR] [MINOR] Add a custom LongInt hashmap [systemds]

2024-04-16 Thread via GitHub
Baunsgaard opened a new pull request, #2020: URL: https://github.com/apache/systemds/pull/2020 This commit adds a new longint hash map for efficient combining of column groups. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[PR] [MINOR] Double Buffering longer than buffer arrays [systemds]

2024-04-16 Thread via GitHub
Baunsgaard opened a new pull request, #2019: URL: https://github.com/apache/systemds/pull/2019 This PR fixes a bug in the double buffering in cases of writing longer than buffer size buffers. Also contained is minor cleanups, and clarifications through docs. -- This is an automated

Re: [PR] [SYSTEMDS-3426] Python NN Builtin (Affine,Relu) [systemds]

2024-04-15 Thread via GitHub
Baunsgaard closed pull request #1929: [SYSTEMDS-3426] Python NN Builtin (Affine,Relu) URL: https://github.com/apache/systemds/pull/1929 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [Not for merge] python logging issue [systemds]

2024-04-12 Thread via GitHub
j143 commented on PR #2017: URL: https://github.com/apache/systemds/pull/2017#issuecomment-2051368883 already published at https://pypi.org/project/systemds/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Not for merge] python logging issue [systemds]

2024-04-12 Thread via GitHub
j143 closed pull request #2017: [Not for merge] python logging issue URL: https://github.com/apache/systemds/pull/2017 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Column Co-code Updates [systemds]

2024-04-09 Thread via GitHub
Baunsgaard closed pull request #2018: Column Co-code Updates URL: https://github.com/apache/systemds/pull/2018 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Column Co-code Updates [systemds]

2024-04-09 Thread via GitHub
Baunsgaard commented on PR #2018: URL: https://github.com/apache/systemds/pull/2018#issuecomment-2045942432 This PR is merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] Column Co-code Updates [systemds]

2024-04-09 Thread via GitHub
Baunsgaard opened a new pull request, #2018: URL: https://github.com/apache/systemds/pull/2018 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] [SYSTEMDS-3572] Threadpool ParFor name threads [systemds]

2024-04-08 Thread via GitHub
Baunsgaard merged PR #2015: URL: https://github.com/apache/systemds/pull/2015 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [Not for merge] python logging issue [systemds]

2024-04-08 Thread via GitHub
Baunsgaard commented on PR #2017: URL: https://github.com/apache/systemds/pull/2017#issuecomment-2042621927 you should be able to make it if you set the logging level. ![image](https://github.com/apache/systemds/assets/9947148/e0926389-99cc-43cf-b21f-f86def00c712) As you can

Re: [PR] [Not for merge] python logging issue [systemds]

2024-04-08 Thread via GitHub
j143 commented on PR #2017: URL: https://github.com/apache/systemds/pull/2017#issuecomment-2042593509 It is supposed to print the script output, isn't it? > model = l2svm(features, labels, verbose=False).compute() > logging.info(model) it providing no output! --

Re: [PR] [Not for merge] python logging issue [systemds]

2024-04-08 Thread via GitHub
Baunsgaard commented on PR #2017: URL: https://github.com/apache/systemds/pull/2017#issuecomment-2042534666 what do you mean with not working as intended? if it is the nativeCodeLoader warning that you see then it is correct. -- This is an automated message from the Apache Git

Re: [PR] python logging issue - Not for merge [systemds]

2024-04-07 Thread via GitHub
j143 commented on PR #2017: URL: https://github.com/apache/systemds/pull/2017#issuecomment-2041797059 Hi @Baunsgaard -- I built the whl artifact and installed. And checked the logging doesn't seem to work as expected. -- This is an automated message from the Apache Git Service. To

[PR] python logging issue [systemds]

2024-04-07 Thread via GitHub
j143 opened a new pull request, #2017: URL: https://github.com/apache/systemds/pull/2017 This is not fixing the log4j issue -- https://github.com/apache/systemds/commit/387b6c1c8e472dde65a36e8f3fd22091054ed347 ```py import logging from systemds.context import

Re: [PR] [MINOR] CLA update Map To indexes [systemds]

2024-04-06 Thread via GitHub
Baunsgaard merged PR #2016: URL: https://github.com/apache/systemds/pull/2016 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] [MINOR] CLA update Map To indexes [systemds]

2024-04-06 Thread via GitHub
Baunsgaard opened a new pull request, #2016: URL: https://github.com/apache/systemds/pull/2016 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] [SYSTEMDS-3676] Relative path remove in bin (MacOS fix) [systemds]

2024-04-05 Thread via GitHub
Baunsgaard closed pull request #2012: [SYSTEMDS-3676] Relative path remove in bin (MacOS fix) URL: https://github.com/apache/systemds/pull/2012 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [MINOR] Frame Shallow Update [systemds]

2024-04-05 Thread via GitHub
Baunsgaard closed pull request #2013: [MINOR] Frame Shallow Update URL: https://github.com/apache/systemds/pull/2013 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [SYSTEMDS-???] Thread pool ParFor threads Naming and fix [systemds]

2024-04-05 Thread via GitHub
Baunsgaard commented on PR #2015: URL: https://github.com/apache/systemds/pull/2015#issuecomment-2040138224 ``` X = rand(rows = 100, cols = 100, min = 0, max = 100) Z = rand(rows = 1000, cols = 100, min = 0, max = 100) parfor( i in 1: 4){ for( i in 1 : 1000){ Y

[PR] [SYSTEMDS-???] Thread pool ParFor threads Naming and fix [systemds]

2024-04-05 Thread via GitHub
Baunsgaard opened a new pull request, #2015: URL: https://github.com/apache/systemds/pull/2015 This PR contains code to improve an recent update in the common thread pool to properly use the threads pool cached allocations for PARFOR threads. -- This is an automated message from the

[PR] [???] Frame Finegrained Compression Parallelization [systemds]

2024-04-05 Thread via GitHub
Baunsgaard opened a new pull request, #2014: URL: https://github.com/apache/systemds/pull/2014 This PR contains code for finegrained Frame Parallelization. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] [MINOR] Frame Shallow Update [systemds]

2024-04-05 Thread via GitHub
Baunsgaard opened a new pull request, #2013: URL: https://github.com/apache/systemds/pull/2013 This commit make minor modifications to the shallow handling of Frames. One instance is fast abort of isShallowSerialize. -- This is an automated message from the Apache Git Service. To

Re: [PR] [SYSTEMDS-3687] Python API startup fixes [systemds]

2024-04-04 Thread via GitHub
Baunsgaard commented on PR #2008: URL: https://github.com/apache/systemds/pull/2008#issuecomment-2037752989 @j143 I decided to merge it, because i have other things that depends on it, Feel free to comment on the Commit directly 387b6c1c8e472dde65a36e8f3fd22091054ed347 -- This is

Re: [PR] [SYSTEMDS-3687] Python API startup fixes [systemds]

2024-04-04 Thread via GitHub
Baunsgaard merged PR #2008: URL: https://github.com/apache/systemds/pull/2008 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Keyword Spotting Application [systemds]

2024-04-04 Thread via GitHub
Baunsgaard commented on PR #2001: URL: https://github.com/apache/systemds/pull/2001#issuecomment-2037699355 I have decided against merging this PR at the moment, since it is adding files some places not ideal. If you want to clean it up @mufwan then i will happily merge it.

Re: [PR] [SYSTEMDS-3685] DML Integration of FFT and IFFT [systemds]

2024-04-04 Thread via GitHub
Baunsgaard commented on PR #1983: URL: https://github.com/apache/systemds/pull/1983#issuecomment-2037691429 Thank you for the PR, While merging I have fixed the parallelization threads propagation through the compiler. Future work is to fix the STFT, to integrate with the DML

Re: [PR] [SYSTEMDS-3685] Merge FFT [systemds]

2024-04-04 Thread via GitHub
Baunsgaard closed pull request #2009: [SYSTEMDS-3685] Merge FFT URL: https://github.com/apache/systemds/pull/2009 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [SYSTEMDS-3685] Merge FFT [systemds]

2024-04-04 Thread via GitHub
Baunsgaard commented on PR #2009: URL: https://github.com/apache/systemds/pull/2009#issuecomment-2037683634 Merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [SYSTEMDS-3686] Stft [systemds]

2024-04-04 Thread via GitHub
Baunsgaard closed pull request #2000: [SYSTEMDS-3686] Stft URL: https://github.com/apache/systemds/pull/2000 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] [SYSTEMDS-3685] DML Integration of FFT and IFFT [systemds]

2024-04-04 Thread via GitHub
Baunsgaard closed pull request #1983: [SYSTEMDS-3685] DML Integration of FFT and IFFT URL: https://github.com/apache/systemds/pull/1983 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [SYSTEMDS-3685] Python FFT [systemds]

2024-04-04 Thread via GitHub
Baunsgaard closed pull request #1995: [SYSTEMDS-3685] Python FFT URL: https://github.com/apache/systemds/pull/1995 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [MINOR] Append perf [systemds]

2024-04-04 Thread via GitHub
Baunsgaard closed pull request #2011: [MINOR] Append perf URL: https://github.com/apache/systemds/pull/2011 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Complete ResNet integration [systemds]

2024-03-30 Thread via GitHub
phaniarnab commented on PR #1992: URL: https://github.com/apache/systemds/pull/1992#issuecomment-2028448424 Thanks for completing ResNet implementation @MaximilianSchreff. Good work . In the future please avoid merging with the main branch, use rebase instead. -- This is an

Re: [PR] [SYSTEMDS-3689] Complete ResNet Integration [systemds]

2024-03-30 Thread via GitHub
phaniarnab closed pull request #2010: [SYSTEMDS-3689] Complete ResNet Integration URL: https://github.com/apache/systemds/pull/2010 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Complete ResNet integration [systemds]

2024-03-30 Thread via GitHub
phaniarnab closed pull request #1992: Complete ResNet integration URL: https://github.com/apache/systemds/pull/1992 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [SYSTEMDS-3689] Complete ResNet Integration [systemds]

2024-03-30 Thread via GitHub
phaniarnab commented on PR #2010: URL: https://github.com/apache/systemds/pull/2010#issuecomment-2028438104 Cleaned up PR #1992 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] [SYSTEMDS-3689] Complete ResNet Integration [systemds]

2024-03-30 Thread via GitHub
phaniarnab opened a new pull request, #2010: URL: https://github.com/apache/systemds/pull/2010 These commits add the full integration of ResNets. The forward passes for the basic residual block architecture (ResNet18 & 34) have been previously added. These commits add the forward passes

Re: [PR] [SYSTEMDS-3685] Python FFT [systemds]

2024-03-27 Thread via GitHub
Baunsgaard commented on PR #1995: URL: https://github.com/apache/systemds/pull/1995#issuecomment-2023088593 This PR is currently being merged in #2009 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [SYSTEMDS-3685] DML Integration of FFT and IFFT [systemds]

2024-03-27 Thread via GitHub
Baunsgaard commented on PR #1983: URL: https://github.com/apache/systemds/pull/1983#issuecomment-2023066179 Taking over the merge of this PR in #2009 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [SYSTEMDS-???] Python API startup fixes [systemds]

2024-03-27 Thread via GitHub
Baunsgaard commented on PR #2008: URL: https://github.com/apache/systemds/pull/2008#issuecomment-2022910722 @j143 Can you check if this fixes the issues for the release artifacts. I have tested it with the released code, and it works for me. If you set the SYSTEMDS_ROOT to the

Re: [PR] [MINOR] Fix run script [systemds]

2024-03-26 Thread via GitHub
Baunsgaard closed pull request #2007: [MINOR] Fix run script URL: https://github.com/apache/systemds/pull/2007 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] [SYSTEMDS-???] Python API startup fixes [systemds]

2024-03-26 Thread via GitHub
Baunsgaard commented on PR #2008: URL: https://github.com/apache/systemds/pull/2008#issuecomment-2021028418 Still debugging a bit, therefore it is marked as a draft. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[PR] [SYSTEMDS-???] Python API startup fixes [systemds]

2024-03-26 Thread via GitHub
Baunsgaard opened a new pull request, #2008: URL: https://github.com/apache/systemds/pull/2008 This PR change the startup of the python interface to properly use the jar files, and fixes a release issue where if the SYSTEMDS_ROOT is not set the python API did not properly hook into the

[PR] [MINOR] Fix run script [systemds]

2024-03-26 Thread via GitHub
Baunsgaard opened a new pull request, #2007: URL: https://github.com/apache/systemds/pull/2007 This commit fixes a bug i introduced a couple of weeks ago, where i erroneously forgot to include the java arguments from SYSTEMDS_STANDALONE_OPTS in the bin/systemds file when i was changing

Re: [PR] Sparse Block Iterator for non-zero Rows [systemds]

2024-03-25 Thread via GitHub
mboehm7 closed pull request #2005: Sparse Block Iterator for non-zero Rows URL: https://github.com/apache/systemds/pull/2005 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Sparse Block Iterator for non-zero Rows [systemds]

2024-03-25 Thread via GitHub
mboehm7 commented on PR #2005: URL: https://github.com/apache/systemds/pull/2005#issuecomment-2018363376 LGTM - thanks for the patch @ReneEnjilian. I'll only change minor things during the merge. Overall, I think it might be a better choice for performance and separation to move the

Re: [PR] Bump follow-redirects from 1.15.5 to 1.15.6 [systemds-website]

2024-03-23 Thread via GitHub
j143 merged PR #139: URL: https://github.com/apache/systemds-website/pull/139 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [DOCS] SystemDS 3.2.0 docs [systemds-website]

2024-03-23 Thread via GitHub
j143 merged PR #141: URL: https://github.com/apache/systemds-website/pull/141 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] [DOCS] SystemDS 3.2.0 docs [systemds-website]

2024-03-23 Thread via GitHub
j143 opened a new pull request, #141: URL: https://github.com/apache/systemds-website/pull/141 Steps here: https://github.com/apache/systemds-website/blob/main/README.md#release-docs -- This is an automated message from the Apache Git Service. To respond to the message, please log on

  1   2   3   4   5   6   7   8   9   10   >