Re: [PR] [SYSTEMDS-3666] Simplify Not ('!') over comparisons [systemds]

2024-03-17 Thread via GitHub
mboehm7 closed pull request #1988: [SYSTEMDS-3666] Simplify Not ('!') over comparisons URL: https://github.com/apache/systemds/pull/1988 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [SYSTEMDS-3666] Simplify Not ('!') over comparisons [systemds]

2024-03-17 Thread via GitHub
mboehm7 commented on PR #1988: URL: https://github.com/apache/systemds/pull/1988#issuecomment-2002563344 LGTM. Thanks for the patch @ReneEnjilian - during the merge I only moved the rewrite from dynamic to static rewrites (no size-based decision), tightened the source pattern (only if NOT

Re: [PR] [SYSTEMDS-3666] Simplify Not ('!') over comparisons [systemds]

2024-01-25 Thread via GitHub
mboehm7 commented on PR #1988: URL: https://github.com/apache/systemds/pull/1988#issuecomment-1910266945 Thanks @ReneEnjilian for the continued contributions. I'll have a closer look and merge this in once we cut the release tag (after finishing the remaining bug fixes) just to ensure such