[GitHub] [systemds] skogler commented on pull request #993: [SYSTEMDS-265] Entity resolution pipelines and primitives.

2020-07-19 Thread GitBox
skogler commented on pull request #993: URL: https://github.com/apache/systemds/pull/993#issuecomment-660731660 Yeah, the only way I can find to get the tests to run reliably is to set the maven surefire plugin option `parallel` to `none`.

[GitHub] [systemds] skogler commented on pull request #993: [SYSTEMDS-265] Entity resolution pipelines and primitives.

2020-07-19 Thread GitBox
skogler commented on pull request #993: URL: https://github.com/apache/systemds/pull/993#issuecomment-660730466 I added `@NotThreadSafe` annotations now, which is consistent with some other tests but I think it does not work reliably.

[GitHub] [systemds] skogler commented on pull request #993: [SYSTEMDS-265] Entity resolution pipelines and primitives.

2020-07-19 Thread GitBox
skogler commented on pull request #993: URL: https://github.com/apache/systemds/pull/993#issuecomment-660726427 Okay, its a problem with the combination of maven surefire and JUnit parameterized tests. Running the test from IDEA works fine. Removing the parametrization also makes

[GitHub] [systemds] skogler commented on pull request #993: [SYSTEMDS-265] Entity resolution pipelines and primitives.

2020-07-19 Thread GitBox
skogler commented on pull request #993: URL: https://github.com/apache/systemds/pull/993#issuecomment-660705051 Thanks, it seems that its related to how the test is called. I'll try to build the docker image and test with that.

[GitHub] [systemds] skogler commented on pull request #993: [SYSTEMDS-265] Entity resolution pipelines and primitives.

2020-07-18 Thread GitBox
skogler commented on pull request #993: URL: https://github.com/apache/systemds/pull/993#issuecomment-660455081 Not sure how to reproduce this test failure locally, it always works, with spark-submit as well as with or without Intel MKL.