[GitHub] [systemml] t201 opened a new pull request #951: [DOC] Documentation for builtin gnmf function

2020-06-05 Thread GitBox
t201 opened a new pull request #951: URL: https://github.com/apache/systemml/pull/951 Closes #941. ## `set intersection for numeric data`-Function The `set intersection for numeric data`-function implements the intersection of two matrices by taking into input known as sets.

[GitHub] [systemml] wizard-420 opened a new pull request #952: This PR contains docs for ConfusionMatrix function.

2020-06-05 Thread GitBox
wizard-420 opened a new pull request #952: URL: https://github.com/apache/systemml/pull/952 please review if any changes are there to be done. This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [systemml] wizard-420 commented on pull request #952: [DOC] Documentation for builtin ConfusionMatrix function.

2020-06-05 Thread GitBox
wizard-420 commented on pull request #952: URL: https://github.com/apache/systemml/pull/952#issuecomment-639338011 > please review if any changes are there to be done. I have also uploaded the output in private doc. Th

[GitHub] [systemml] j143 closed pull request #951: [DOC] Documentation for builtin gnmf function

2020-06-05 Thread GitBox
j143 closed pull request #951: URL: https://github.com/apache/systemml/pull/951 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [systemml] j143 commented on pull request #952: [DOC] Documentation for builtin ConfusionMatrix function.

2020-06-05 Thread GitBox
j143 commented on pull request #952: URL: https://github.com/apache/systemml/pull/952#issuecomment-639390973 Hi @wizard-420 - Try to make sure that there are only commits related to `ConfusionMatrix`. Tip: Google these keywords - `how to rebase from command line`, `git rebase -i`

Re: [DISCUSSION] Website stack `systemml.apache.org`. Thanks.

2020-06-05 Thread Janardhan
Thank you, Sebastian. I've noticed toOneHot previously, only this function seems to be duplicated! Right now, there are five contributors who will be here only for the next five days. For this reason we are working on plain md files, which further can be transferred to corresponding DML files if

[GitHub] [systemml] escher-m commented on pull request #950: [DOC] Documentation for builtin gridSearch function

2020-06-05 Thread GitBox
escher-m commented on pull request #950: URL: https://github.com/apache/systemml/pull/950#issuecomment-639405879 In addition to the function code, I took reference from [test](https://github.com/apache/systemml/blob/master/src/test/scripts/functions/builtin/GridSearchLM.dml) -

[GitHub] [systemml] j143 commented on pull request #950: [DOC] Documentation for builtin gridSearch function

2020-06-05 Thread GitBox
j143 commented on pull request #950: URL: https://github.com/apache/systemml/pull/950#issuecomment-639412730 Hi @escher-m, search for the commit related to `gridsearch` in this repository, in that commit you would find some test files in .dml --

[GitHub] [systemml] j143 commented on pull request #950: [DOC] Documentation for builtin gridSearch function

2020-06-05 Thread GitBox
j143 commented on pull request #950: URL: https://github.com/apache/systemml/pull/950#issuecomment-639413541 Meanwhile: Figure out `how to work with git from commandline`. (Google this line!) This is an automated m

Re: [DISCUSSION] Website stack `systemml.apache.org`. Thanks.

2020-06-05 Thread arnab phani
That's a good suggestion. One thing I want to point out that Builtins.java [1] contains all the dml-bodied and java-bodied built-ins. For the dml built-ins, it is easier to parse the corresponding dml script (if documentation is available there), but for other built-ins, I am not aware of any parti

[GitHub] [systemml] j143 commented on pull request #936: [DOC] Documentation for builtin msvm function

2020-06-05 Thread GitBox
j143 commented on pull request #936: URL: https://github.com/apache/systemml/pull/936#issuecomment-639447621 @h0901 - `num_classes` is not the function argument as you've mentioned. This is an automated message from the Apach

[GitHub] [systemml] j143 commented on pull request #936: [DOC] Documentation for builtin msvm function

2020-06-05 Thread GitBox
j143 commented on pull request #936: URL: https://github.com/apache/systemml/pull/936#issuecomment-639447887 Thank you, @h0901 - LGTM. 👍 🎉 🚀 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [systemml] asfgit closed pull request #936: [DOC] Documentation for builtin msvm function

2020-06-05 Thread GitBox
asfgit closed pull request #936: URL: https://github.com/apache/systemml/pull/936 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [systemml] j143 commented on a change in pull request #950: [DOC] Documentation for builtin gridSearch function

2020-06-05 Thread GitBox
j143 commented on a change in pull request #950: URL: https://github.com/apache/systemml/pull/950#discussion_r435903926 ## File path: dev/docs/builtins-reference.md ## @@ -503,3 +504,44 @@ numClasses = 5 X = round(rand(rows = 10, cols = 10, min = 1, max = numClasses)) y = toO

[GitHub] [systemml] stanp7 opened a new pull request #953: [DOC] Documentation for builtin mice function

2020-06-05 Thread GitBox
stanp7 opened a new pull request #953: URL: https://github.com/apache/systemml/pull/953 This pull request adds Documentation for builtin mice function. ![poo](https://user-images.githubusercontent.com/45222426/83886667-05427b80-a765-11ea-94ab-1dd1f3e17bf3.PNG) -

[GitHub] [systemml] j143 commented on pull request #953: [DOC] Documentation for builtin mice function

2020-06-05 Thread GitBox
j143 commented on pull request #953: URL: https://github.com/apache/systemml/pull/953#issuecomment-639535006 Thank for working on this @stanp7. In your local repository (in PowerShell): 1. Checkout `master` branch: `git checkout master` 2. Create a new branch from `master`: `git

[GitHub] [systemml] j143 commented on a change in pull request #953: [DOC] Documentation for builtin mice function

2020-06-05 Thread GitBox
j143 commented on a change in pull request #953: URL: https://github.com/apache/systemml/pull/953#discussion_r435976863 ## File path: dev/docs/builtins-reference.md ## @@ -384,6 +453,21 @@ y = X %*% rand(rows = ncol(X), cols = 1) w = lm(X = X, y = y) ress = slicefinder(X = X,

[GitHub] [systemml] j143 commented on a change in pull request #953: [DOC] Documentation for builtin mice function

2020-06-05 Thread GitBox
j143 commented on a change in pull request #953: URL: https://github.com/apache/systemml/pull/953#discussion_r435984190 ## File path: dev/docs/builtins-reference.md ## @@ -384,6 +453,21 @@ y = X %*% rand(rows = ncol(X), cols = 1) w = lm(X = X, y = y) ress = slicefinder(X = X,

[GitHub] [systemml] j143 commented on a change in pull request #953: [DOC] Documentation for builtin mice function

2020-06-05 Thread GitBox
j143 commented on a change in pull request #953: URL: https://github.com/apache/systemml/pull/953#discussion_r436003676 ## File path: dev/docs/builtins-reference.md ## @@ -384,6 +453,21 @@ y = X %*% rand(rows = ncol(X), cols = 1) w = lm(X = X, y = y) ress = slicefinder(X = X,

[GitHub] [systemml] stanp7 commented on a change in pull request #953: [DOC] Documentation for builtin mice function

2020-06-05 Thread GitBox
stanp7 commented on a change in pull request #953: URL: https://github.com/apache/systemml/pull/953#discussion_r436017848 ## File path: dev/docs/builtins-reference.md ## @@ -384,6 +453,21 @@ y = X %*% rand(rows = ncol(X), cols = 1) w = lm(X = X, y = y) ress = slicefinder(X =

[GitHub] [systemml] stanp7 commented on a change in pull request #953: [DOC] Documentation for builtin mice function

2020-06-05 Thread GitBox
stanp7 commented on a change in pull request #953: URL: https://github.com/apache/systemml/pull/953#discussion_r436017848 ## File path: dev/docs/builtins-reference.md ## @@ -384,6 +453,21 @@ y = X %*% rand(rows = ncol(X), cols = 1) w = lm(X = X, y = y) ress = slicefinder(X =

[GitHub] [systemml] escher-m commented on pull request #950: [DOC] Documentation for builtin gridSearch function

2020-06-05 Thread GitBox
escher-m commented on pull request #950: URL: https://github.com/apache/systemml/pull/950#issuecomment-639619431 > Hi @escher-m, search for the commit related to `gridsearch` in this repository, in that commit you would find some test files in .dml Yes, I did that. I added the link t

[GitHub] [systemml] j143 commented on a change in pull request #953: [DOC] Documentation for builtin mice function

2020-06-05 Thread GitBox
j143 commented on a change in pull request #953: URL: https://github.com/apache/systemml/pull/953#discussion_r436232457 ## File path: dev/docs/builtins-reference.md ## @@ -384,6 +453,21 @@ y = X %*% rand(rows = ncol(X), cols = 1) w = lm(X = X, y = y) ress = slicefinder(X = X,

[GitHub] [systemml] j143 commented on a change in pull request #952: [DOC] Documentation for builtin ConfusionMatrix function.

2020-06-05 Thread GitBox
j143 commented on a change in pull request #952: URL: https://github.com/apache/systemml/pull/952#discussion_r436232635 ## File path: dev/docs/builtins-reference.md ## @@ -318,7 +320,47 @@ slicefinder(X,W, y, k, paq, S); ### Usage ```r X = rand (rows = 50, cols = 10) -y = X

[GitHub] [systemml] t201 opened a new pull request #954: [DOC] Documentation for builtin intersect function

2020-06-05 Thread GitBox
t201 opened a new pull request #954: URL: https://github.com/apache/systemml/pull/954 This pull request adds documentation for builtin intersect function ## `intersect`-Function This is a generic function, extended from the intersect function in the base package. The elements

[GitHub] [systemml] t201 commented on pull request #954: [DOC] Documentation for builtin intersect function

2020-06-05 Thread GitBox
t201 commented on pull request #954: URL: https://github.com/apache/systemml/pull/954#issuecomment-639972512 Could you tell if this logic is correct for intersect function? :simple_smile: This is an automated message from th

[GitHub] [systemml] t201 removed a comment on pull request #954: [DOC] Documentation for builtin intersect function

2020-06-05 Thread GitBox
t201 removed a comment on pull request #954: URL: https://github.com/apache/systemml/pull/954#issuecomment-639972512 Could you tell if this logic is correct for intersect function? :simple_smile: This is an automated message

[GitHub] [systemml] t201 commented on pull request #954: [DOC] Documentation for builtin intersect function

2020-06-05 Thread GitBox
t201 commented on pull request #954: URL: https://github.com/apache/systemml/pull/954#issuecomment-639972723 Could you look if this logic is correct for intersect func. ? This is an automated message from the Apache Git Servi

[GitHub] [systemml] stanp7 commented on a change in pull request #953: [DOC] Documentation for builtin mice function

2020-06-05 Thread GitBox
stanp7 commented on a change in pull request #953: URL: https://github.com/apache/systemml/pull/953#discussion_r436234979 ## File path: dev/docs/builtins-reference.md ## @@ -384,6 +453,21 @@ y = X %*% rand(rows = ncol(X), cols = 1) w = lm(X = X, y = y) ress = slicefinder(X =

[GitHub] [systemml] j143 commented on pull request #954: [DOC] Documentation for builtin intersect function

2020-06-05 Thread GitBox
j143 commented on pull request #954: URL: https://github.com/apache/systemml/pull/954#issuecomment-639981561 Well done @t201 , I slightly modified the snippet. ```r X = rand (rows = 50, cols = 10) y = X %*% rand(rows=ncol(X), 1) Result = intersect(X,y) print(to string

[GitHub] [systemml] t201 commented on pull request #954: [DOC] Documentation for builtin intersect function

2020-06-05 Thread GitBox
t201 commented on pull request #954: URL: https://github.com/apache/systemml/pull/954#issuecomment-639986425 ![Screenshot (150)](https://user-images.githubusercontent.com/54388379/83936662-4a0cf780-a7e3-11ea-8975-cd65cc0da374.png) Collab test run Is it good to go ? I can imple

[GitHub] [systemml] wizard-420 commented on a change in pull request #952: [DOC] Documentation for builtin ConfusionMatrix function.

2020-06-05 Thread GitBox
wizard-420 commented on a change in pull request #952: URL: https://github.com/apache/systemml/pull/952#discussion_r436240465 ## File path: dev/docs/builtins-reference.md ## @@ -318,7 +320,47 @@ slicefinder(X,W, y, k, paq, S); ### Usage ```r X = rand (rows = 50, cols = 10) -

[GitHub] [systemml] wizard-420 commented on a change in pull request #952: [DOC] Documentation for builtin ConfusionMatrix function.

2020-06-05 Thread GitBox
wizard-420 commented on a change in pull request #952: URL: https://github.com/apache/systemml/pull/952#discussion_r436241640 ## File path: scripts/builtin/outlier.dml ## @@ -18,6 +18,13 @@ # under the License. # #-