[GitHub] [systemml] Baunsgaard commented on a change in pull request #971: [WIP] - Add protobuf support to write and read FrameBlocks to HDFS

2020-06-10 Thread GitBox
Baunsgaard commented on a change in pull request #971: URL: https://github.com/apache/systemml/pull/971#discussion_r437914794 ## File path: src/main/java/org/apache/sysds/parser/dml/DmlBaseListener.java ## @@ -1,4 +1,4 @@ -// Generated from org\apache\sysds\parser\dml\Dml.g4 by

[GitHub] [systemml] Baunsgaard opened a new pull request #973: [SYSTEMML-2536] Found CVEs in dependencies

2020-06-10 Thread GitBox
Baunsgaard opened a new pull request #973: URL: https://github.com/apache/systemml/pull/973 Major update of Hadoop version to 3.2.1 from 2.6.0. Will have to update servers installation to fit with this PR. https://issues.apache.org/jira/browse/SYSTEMML-2536 --

[GitHub] [systemml] muehlburger commented on a change in pull request #971: [WIP] - Add protobuf support to write and read FrameBlocks to HDFS

2020-06-10 Thread GitBox
muehlburger commented on a change in pull request #971: URL: https://github.com/apache/systemml/pull/971#discussion_r437972257 ## File path: src/main/resources/protobuf/Frame.proto ## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mor

[GitHub] [systemml] muehlburger commented on a change in pull request #971: [WIP] - Add protobuf support to write and read FrameBlocks to HDFS

2020-06-10 Thread GitBox
muehlburger commented on a change in pull request #971: URL: https://github.com/apache/systemml/pull/971#discussion_r437983995 ## File path: src/test/java/org/apache/sysds/test/functions/io/proto/FrameReaderWriterProtoTest.java ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apac

[GitHub] [systemml] muehlburger commented on a change in pull request #971: [WIP] - Add protobuf support to write and read FrameBlocks to HDFS

2020-06-10 Thread GitBox
muehlburger commented on a change in pull request #971: URL: https://github.com/apache/systemml/pull/971#discussion_r438064395 ## File path: src/test/java/org/apache/sysds/test/functions/io/proto/FrameReaderWriterProtoTest.java ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apac

[GitHub] [systemml] Shafaq-Siddiqi commented on pull request #972: [MINOR] MICE now accepts a recoded matrix as input

2020-06-10 Thread GitBox
Shafaq-Siddiqi commented on pull request #972: URL: https://github.com/apache/systemml/pull/972#issuecomment-641962097 > Can this file https://github.com/apache/systemml/blob/master/dev/docs/builtins-reference.md#mice-function also be updated? > > Thank you. Yes, I will updat

[GitHub] [systemml] Shafaq-Siddiqi commented on a change in pull request #972: [MINOR] MICE now accepts a recoded matrix as input

2020-06-10 Thread GitBox
Shafaq-Siddiqi commented on a change in pull request #972: URL: https://github.com/apache/systemml/pull/972#discussion_r438096170 ## File path: src/test/java/org/apache/sysds/test/functions/builtin/BuiltinMiceTest.java ## @@ -50,33 +50,47 @@ public void testMiceMixCP() {

[GitHub] [systemml] muehlburger commented on a change in pull request #971: [WIP] - Add protobuf support to write and read FrameBlocks to HDFS

2020-06-10 Thread GitBox
muehlburger commented on a change in pull request #971: URL: https://github.com/apache/systemml/pull/971#discussion_r438322892 ## File path: pom.xml ## @@ -1021,6 +1021,25 @@ maven-gpg-plugin 1.6 + +