Baunsgaard commented on a change in pull request #892: Extend Python API (rand,
lm, matrix multiplication)
URL: https://github.com/apache/systemml/pull/892#discussion_r410373065
##
File path: src/main/python/tests/test_matrix_aggregations.py
##
@@ -84,6 +86,63 @@ def test_
Baunsgaard commented on a change in pull request #892: Extend Python API (rand,
lm, matrix multiplication)
URL: https://github.com/apache/systemml/pull/892#discussion_r410385286
##
File path: src/main/python/systemds/matrix/matrix.py
##
@@ -141,3 +141,32 @@ def seq(sds_con
j143 opened a new pull request #67: Add new contributors
URL: https://github.com/apache/systemml-website/pull/67
Sorry that it took a long time.
@EdgarLGB can review the details. Thanks.
This is an automated message fro
phaniarnab commented on issue #891: [SYSTEMDS-333, 337]Improved lineage cache
eviction
URL: https://github.com/apache/systemml/pull/891#issuecomment-615729031
This PR is ready to be merged in.
This is an automated message fro
juliale-15 commented on a change in pull request #892: Extend Python API (rand,
lm, matrix multiplication)
URL: https://github.com/apache/systemml/pull/892#discussion_r410681017
##
File path: src/main/python/tests/test_matrix_aggregations.py
##
@@ -84,6 +86,63 @@ def test_
juliale-15 commented on a change in pull request #892: Extend Python API (rand,
lm, matrix multiplication)
URL: https://github.com/apache/systemml/pull/892#discussion_r410681349
##
File path: src/main/python/tests/test_matrix_aggregations.py
##
@@ -25,6 +25,8 @@
import wa
Baunsgaard commented on a change in pull request #892: Extend Python API (rand,
lm, matrix multiplication)
URL: https://github.com/apache/systemml/pull/892#discussion_r410681369
##
File path: src/main/python/tests/test_matrix_aggregations.py
##
@@ -84,6 +86,63 @@ def test_
juliale-15 commented on a change in pull request #892: Extend Python API (rand,
lm, matrix multiplication)
URL: https://github.com/apache/systemml/pull/892#discussion_r410684515
##
File path: src/main/python/tests/test_matrix_aggregations.py
##
@@ -84,6 +86,63 @@ def test_
Baunsgaard commented on a change in pull request #892: Extend Python API (rand,
lm, matrix multiplication)
URL: https://github.com/apache/systemml/pull/892#discussion_r410684799
##
File path: src/main/python/tests/test_matrix_aggregations.py
##
@@ -84,6 +86,63 @@ def test_
mboehm7 commented on issue #888: Built-in Generalized Linear Model (GLM )
URL: https://github.com/apache/systemml/pull/888#issuecomment-615951489
Thanks for the new builtin function @Shafaq-Siddiqi . Could you please try
to refactor the tests in order to avoid duplication with the existing
Baunsgaard commented on a change in pull request #892: Extend Python API (rand,
lm, matrix multiplication)
URL: https://github.com/apache/systemml/pull/892#discussion_r410876849
##
File path: src/main/python/tests/test_matrix_rand.py
##
@@ -0,0 +1,111 @@
+#
Baunsgaard commented on a change in pull request #892: Extend Python API (rand,
lm, matrix multiplication)
URL: https://github.com/apache/systemml/pull/892#discussion_r410876908
##
File path: src/main/python/tests/test_matrix_rand.py
##
@@ -0,0 +1,111 @@
+#
Baunsgaard commented on a change in pull request #892: Extend Python API (rand,
lm, matrix multiplication)
URL: https://github.com/apache/systemml/pull/892#discussion_r410876929
##
File path: src/main/python/tests/test_matrix_rand.py
##
@@ -0,0 +1,111 @@
+#
Baunsgaard commented on a change in pull request #892: Extend Python API (rand,
lm, matrix multiplication)
URL: https://github.com/apache/systemml/pull/892#discussion_r410876115
##
File path: src/main/python/systemds/context/systemds_context.py
##
@@ -164,4 +164,14 @@ def
Baunsgaard commented on a change in pull request #892: Extend Python API (rand,
lm, matrix multiplication)
URL: https://github.com/apache/systemml/pull/892#discussion_r410876877
##
File path: src/main/python/tests/test_matrix_rand.py
##
@@ -0,0 +1,111 @@
+#
juliale-15 commented on a change in pull request #892:
URL: https://github.com/apache/systemml/pull/892#discussion_r411258521
##
File path: src/main/python/systemds/context/systemds_context.py
##
@@ -164,4 +164,14 @@ def rand(self, rows: int, cols: int, min: Union[float,
int]
Baunsgaard commented on a change in pull request #892:
URL: https://github.com/apache/systemml/pull/892#discussion_r411293302
##
File path: src/main/python/systemds/context/systemds_context.py
##
@@ -164,4 +164,14 @@ def rand(self, rows: int, cols: int, min: Union[float,
int]
kev-inn opened a new pull request #893:
URL: https://github.com/apache/systemml/pull/893
This PR adds federated frames. It also uses the `federated` builtin, which
now has an additional parameter `type`. `type` can either be set to `"matrix"`
or `"frame"` (case-insensitive).
SPARK execu
kev-inn commented on issue #871:
URL: https://github.com/apache/systemml/pull/871#issuecomment-616539062
Ok, so currently we have the bugs:
1. ~~bug is if you create a federated matrix that is not 100% filled in by
federated workers, then operations does not take into account the remaini
Baunsgaard commented on issue #871:
URL: https://github.com/apache/systemml/pull/871#issuecomment-616543161
> 1. ~bug is if you create a federated matrix that is not 100% filled in
by federated workers, then operations does not take into account the remaining
cells.~ This should be
kev-inn commented on issue #871:
URL: https://github.com/apache/systemml/pull/871#issuecomment-616544771
> > ```
> > 1. ~bug is if you create a federated matrix that is not 100% filled in
by federated workers, then operations does not take into account the remaining
cells.~ This should
Baunsgaard commented on issue #871:
URL: https://github.com/apache/systemml/pull/871#issuecomment-616546464
> > > ```
> > > 1. ~bug is if you create a federated matrix that is not 100% filled in
by federated workers, then operations does not take into account the remaining
cells.~ This
kev-inn edited a comment on issue #871:
URL: https://github.com/apache/systemml/pull/871#issuecomment-616544771
> > ```
> > 1. ~bug is if you create a federated matrix that is not 100% filled in
by federated workers, then operations does not take into account the remaining
cells.~ This
j143 commented on issue #890:
URL: https://github.com/apache/systemml/pull/890#issuecomment-616569257
Hi @corepointer could you please review this?. Thank you.
This is an automated message from the Apache Git Service.
To resp
kev-inn edited a comment on issue #893:
URL: https://github.com/apache/systemml/pull/893#issuecomment-616591517
The tests are a bit too simplistic atm so I might add some more
This is an automated message from the Apache Git
kev-inn commented on issue #893:
URL: https://github.com/apache/systemml/pull/893#issuecomment-616591517
The tests are a bit to simplistic atm so I might add some more
This is an automated message from the Apache Git Service.
j143 commented on issue #875:
URL: https://github.com/apache/systemml/pull/875#issuecomment-617183427
Hi @Baunsgaard , let us move this forward. With each improvement, if we
track the test results in this PR itself in the phase by phase manner (Might
take a few weeks :), like with any good
Baunsgaard commented on issue #875:
URL: https://github.com/apache/systemml/pull/875#issuecomment-617192727
> Hi @Baunsgaard , let us move this forward. With each improvement, if we
track the test results in this PR itself in the phase by phase manner (Might
take a few weeks :), like with
sebwrede opened a new pull request #894:
URL: https://github.com/apache/systemml/pull/894
This pull request adds privacy constraints as metadata. The privacy
constraints are propagated from input to result of matrix multiplications. The
privacy constraints currently only contain a simple b
j143 commented on issue #894:
URL: https://github.com/apache/systemml/pull/894#issuecomment-617290219
Thanks for updating the license files. :)
A minor name change to `org.apache.sysds` might be required.
This is an a
sebwrede opened a new pull request #895:
URL: https://github.com/apache/systemml/pull/895
This pull request adds privacy constraints as metadata. The privacy
constraints are propagated from input to result of matrix multiplications. The
privacy constraints currently only contain a simple b
sebwrede commented on issue #894:
URL: https://github.com/apache/systemml/pull/894#issuecomment-617418922
I have replaced this pull request [with a new
one](https://github.com/apache/systemml/pull/895).
This is an automated
j143 commented on a change in pull request #895:
URL: https://github.com/apache/systemml/pull/895#discussion_r412642960
##
File path: src/main/java/org/tugraz/sysds/parser/DataExpression.java
##
@@ -109,31 +113,70 @@
public static final String DELIM_SPARSE = "s
j143 commented on issue #873:
URL: https://github.com/apache/systemml/pull/873#issuecomment-617531918
@kev-inn - Is this ready?
This is an automated message from the Apache Git Service.
To respond to the message, please log o
sebwrede commented on a change in pull request #895:
URL: https://github.com/apache/systemml/pull/895#discussion_r412793957
##
File path: src/main/java/org/tugraz/sysds/parser/DataExpression.java
##
@@ -109,31 +113,70 @@
public static final String DELIM_SPARSE
kev-inn edited a comment on issue #873:
URL: https://github.com/apache/systemml/pull/873#issuecomment-617642812
@j143 I think so, yes.
This is an automated message from the Apache Git Service.
To respond to the message, pleas
kev-inn commented on issue #873:
URL: https://github.com/apache/systemml/pull/873#issuecomment-617642812
@j143 I believe so, yes.
This is an automated message from the Apache Git Service.
To respond to the message, please log
j143 commented on a change in pull request #873:
URL: https://github.com/apache/systemml/pull/873#discussion_r412896464
##
File path: src/main/python/README.md
##
@@ -1,4 +1,7 @@
-# Python Readme
+# SystemDS
+
+[:
def __ne__(self, other):
Baunsgaard commented on a change in pull request #892:
URL: https://github.com/apache/systemml/pull/892#discussion_r410876908
##
File path: src/main/python/tests/test_matrix_rand.py
##
@@ -0,0 +1,111 @@
+#-
+#
+# Licen
Baunsgaard removed a comment on issue #872:
URL: https://github.com/apache/systemml/pull/872#issuecomment-615276665
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
Baunsgaard opened a new pull request #896:
URL: https://github.com/apache/systemml/pull/896
[MINOR] Python Lineage Trace Test Change
Change to the way lineage trace tests are executed, such that instead of
having files to compare to, the python trace is compared to a trace made
Baunsgaard commented on issue #896:
URL: https://github.com/apache/systemml/pull/896#issuecomment-618375500
Currently failing because python interface call operations with 1 thread
only, while sysds calls with max number of threads.
Baunsgaard commented on issue #896:
URL: https://github.com/apache/systemml/pull/896#issuecomment-618375842
@phaniarnab comments, please?
This is an automated message from the Apache Git Service.
To respond to the message, pl
Baunsgaard commented on a change in pull request #896:
URL: https://github.com/apache/systemml/pull/896#discussion_r413777910
##
File path: src/main/python/tests/lineage/test_lineagetrace.py
##
@@ -0,0 +1,98 @@
+# -
+#
sebwrede commented on issue #895:
URL: https://github.com/apache/systemml/pull/895#issuecomment-618388313
I will rebase this branch to resolve the conflicts. Please wait with any
edits.
This is an automated message from the
sebwrede commented on issue #895:
URL: https://github.com/apache/systemml/pull/895#issuecomment-618410337
The rebase is done. The checks are failing because [Github's servers are
having problems](https://www.githubstatus.com/).
-
phaniarnab commented on a change in pull request #896:
URL: https://github.com/apache/systemml/pull/896#discussion_r413905307
##
File path: src/main/python/tests/lineage/test_lineagetrace.py
##
@@ -0,0 +1,98 @@
+# -
+#
phaniarnab commented on issue #896:
URL: https://github.com/apache/systemml/pull/896#issuecomment-618478532
This looks very good. Thanks for making the test better. As discussed
offline, comparing only the internal nodes might solve the problem of metadata
mismatch.
mboehm7 commented on pull request #871:
URL: https://github.com/apache/systemml/pull/871#issuecomment-618635193
LGTM - that's awesome. Thanks for the thoughtful addition of tests, docs,
and scripts.
Minor things for future modifications: First, maybe it make sense to add a
badge fo
mboehm7 commented on pull request #891:
URL: https://github.com/apache/systemml/pull/891#issuecomment-618643341
LGTM - thanks for the fine tuning.
Just for awareness: I would recommend to avoid statistics maintenance for
simple cost formulas as the time measurement via `System.nanot
mboehm7 commented on pull request #891:
URL: https://github.com/apache/systemml/pull/891#issuecomment-618643961
During the merge, I fixed few warnings.
This is an automated message from the Apache Git Service.
To respond to t
j143 commented on pull request #67:
URL: https://github.com/apache/systemml-website/pull/67#issuecomment-618848567
Hi @EdgarLGB . Would you mind looking at this.
This is an automated message from the Apache Git Service.
To re
Baunsgaard commented on pull request #896:
URL: https://github.com/apache/systemml/pull/896#issuecomment-618872315
LGTM :grinning:
@mboehm7 or @j143 , could you merge ? (It would fix the few issues we have
on master now.)
---
mboehm7 commented on pull request #896:
URL: https://github.com/apache/systemml/pull/896#issuecomment-619157501
LGTM - thanks @Baunsgaard. In general this is fine, but in the future, it
would be good to preserve the history for renamed/moved files
(`src/main/python/tests/test_lineagetrace.
mboehm7 commented on pull request #895:
URL: https://github.com/apache/systemml/pull/895#issuecomment-619192271
LGTM - thanks for the initial integration @sebwrede. During the merge I made
only some minor formatting fixes (tabs over spaces, verbosity) and slightly
changed the hop/lop metad
j143 commented on pull request #892:
URL: https://github.com/apache/systemml/pull/892#issuecomment-619205429
Hi, How is this going?
This is an automated message from the Apache Git Service.
To respond to the message, please l
phaniarnab opened a new pull request #897:
URL: https://github.com/apache/systemml/pull/897
This patch contains
- two new partial rewrites which are specialization of existing
rewrites,
- bugfixes and optimizations in partial rewrites,
- lineage tracing for removeEmpty,
- a ne
j143 commented on pull request #893:
URL: https://github.com/apache/systemml/pull/893#issuecomment-619402366
Hi @kev-inn , If this is a more work. This can be broken down into 2 to 3 PR
s which makes it very easier for review and merging.
Anyway, should I review this?
j143 opened a new pull request #898:
URL: https://github.com/apache/systemml/pull/898
This is as per the discussion at
[dev@systemml](https://www.mail-archive.com/dev@systemml.apache.org/msg01051.html)
This is an automated m
j143 commented on pull request #889:
URL: https://github.com/apache/systemml/pull/889#issuecomment-619427626
Hi @mboehm7 - I have verified the results manually and also against the R
Script.
Can I merge this. Thank you.
j143 commented on pull request #896:
URL: https://github.com/apache/systemml/pull/896#issuecomment-619429199
Normally, the `refactor` option in the IDEs should preserve git history.
This is an automated message from the Apach
j143 opened a new pull request #899:
URL: https://github.com/apache/systemml/pull/899
@phaniarnab - Can this reviewed.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
mboehm7 commented on pull request #872:
URL: https://github.com/apache/systemml/pull/872#issuecomment-619432671
LGTM - overall this is great @Baunsgaard. During the merge, I just fixed a
few typos, and minor warnings (generics, static methods).
Additionally, you might want to conside
kev-inn commented on pull request #893:
URL: https://github.com/apache/systemml/pull/893#issuecomment-619435229
>
>
> Hi @kev-inn , If this is a more work. This can be broken down into 2 to 3
PR s which makes it very easier for review and merging.
>
> Anyway, should I review
mboehm7 commented on pull request #889:
URL: https://github.com/apache/systemml/pull/889#issuecomment-619437072
LGTM - thanks @j143. During the merge, I fixed the sparsity configuration as
all tests ran with the dense configuration. Furthermore, I cleaned up the test
a bit (to use the util
j143 removed a comment on pull request #890:
URL: https://github.com/apache/systemml/pull/890#issuecomment-616569257
Hi @corepointer could you please review this?. Thank you.
This is an automated message from the Apache Git S
j143 commented on pull request #898:
URL: https://github.com/apache/systemml/pull/898#issuecomment-619439228
@Baunsgaard - any comments about badges?
This is an automated message from the Apache Git Service.
To respond to the
mboehm7 commented on pull request #896:
URL: https://github.com/apache/systemml/pull/896#issuecomment-619442689
Yes, git is able to detect plain refactorings - the problem usually arises,
if a commit does refactoring AND makes major code changes.
--
j143 commented on pull request #892:
URL: https://github.com/apache/systemml/pull/892#issuecomment-619491428
@Baunsgaard - Does this PR look good to you.
Suggestion: A more involved test can be handled in a different PR. 😄
--
phaniarnab commented on a change in pull request #899:
URL: https://github.com/apache/systemml/pull/899#discussion_r415132839
##
File path: src/main/java/org/apache/sysds/api/jmlc/PreparedScript.java
##
@@ -476,8 +476,14 @@ public String explain() {
/**
* Cap
Baunsgaard commented on pull request #896:
URL: https://github.com/apache/systemml/pull/896#issuecomment-619540385
I will note it down, and try to make it so next time :)
This is an automated message from the Apache Git Servi
juliale-15 commented on a change in pull request #892:
URL: https://github.com/apache/systemml/pull/892#discussion_r415299048
##
File path: src/main/python/systemds/matrix/operation_node.py
##
@@ -229,3 +233,10 @@ def moment(self, moment, weights: DAGNode = None) ->
'Operation
j143 commented on a change in pull request #899:
URL: https://github.com/apache/systemml/pull/899#discussion_r415299286
##
File path: src/main/java/org/apache/sysds/api/jmlc/PreparedScript.java
##
@@ -476,8 +476,14 @@ public String explain() {
/**
* Capture l
Baunsgaard commented on pull request #872:
URL: https://github.com/apache/systemml/pull/872#issuecomment-619542266
> LGTM - overall this is great @Baunsgaard. During the merge, I just fixed a
few typos, and minor warnings (generics, static methods).
Thanks @mboehm7 for the fixes :+1
Baunsgaard commented on a change in pull request #892:
URL: https://github.com/apache/systemml/pull/892#discussion_r410382542
##
File path: src/main/python/tests/test_matrix_aggregations.py
##
@@ -84,6 +86,63 @@ def test_var2(self):
def test_var3(self):
self.asser
Baunsgaard commented on a change in pull request #892:
URL: https://github.com/apache/systemml/pull/892#discussion_r415304170
##
File path: src/main/python/systemds/matrix/operation_node.py
##
@@ -229,3 +233,10 @@ def moment(self, moment, weights: DAGNode = None) ->
'Operation
Baunsgaard commented on a change in pull request #892:
URL: https://github.com/apache/systemml/pull/892#discussion_r415304586
##
File path: src/main/python/systemds/context/systemds_context.py
##
@@ -164,4 +164,14 @@ def rand(self, rows: int, cols: int, min: Union[float,
int]
Baunsgaard commented on a change in pull request #892:
URL: https://github.com/apache/systemml/pull/892#discussion_r410876849
##
File path: src/main/python/tests/test_matrix_rand.py
##
@@ -0,0 +1,111 @@
+#-
+#
+# Licen
Baunsgaard commented on pull request #892:
URL: https://github.com/apache/systemml/pull/892#issuecomment-619546245
LGTM, Many thanks @juliale-15 :100:.
Absolutely great first addition! I will start using them immediately, hope
you learned something! :smile:
@j143 Yes it can be m
mboehm7 commented on pull request #872:
URL: https://github.com/apache/systemml/pull/872#issuecomment-619598188
ok that makes a lot of sense - I though of lossy compression techniques as
ColGroups but you're right it might be better to indicate that at global level
(lossy if at least one l
mboehm7 commented on pull request #892:
URL: https://github.com/apache/systemml/pull/892#issuecomment-619602232
Great, thank you so much @juliale-15 and @Baunsgaard - I'll merge it in.
This is an automated message from the Ap
j143 commented on pull request #898:
URL: https://github.com/apache/systemml/pull/898#issuecomment-619609239
Thank you. Yes, things like this are too difficult agree upon by everyone 😸 .
This is an automated message from the
j143 commented on pull request #890:
URL: https://github.com/apache/systemml/pull/890#issuecomment-619612338
Hi @mboehm7 - As we have discussed 2 years ago, I have created an R script,
and a dml script and passed the same rand matrices to both the PRs.
Although, tricky cases were not
mboehm7 commented on pull request #890:
URL: https://github.com/apache/systemml/pull/890#issuecomment-619613480
Thanks for your effort @j143 - I'll have a look into it tomorrow and merge
it in afterwards.
This is an automate
j143 commented on a change in pull request #893:
URL: https://github.com/apache/systemml/pull/893#discussion_r415398205
##
File path: src/main/java/org/apache/sysds/runtime/util/UtilFunctions.java
##
@@ -41,6 +36,18 @@
import org.apache.sysds.runtime.matrix.data.Pair;
import
juliale-15 commented on pull request #892:
URL: https://github.com/apache/systemml/pull/892#issuecomment-619790904
> Great, thank you so much @juliale-15 and @Baunsgaard - I'll merge it in.
Great thank you! Yesterday I did a small fix in the rand and lm test and
didn't realized that
Baunsgaard commented on pull request #892:
URL: https://github.com/apache/systemml/pull/892#issuecomment-619834621
Yes, make a new PR :smile:, sorry for the spontaneous merge
:upside_down_face:.
This is an automated message
Baunsgaard opened a new pull request #900:
URL: https://github.com/apache/systemml/pull/900
This PR, contains code for upgrading the python interface to rerun code
segments in DML without the recompilation step. To enable faster iteration of
parameters.
--
Shafaq-Siddiqi opened a new pull request #901:
URL: https://github.com/apache/systemml/pull/901
Some minor additions in the functionalities of outlier built-ins i.e.,
addition of converting outliers into missing values case, two more test cases
for MICE and extending the winsorize from col
juliale-15 opened a new pull request #902:
URL: https://github.com/apache/systemml/pull/902
Just a few changes to the testcase (increasing tolerance) so that the tc
doesn't fail randomly.
Remove mutiple definitions of run in python workflow file.
---
EdgarLGB commented on a change in pull request #67:
URL: https://github.com/apache/systemml-website/pull/67#discussion_r416170870
##
File path: _src/_data/contributors.yml
##
@@ -69,6 +69,12 @@
role: PMC Member
org: IBM
+- name: Guobao Li
+ apacheId: liguobao
+ github
EdgarLGB commented on pull request #67:
URL: https://github.com/apache/systemml-website/pull/67#issuecomment-620253329
Hi @j143 , sorry for the delay. Thanks for adding me in the list! But I am
wondering why I don't have the write permission of the project. Since I am the
committer, I gues
mboehm7 commented on pull request #890:
URL: https://github.com/apache/systemml/pull/890#issuecomment-620264470
LGTM too - during the merge, I fixed the formatting, replaced the custom
functions with available `tanh` native builtin functions, and reduced the test
sizes a bit. The duplicate
j143 commented on pull request #67:
URL: https://github.com/apache/systemml-website/pull/67#issuecomment-620449010
Hi @EdgarLGB - You do have all the permissions.
**Setup, to sync gitbox and github**
Visit: https://gitbox.apache.org/setup/
The instructions there should be
1 - 100 of 918 matches
Mail list logo
