[jira] [Commented] (TAMAYA-217) Migrate all tests in module core

2018-11-29 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/TAMAYA-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16703858#comment-16703858 ] ASF subversion and git services commented on TAMAYA-217: Commit

[jira] [Commented] (TAMAYA-217) Migrate all tests in module core

2018-11-29 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/TAMAYA-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16703859#comment-16703859 ] ASF subversion and git services commented on TAMAYA-217: Commit

[jira] [Commented] (TAMAYA-217) Migrate all tests in module core

2018-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TAMAYA-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16703862#comment-16703862 ] ASF GitHub Bot commented on TAMAYA-217: --- Github user asfgit closed the pull request at:

[jira] [Commented] (TAMAYA-217) Migrate all tests in module core

2018-11-29 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/TAMAYA-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16703857#comment-16703857 ] ASF subversion and git services commented on TAMAYA-217: Commit

[jira] [Commented] (TAMAYA-217) Migrate all tests in module core

2018-11-29 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/TAMAYA-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16703860#comment-16703860 ] ASF subversion and git services commented on TAMAYA-217: Commit

[jira] [Commented] (TAMAYA-217) Migrate all tests in module core

2018-11-29 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/TAMAYA-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16703861#comment-16703861 ] ASF subversion and git services commented on TAMAYA-217: Commit

[GitHub] incubator-tamaya-extensions pull request #19: TAMAYA-217 Spring bumps

2018-11-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-tamaya-extensions/pull/19 ---

[GitHub] incubator-tamaya pull request #28: EnumConverter works with null values

2018-11-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-tamaya/pull/28 ---

Re: Pitest failures in Extensions

2018-11-29 Thread William Lieurance
It sure does. I've got 2 PRs that address that: https://github.com/apache/incubator-tamaya/pull/28 is the one you should merge first. It fixes an NPE thrown if EnumConverter hits a null value. https://github.com/apache/incubator-tamaya-extensions/pull/19 is the fix for the error you see in

[jira] [Commented] (TAMAYA-217) Migrate all tests in module core

2018-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TAMAYA-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16703001#comment-16703001 ] ASF GitHub Bot commented on TAMAYA-217: --- GitHub user peculater opened a pull request:

[GitHub] incubator-tamaya pull request #28: EnumConverter works with null values

2018-11-29 Thread peculater
GitHub user peculater opened a pull request: https://github.com/apache/incubator-tamaya/pull/28 EnumConverter works with null values Previously, EnumConverter would throw an NPE if passed a null value, but only because of an attempted .toUpperCase() which didn't get caught.

[GitHub] incubator-tamaya-extensions pull request #19: TAMAYA-217 Spring bumps

2018-11-29 Thread peculater
GitHub user peculater opened a pull request: https://github.com/apache/incubator-tamaya-extensions/pull/19 TAMAYA-217 Spring bumps This moves all of the asserts to AssertJ, as we're trying to do everywhere. It also updates the version of Spring that we test against to 5.1.2