[jira] [Commented] (TAMAYA-334) Update geronimo-annotation dependency to 1.0

2018-09-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TAMAYA-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16625798#comment-16625798 ] ASF GitHub Bot commented on TAMAYA-334: --- GitHub user acoburn opened a pull request:

[GitHub] incubator-tamaya-extensions pull request #8: TAMAYA-334: Update geronimo-ann...

2018-09-24 Thread acoburn
GitHub user acoburn opened a pull request: https://github.com/apache/incubator-tamaya-extensions/pull/8 TAMAYA-334: Update geronimo-annotation dependency This updates the geronimo-annotation dependency from 1.0-alpha-1 to 1.0 You can merge this pull request into a Git repository by

[jira] [Commented] (TAMAYA-350) Empty entry handling YAML Property Source

2018-09-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TAMAYA-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16626050#comment-16626050 ] ASF GitHub Bot commented on TAMAYA-350: --- Github user alexsuter commented on the issue:

[GitHub] incubator-tamaya-extensions issue #7: TAMAYA-350 - Do not provide null as "n...

2018-09-24 Thread alexsuter
Github user alexsuter commented on the issue: https://github.com/apache/incubator-tamaya-extensions/pull/7 Meanwhile I think it would better, to not provide null values in the properties at all. ---

[GitHub] incubator-tamaya-extensions pull request #9: TAMAYA-351 Do not append newlin...

2018-09-24 Thread alexsuter
GitHub user alexsuter opened a pull request: https://github.com/apache/incubator-tamaya-extensions/pull/9 TAMAYA-351 Do not append newline (\n) at the end of a value when resolved with FileResolver You can merge this pull request into a Git repository by running: $ git pull

[jira] [Updated] (TAMAYA-351) Do not append newline (\n) at the end of a value when resolved with FileResolver

2018-09-24 Thread Alexander Suter (JIRA)
[ https://issues.apache.org/jira/browse/TAMAYA-351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Suter updated TAMAYA-351: --- Summary: Do not append newline (\n) at the end of a value when resolved with FileResolver

[jira] [Commented] (TAMAYA-351) Do not append newline (\n) at the end of a value when resolved with FileResolver

2018-09-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TAMAYA-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16626057#comment-16626057 ] ASF GitHub Bot commented on TAMAYA-351: --- GitHub user alexsuter opened a pull request:

[jira] [Created] (TAMAYA-351) Do not append newline (\n) at the and in FileResolver

2018-09-24 Thread Alexander Suter (JIRA)
Alexander Suter created TAMAYA-351: -- Summary: Do not append newline (\n) at the and in FileResolver Key: TAMAYA-351 URL: https://issues.apache.org/jira/browse/TAMAYA-351 Project: Tamaya

[jira] [Commented] (TAMAYA-352) Unpredictable behavior when a resolver can't resolve the value

2018-09-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TAMAYA-352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16626072#comment-16626072 ] ASF GitHub Bot commented on TAMAYA-352: --- GitHub user alexsuter opened a pull request:

[GitHub] incubator-tamaya-extensions pull request #10: /TAMAYA-352 Unpredictable beha...

2018-09-24 Thread alexsuter
GitHub user alexsuter opened a pull request: https://github.com/apache/incubator-tamaya-extensions/pull/10 /TAMAYA-352 Unpredictable behavior when a resolver can't resolve the … …value You can merge this pull request into a Git repository by running: $ git pull

[jira] [Created] (TAMAYA-352) Unpredictable behavior when a file resolver can't resolve the value

2018-09-24 Thread Alexander Suter (JIRA)
Alexander Suter created TAMAYA-352: -- Summary: Unpredictable behavior when a file resolver can't resolve the value Key: TAMAYA-352 URL: https://issues.apache.org/jira/browse/TAMAYA-352 Project:

[jira] [Updated] (TAMAYA-352) Unpredictable behavior when a resolver can't resolve the value

2018-09-24 Thread Alexander Suter (JIRA)
[ https://issues.apache.org/jira/browse/TAMAYA-352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Suter updated TAMAYA-352: --- Summary: Unpredictable behavior when a resolver can't resolve the value (was: Unpredictable

[GitHub] incubator-tamaya-extensions pull request #8: TAMAYA-334: Update geronimo-ann...

2018-09-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-tamaya-extensions/pull/8 ---

[jira] [Commented] (TAMAYA-351) Do not append newline (\n) at the end of a value when resolved with FileResolver

2018-09-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TAMAYA-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16626208#comment-16626208 ] ASF GitHub Bot commented on TAMAYA-351: --- Github user ottlinger commented on a diff in the pull

[GitHub] incubator-tamaya-extensions issue #7: TAMAYA-350 - Do not provide null as "n...

2018-09-24 Thread ottlinger
Github user ottlinger commented on the issue: https://github.com/apache/incubator-tamaya-extensions/pull/7 Please add a test case to avoid regressions. Thanks ---

[jira] [Commented] (TAMAYA-350) Empty entry handling YAML Property Source

2018-09-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TAMAYA-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16626224#comment-16626224 ] ASF GitHub Bot commented on TAMAYA-350: --- Github user ottlinger commented on the issue:

[GitHub] incubator-tamaya-extensions issue #9: TAMAYA-351 Do not append newline (\n) ...

2018-09-24 Thread ottlinger
Github user ottlinger commented on the issue: https://github.com/apache/incubator-tamaya-extensions/pull/9 Thanks for your contributions - did you already file a CLA with ApacheSoftwareFoundation to properly license your commits? Thanks. ---

[jira] [Commented] (TAMAYA-351) Do not append newline (\n) at the end of a value when resolved with FileResolver

2018-09-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TAMAYA-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16626202#comment-16626202 ] ASF GitHub Bot commented on TAMAYA-351: --- Github user ottlinger commented on the issue:

[jira] [Commented] (TAMAYA-334) Update geronimo-annotation dependency to 1.0

2018-09-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TAMAYA-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16626206#comment-16626206 ] ASF GitHub Bot commented on TAMAYA-334: --- Github user asfgit closed the pull request at:

[jira] [Commented] (TAMAYA-334) Update geronimo-annotation dependency to 1.0

2018-09-24 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/TAMAYA-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16626205#comment-16626205 ] ASF subversion and git services commented on TAMAYA-334: Commit

[GitHub] incubator-tamaya-extensions pull request #9: TAMAYA-351 Do not append newlin...

2018-09-24 Thread ottlinger
Github user ottlinger commented on a diff in the pull request: https://github.com/apache/incubator-tamaya-extensions/pull/9#discussion_r219938377 --- Diff: modules/resolver/src/main/java/org/apache/tamaya/resolver/internal/FileResolver.java --- @@ -86,7 +86,12 @@ public String

[jira] [Commented] (TAMAYA-350) Empty entry handling YAML Property Source

2018-09-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TAMAYA-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16626346#comment-16626346 ] ASF GitHub Bot commented on TAMAYA-350: --- Github user alexsuter commented on the issue:

[GitHub] incubator-tamaya-extensions issue #9: TAMAYA-351 Do not append newline (\n) ...

2018-09-24 Thread alexsuter
Github user alexsuter commented on the issue: https://github.com/apache/incubator-tamaya-extensions/pull/9 Fixed + Test added ---

[jira] [Commented] (TAMAYA-351) Do not append newline (\n) at the end of a value when resolved with FileResolver

2018-09-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TAMAYA-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16626407#comment-16626407 ] ASF GitHub Bot commented on TAMAYA-351: --- Github user alexsuter commented on the issue:

[GitHub] incubator-tamaya-extensions issue #10: TAMAYA-352 Unpredictable behavior whe...

2018-09-24 Thread alexsuter
Github user alexsuter commented on the issue: https://github.com/apache/incubator-tamaya-extensions/pull/10 Before I fix the test and contribute new test, I want first to talk about the idea behind this pull request. What do you think about that? ---

[jira] [Commented] (TAMAYA-352) Unpredictable behavior when a resolver can't resolve the value

2018-09-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TAMAYA-352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16626409#comment-16626409 ] ASF GitHub Bot commented on TAMAYA-352: --- Github user alexsuter commented on the issue:

[GitHub] incubator-tamaya-extensions issue #9: TAMAYA-351 Do not append newline (\n) ...

2018-09-24 Thread peculater
Github user peculater commented on the issue: https://github.com/apache/incubator-tamaya-extensions/pull/9 Newlines are notoriously complex, and I see that you're assuming Unix style and not windows style. I'm comparing to the code in StringUtils in apache commons. Any chance we

[jira] [Commented] (TAMAYA-351) Do not append newline (\n) at the end of a value when resolved with FileResolver

2018-09-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TAMAYA-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16626416#comment-16626416 ] ASF GitHub Bot commented on TAMAYA-351: --- Github user peculater commented on the issue:

[GitHub] incubator-tamaya-extensions issue #9: TAMAYA-351 Do not append newline (\n) ...

2018-09-24 Thread alexsuter
Github user alexsuter commented on the issue: https://github.com/apache/incubator-tamaya-extensions/pull/9 Which Java Level do we have to support? Since Java 7 there are a lot of shortcut methods, to read a file:

[jira] [Commented] (TAMAYA-351) Do not append newline (\n) at the end of a value when resolved with FileResolver

2018-09-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TAMAYA-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16626429#comment-16626429 ] ASF GitHub Bot commented on TAMAYA-351: --- Github user alexsuter commented on the issue:

[jira] [Resolved] (TAMAYA-334) Update geronimo-annotation dependency to 1.0

2018-09-24 Thread Aaron Coburn (JIRA)
[ https://issues.apache.org/jira/browse/TAMAYA-334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aaron Coburn resolved TAMAYA-334. - Resolution: Fixed > Update geronimo-annotation dependency to 1.0 >

[jira] [Commented] (TAMAYA-351) Do not append newline (\n) at the end of a value when resolved with FileResolver

2018-09-24 Thread Alexander Suter (JIRA)
[ https://issues.apache.org/jira/browse/TAMAYA-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16626800#comment-16626800 ] Alexander Suter commented on TAMAYA-351: [~hugo.hirsch] I filed the ICLA today. Thanks for the

[jira] [Commented] (TAMAYA-351) Do not append newline (\n) at the end of a value when resolved with FileResolver

2018-09-24 Thread Philipp Ottlinger (JIRA)
[ https://issues.apache.org/jira/browse/TAMAYA-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16626330#comment-16626330 ] Philipp Ottlinger commented on TAMAYA-351: -- [~alexsuter] feel free to start at: *

[jira] [Commented] (TAMAYA-351) Do not append newline (\n) at the end of a value when resolved with FileResolver

2018-09-24 Thread Alexander Suter (JIRA)
[ https://issues.apache.org/jira/browse/TAMAYA-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16626328#comment-16626328 ] Alexander Suter commented on TAMAYA-351: Hello [~hugo.hirsch] Can you please send me a link, how