derkoe commented on PR #38:
URL: https://github.com/apache/tapestry-5/pull/38#issuecomment-1713879317
What is the state of this PR? How can i build the jakarta feature variant
with the current build script?
--
This is an automated message from the Apache Git Service.
To respond to the
vjlamp commented on PR #38:
URL: https://github.com/apache/tapestry-5/pull/38#issuecomment-1714097378
> What is the state of this PR? How can i build the jakarta feature variant
with the current build script?
Unfortunately, we are not there yet, i.e. you can't build the jakarta
vjlamp commented on PR #38:
URL: https://github.com/apache/tapestry-5/pull/38#issuecomment-1721581309
@derkoe Yes, that's what I concluded also. It'll probably be the 5.9
release, not a 6.x release anyway, as @thiagohp
derkoe opened a new pull request, #43:
URL: https://github.com/apache/tapestry-5/pull/43
Things changed:
- Set Java source/target version to 11
- Switch to Spring 6 (Jakarta EE, Java 17)
- Switch to Jetty 11 and Tomcat 10.1 (for support of Jakarta EE)
- Get the current version of
derkoe commented on PR #38:
URL: https://github.com/apache/tapestry-5/pull/38#issuecomment-1720725870
@vjlamp I have used a different approach in this PR: #43 (TAP5-2741: switch
to Jakarta EE and Java 11).
I think it will not be possible to support both the old and new namespace
derkoe opened a new pull request, #44:
URL: https://github.com/apache/tapestry-5/pull/44
This builds the whole project fro each pull request on GitHub. This makes it
a lot easier to check the correctness contributions.
--
This is an automated message from the Apache Git Service.
To
HansMontana commented on PR #43:
URL: https://github.com/apache/tapestry-5/pull/43#issuecomment-1782879228
I'm very grateful for your work provided here to ensure compatibility with
future Spring versions @derkoe
As the end of open source support for Spring Boot 2.7.x [seems to be
benweidig commented on PR #43:
URL: https://github.com/apache/tapestry-5/pull/43#issuecomment-1790328481
Hi @HansMontana,
merging the changes themselves isn't the big problem, it's remaining
backward-compatible without doubling the required work on our end.
We're still working
benweidig merged PR #44:
URL: https://github.com/apache/tapestry-5/pull/44
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
derkoe commented on PR #44:
URL: https://github.com/apache/tapestry-5/pull/44#issuecomment-1729140307
I'm not quite sure why GitHub is not executing the action on this PR. Maybe
a member of the tapestry-5 team has to create the PR for the job to run!?
--
This is an automated message from
thiagohp merged PR #11:
URL: https://github.com/apache/tapestry-5/pull/11
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
thiagohp closed pull request #31: Improve GRADLE build Performance
URL: https://github.com/apache/tapestry-5/pull/31
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
thiagohp commented on PR #43:
URL: https://github.com/apache/tapestry-5/pull/43#issuecomment-1741848752
Hello, @derkoe !
Thank you very much for this contribution!
Actually merging it will take some coordination and decisions regarding
Tapestry versions.
Just one
derkoe commented on PR #43:
URL: https://github.com/apache/tapestry-5/pull/43#issuecomment-1742014089
@thiagohp actually it works also with Java 8. I'm not sure if this makes
sense since most platforms switch at least to Java 11 with Jakarta EE (Tomcat
10.1, Jetty 11).
Only the
carlosmonterocanabal commented on PR #43:
URL: https://github.com/apache/tapestry-5/pull/43#issuecomment-1745707832
Amazing PR! Great job @derkoe, I think this is the way (jakarta and Spring 6
/ Spring boot 3) and I will force to java 17+. As Tapestry developers, we need
that the framework
derkoe commented on PR #44:
URL: https://github.com/apache/tapestry-5/pull/44#issuecomment-1728988151
@benweidig added the matrix to the build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
coderkun opened a new pull request, #45:
URL: https://github.com/apache/tapestry-5/pull/45
Tapestry uses [Underscore.js](http://underscorejs.org/) version 1.8.3, which
is more than eight years old (April 2015) and includes some security
vulnerabilities. I would like to upgrade it to the
benweidig commented on PR #45:
URL: https://github.com/apache/tapestry-5/pull/45#issuecomment-1771222694
We ran into the same issue after a recent pen test and updated it
internally; there have been no issues so far.
Initially, I thought about removing underscore.js altogether, as
benweidig commented on PR #44:
URL: https://github.com/apache/tapestry-5/pull/44#issuecomment-1773795679
It seems Apache does not allow all actions.
browser-actions/setup-firefox@v1 and
browser-actions/setup-geckodriver@latest don't match the allowed ones, as seen
in this run on another
benweidig merged PR #45:
URL: https://github.com/apache/tapestry-5/pull/45
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
benweidig commented on PR #44:
URL: https://github.com/apache/tapestry-5/pull/44#issuecomment-1774046989
For reference:
https://issues.apache.org/jira/projects/INFRA/issues/INFRA-25108
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
thiagohp commented on PR #43:
URL: https://github.com/apache/tapestry-5/pull/43#issuecomment-1802367168
> The changes of ASM in tapestry-plastic are needed for Java 17/21 in any
way. Should I separate them into a separate PR?
Hello, @derkoe ! Yes, please separate them into a separate
chrispoulsen commented on PR #43:
URL: https://github.com/apache/tapestry-5/pull/43#issuecomment-1805754313
I missed this talk about ASM and we just hit the issue at work, so I whipped
up a quick fix in https://github.com/apache/tapestry-5/pull/46, maybe there is
something useful in there
derkoe commented on PR #43:
URL: https://github.com/apache/tapestry-5/pull/43#issuecomment-1802169047
Hey @benweidig - I think your concerns around backward-compatibility are
valid but I think it is much easier to maintain two branches than a hacky
solution using the transformer. I think
benweidig merged PR #37:
URL: https://github.com/apache/tapestry-5/pull/37
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
hamerperez commented on PR #38:
URL: https://github.com/apache/tapestry-5/pull/38#issuecomment-1526935236
Ok
El El mié, abr. 26, 2023 a la(s) 12:27 p.m., Volker Lamp <
***@***.***> escribió:
> This is going to be a marathon, not a sprint. This first commit is not yet
vjlamp opened a new pull request, #38:
URL: https://github.com/apache/tapestry-5/pull/38
This is going to be a marathon, not a sprint. This first commit is not yet
concerned with any of the Jakarta EE stuff. Actually, it's only about breaking
up the build logic some more. A more
vjlamp opened a new pull request, #39:
URL: https://github.com/apache/tapestry-5/pull/39
With the recently added FormsRequirePostException it is now time to have a
proper handler for it.
Contributing a specific `ExceptionHandlerAssistant` to
`RequestExceptionHandler` seems to be a
bvfalcon commented on PR #36:
URL: https://github.com/apache/tapestry-5/pull/36#issuecomment-1518982496
> making a small addition to the existing test app 6 would be nicer.
In case of all tests in app6 are independent from each other this is
absolutely true. But tests
vjlamp commented on PR #36:
URL: https://github.com/apache/tapestry-5/pull/36#issuecomment-1519174483
Hello Vladimir, thank you for picking up my suggestions. I realized only
tonight that it's possible for me to commit to PRs. So that's what I did,
simplifying the test a little bit more.
vjlamp merged PR #36:
URL: https://github.com/apache/tapestry-5/pull/36
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
bvfalcon opened a new pull request, #36:
URL: https://github.com/apache/tapestry-5/pull/36
https://issues.apache.org/jira/browse/TAP5-2749 -- fix with controlling
integration test for this bug
--
This is an automated message from the Apache Git Service.
To respond to the message, please
SilverSteven closed pull request #32: Improve GRADLE build Performance
URL: https://github.com/apache/tapestry-5/pull/32
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
thiagohp merged PR #39:
URL: https://github.com/apache/tapestry-5/pull/39
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
thiagohp commented on PR #39:
URL: https://github.com/apache/tapestry-5/pull/39#issuecomment-1633279292
I've made some changes so it doesn't have tapestry-core-only stuff in
tapestry-ioc and also makes it a bit more flexible by checking a newly
introduced annotation instead of an specific
clayburn opened a new pull request, #41:
URL: https://github.com/apache/tapestry-5/pull/41
This PR publishes a build scan for every CI build and for every local build
from an authenticated Apache committer. The build will not fail if publishing
fails.
The build scans of the Apache
benweidig commented on PR #40:
URL: https://github.com/apache/tapestry-5/pull/40#issuecomment-1604492085
The PR was merged manually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
benweidig closed pull request #40: TAP5-2708/2753: CssCompressor updates and
CSS variable fixes
URL: https://github.com/apache/tapestry-5/pull/40
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
vjlamp commented on PR #18:
URL: https://github.com/apache/tapestry-5/pull/18#issuecomment-1612139992
Version 1.3.3 was the latest when this PR was created, however, as of today,
version 1.5 is the current release.
Upgrading to version 1.5 includes fixes for CVE-2023-24998 and
clayburn opened a new pull request, #42:
URL: https://github.com/apache/tapestry-5/pull/42
This PR sets the Gradle build's rootProject name to `tapestry`. If it is
more desirable to set this to `tapestry-5` to match the repo name, let me know
and I can amend the PR.
Setting the
vjlamp commented on PR #42:
URL: https://github.com/apache/tapestry-5/pull/42#issuecomment-1613470319
Thank you, @clayburn, your input is much appreciated. Actually, in the
TAP5-2741 branch, I'm refactoring our Gradle setup altogether, hence I changed
the target branch of your PR. Any
benweidig merged PR #41:
URL: https://github.com/apache/tapestry-5/pull/41
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
benweidig commented on PR #41:
URL: https://github.com/apache/tapestry-5/pull/41#issuecomment-1598293416
Hi @clayburn, thanks for the PR!
The changes are pretty straightforward, except there seems to be no
documentation for `publishIfAuthenticated()`, but it's quite self-explanatory.
benweidig opened a new pull request, #40:
URL: https://github.com/apache/tapestry-5/pull/40
I've updated the CssCompressor with the latest commit
https://github.com/yui/yuicompressor/commit/cf0497e53fffe4ddbd50e71518c40e0c07d120de
and moved all CSS related tests and create a Spec.
hrgdavor commented on PR #46:
URL: https://github.com/apache/tapestry-5/pull/46#issuecomment-1902685198
When will this be released ? I am itching to try some Java 21 things on a
project that uses Tapestry IOC
--
This is an automated message from the Apache Git Service.
To respond to the
derkoe commented on PR #43:
URL: https://github.com/apache/tapestry-5/pull/43#issuecomment-1951857133
Any update on this? I think many Tapestry users have the need to switch to
Jakarta EE. We already run these changes successfully and would be happy to
move off our fork.
--
This is an
benweidig commented on PR #43:
URL: https://github.com/apache/tapestry-5/pull/43#issuecomment-1952377673
Hi @derkoe,
we talked a little bit about the general progress/timeline of the Jakarta
release on the mailing list
https://lists.apache.org/thread/6ydk6ors5r2qp73ks3bwvk3op3k9hkz7
thiagohp commented on PR #46:
URL: https://github.com/apache/tapestry-5/pull/46#issuecomment-1836928307
Thank you so much, @chrispoulsen and @cpoulsen-dezide (both profiles
committed, so I thank both, even if they're the same person! :smile: )
--
This is an automated message from the
thiagohp merged PR #46:
URL: https://github.com/apache/tapestry-5/pull/46
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
thiagohp commented on PR #46:
URL: https://github.com/apache/tapestry-5/pull/46#issuecomment-1913397538
Me again. I've just managed to get the Tapestry project working again in
Eclipse with some half-arcane Gradle stuff. :)
--
This is an automated message from the Apache Git Service.
To
thiagohp closed pull request #14: update comment about ASM and btw 11 March
2018: ASM 6.1 is available
URL: https://github.com/apache/tapestry-5/pull/14
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
thiagohp commented on PR #14:
URL: https://github.com/apache/tapestry-5/pull/14#issuecomment-1913400349
Thanks! But it doesn't apply anymore, specially after TAP5-2769.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
thiagohp closed pull request #26: TAP5-2613: Upgrade tapestry build to Java 11
URL: https://github.com/apache/tapestry-5/pull/26
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
thiagohp commented on PR #26:
URL: https://github.com/apache/tapestry-5/pull/26#issuecomment-1913399500
Thanks! Pull request applied manually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
thiagohp closed pull request #3: Remove unused import
org.hibernate.cfg.AnnotationConfiguration
URL: https://github.com/apache/tapestry-5/pull/3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
thiagohp commented on PR #3:
URL: https://github.com/apache/tapestry-5/pull/3#issuecomment-1913399234
Thanks! Change implemented in TAP5-2556.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
thiagohp commented on PR #46:
URL: https://github.com/apache/tapestry-5/pull/46#issuecomment-1913323569
Hello, @chrispoulsen !
Were you able to open the Tapestry subprojects without compilation errors in
Eclipse with your branch? The Plastic project cannot find any of the
chrispoulsen commented on PR #46:
URL: https://github.com/apache/tapestry-5/pull/46#issuecomment-1914389852
> Hello, @chrispoulsen !
>
> Were you able to open the Tapestry subprojects without compilation errors
in Eclipse with your branch? The Plastic project cannot find any of the
derkoe commented on PR #43:
URL: https://github.com/apache/tapestry-5/pull/43#issuecomment-1809226216
Removed the ASM change from this PR. Now it's only Jakarta EE (incl. Tomcat
and Jetty) + Spring 6
--
This is an automated message from the Apache Git Service.
To respond to the message,
chrispoulsen commented on PR #46:
URL: https://github.com/apache/tapestry-5/pull/46#issuecomment-1809240057
Adjusted to inject a Tapestry specific class into the relocated ASM package
in order to gain access to the package-protected static helper instead of using
reflection.
Note:
coderkun commented on PR #43:
URL: https://github.com/apache/tapestry-5/pull/43#issuecomment-1809678546
@derk, any reason to set the Servlet API to version 5.0 though Tomcat 10.1
uses Servlet API 6.0?
--
This is an automated message from the Apache Git Service.
To respond to the message,
derkoe commented on PR #43:
URL: https://github.com/apache/tapestry-5/pull/43#issuecomment-1810482695
@coderkun I have used the minimum version that uses Jakarta EE - also Jetty
11 is based on Servlet 5.
--
This is an automated message from the Apache Git Service.
To respond to the
derkoe commented on PR #43:
URL: https://github.com/apache/tapestry-5/pull/43#issuecomment-1808644478
@thiagohp I guess the solution proposed by @chrispoulsen is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
vjlamp opened a new pull request, #47:
URL: https://github.com/apache/tapestry-5/pull/47
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
vjlamp merged PR #47:
URL: https://github.com/apache/tapestry-5/pull/47
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
thiagohp merged PR #43:
URL: https://github.com/apache/tapestry-5/pull/43
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
66 matches
Mail list logo
