[GitHub] incubator-tephra pull request #67: TEPHRA-272 Add HBase 2.0 compatibility mo...

2017-12-18 Thread ankitsinghal
GitHub user ankitsinghal opened a pull request: https://github.com/apache/incubator-tephra/pull/67 TEPHRA-272 Add HBase 2.0 compatibility module You can merge this pull request into a Git repository by running: $ git pull https://github.com/ankitsinghal/incubator-tephra

[GitHub] incubator-tephra pull request #67: TEPHRA-272 Add HBase 2.0 compatibility mo...

2018-01-10 Thread ankitsinghal
Github user ankitsinghal commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/67#discussion_r160880292 --- Diff: tephra-hbase-compat-2.0/src/test/java/org/apache/tephra/hbase/coprocessor/TransactionProcessorTest.java --- @@ -0,0 +1,677

[GitHub] incubator-tephra issue #67: TEPHRA-272 Add HBase 2.0 compatibility module

2018-01-10 Thread ankitsinghal
Github user ankitsinghal commented on the issue: https://github.com/apache/incubator-tephra/pull/67 Thanks a lot @poornachandra for the review, I have taken care of all the current review comments in the last commit. Let me know if any changes required with your further review. ---

[GitHub] incubator-tephra pull request #67: TEPHRA-272 Add HBase 2.0 compatibility mo...

2018-02-19 Thread ankitsinghal
Github user ankitsinghal commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/67#discussion_r169027005 --- Diff: tephra-hbase-compat-2.0/src/main/java/org/apache/tephra/hbase/coprocessor/FilteredInternalScanner.java --- @@ -0,0 +1,80

[GitHub] incubator-tephra pull request #67: TEPHRA-272 Add HBase 2.0 compatibility mo...

2018-02-23 Thread ankitsinghal
Github user ankitsinghal commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/67#discussion_r170260742 --- Diff: tephra-hbase-compat-2.0/src/main/java/org/apache/tephra/hbase/coprocessor/FilteredInternalScanner.java --- @@ -0,0 +1,80

[GitHub] incubator-tephra issue #67: TEPHRA-272 Add HBase 2.0 compatibility module

2018-02-23 Thread ankitsinghal
Github user ankitsinghal commented on the issue: https://github.com/apache/incubator-tephra/pull/67 bq. Can you update the pom for the 2.0 compat module to use Java 8? Do we want to make Java8 specific to HBase-2.0 compat module and keep other still running on Java7

[GitHub] incubator-tephra issue #67: TEPHRA-272 Add HBase 2.0 compatibility module

2018-03-08 Thread ankitsinghal
Github user ankitsinghal commented on the issue: https://github.com/apache/incubator-tephra/pull/67 @poornachandra , have squashed all commit in a single one. can you please commit this. ---

[GitHub] incubator-tephra issue #67: TEPHRA-272 Add HBase 2.0 compatibility module

2018-03-05 Thread ankitsinghal
Github user ankitsinghal commented on the issue: https://github.com/apache/incubator-tephra/pull/67 @poornachandra , I have already made the change to compile HBase-2.0 with Java 8. should I rebase and squash the commits for merge now? It seems HBase 1.x releases are still