Github user poornachandra commented on the issue:
https://github.com/apache/incubator-tephra/pull/67
@ankitsinghal I spent some time on the tephra-hbase-compat-1.4 compat
module tests failure. It looks like the 1.4 compat module tests were never run
earlier. When you changed the
Github user ankitsinghal commented on the issue:
https://github.com/apache/incubator-tephra/pull/67
@poornachandra , have squashed all commit in a single one. can you please
commit this.
---
Github user ankitsinghal commented on the issue:
https://github.com/apache/incubator-tephra/pull/67
@poornachandra , I have already made the change to compile HBase-2.0 with
Java 8. should I rebase and squash the commits for merge now?
It seems HBase 1.x releases are still with
Github user poornachandra commented on the issue:
https://github.com/apache/incubator-tephra/pull/67
@joshelser There is nothing stopping us from moving Tephra to Java 8. Just
that we'll have to build consensus on the Tephra dev list, and it will add to
the delay of this PR. If
Github user poornachandra commented on the issue:
https://github.com/apache/incubator-tephra/pull/67
@ankitsinghal Since HBase-2.0 needs Java 8, let's try changing the compiler
for only HBase-2.0 compat module to use Java 8. We can still keep the other
modules as Java 7. I haven't
Github user ankitsinghal commented on the issue:
https://github.com/apache/incubator-tephra/pull/67
bq. Can you update the pom for the 2.0 compat module to use Java 8?
Do we want to make Java8 specific to HBase-2.0 compat module and keep other
still running on Java7. Will it not
Github user poornachandra commented on the issue:
https://github.com/apache/incubator-tephra/pull/67
@ankitsinghal Just one more question
(https://github.com/apache/incubator-tephra/pull/67#discussion_r169503415).
Also the Java 7 build is failing for HBase 2.0 compat module.
Github user ankitsinghal commented on the issue:
https://github.com/apache/incubator-tephra/pull/67
Thanks a lot @poornachandra for the review, I have taken care of all the
current review comments in the last commit. Let me know if any changes required
with your further review.
---
Github user poornachandra commented on the issue:
https://github.com/apache/incubator-tephra/pull/67
@ankitsinghal I'm taking a look at the PR. Meanwhile, the Travis build has
failed. Looks like there is some issue finding HBase 2.0 dependencies. Can you
take a look at it?
