[jira] [Commented] (TEPHRA-265) Tephra Guice License

2018-05-18 Thread James Taylor (JIRA) 

[ 
https://issues.apache.org/jira/browse/TEPHRA-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480987#comment-16480987
 ] 

James Taylor commented on TEPHRA-265:
-

Actually, just noticed the pull request. This is only necessary if you were to 
do a binary release, right?

> Tephra Guice License
> 
>
> Key: TEPHRA-265
> URL: https://issues.apache.org/jira/browse/TEPHRA-265
> Project: Tephra
>  Issue Type: Bug
>Affects Versions: 0.13.0-incubating
>Reporter: Gokul Gunasekaran
>Assignee: Gokul Gunasekaran
>Priority: Major
> Fix For: 0.14.0-incubating
>
> Attachments: TEPHRA-265.patch
>
>
> The NOTICE for Guice in 0.13.0-incubating release contains (which was added 
> as part of the fix for TEPHRA-231): 
> Apache Tephra includes Guice v3.0 and Guice Assisted Inject v3.0. Tephra
> elects to include this software in this distribution under the Apache License.
> You can obtain a copy of the License at:
> http://apache.org/licenses/LICENSE-2.0
> Instead, it should contain the exact content from the NOTICE of the Guice 
> JAR. 
> Google Guice - Core Library
> Copyright 2006-2011 Google, Inc.
> This product includes software developed at
> The Apache Software Foundation (http://www.apache.org/).
> http://mail-archives.apache.org/mod_mbox/incubator-general/201709.mbox/%3CCAOqetn-zPeOanD1fVZHVsjfwqn5qnmN9WXWjb1jDJAE8JgQ_Zg%40mail.gmail.com%3E



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (TEPHRA-265) Tephra Guice License

2018-05-18 Thread James Taylor (JIRA) 

[ 
https://issues.apache.org/jira/browse/TEPHRA-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480980#comment-16480980
 ] 

James Taylor commented on TEPHRA-265:
-

Please review the patch, [~gokulavasan] or [~poornachandra].

> Tephra Guice License
> 
>
> Key: TEPHRA-265
> URL: https://issues.apache.org/jira/browse/TEPHRA-265
> Project: Tephra
>  Issue Type: Bug
>Affects Versions: 0.13.0-incubating
>Reporter: Gokul Gunasekaran
>Assignee: Gokul Gunasekaran
>Priority: Major
> Fix For: 0.14.0-incubating
>
> Attachments: TEPHRA-265.patch
>
>
> The NOTICE for Guice in 0.13.0-incubating release contains (which was added 
> as part of the fix for TEPHRA-231): 
> Apache Tephra includes Guice v3.0 and Guice Assisted Inject v3.0. Tephra
> elects to include this software in this distribution under the Apache License.
> You can obtain a copy of the License at:
> http://apache.org/licenses/LICENSE-2.0
> Instead, it should contain the exact content from the NOTICE of the Guice 
> JAR. 
> Google Guice - Core Library
> Copyright 2006-2011 Google, Inc.
> This product includes software developed at
> The Apache Software Foundation (http://www.apache.org/).
> http://mail-archives.apache.org/mod_mbox/incubator-general/201709.mbox/%3CCAOqetn-zPeOanD1fVZHVsjfwqn5qnmN9WXWjb1jDJAE8JgQ_Zg%40mail.gmail.com%3E



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (TEPHRA-265) Tephra Guice License

2018-03-09 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/TEPHRA-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16393436#comment-16393436
 ] 

ASF GitHub Bot commented on TEPHRA-265:
---

Github user poornachandra commented on the issue:

https://github.com/apache/incubator-tephra/pull/63
  
@johnament We are planning for the next release of Tephra soon. Can you 
take a look at the changes, so that this PR can be part of the next release?


> Tephra Guice License
> 
>
> Key: TEPHRA-265
> URL: https://issues.apache.org/jira/browse/TEPHRA-265
> Project: Tephra
>  Issue Type: Bug
>Affects Versions: 0.13.0-incubating
>Reporter: Gokul Gunasekaran
>Assignee: Gokul Gunasekaran
>Priority: Major
> Fix For: 0.14.0-incubating
>
>
> The NOTICE for Guice in 0.13.0-incubating release contains (which was added 
> as part of the fix for TEPHRA-231): 
> Apache Tephra includes Guice v3.0 and Guice Assisted Inject v3.0. Tephra
> elects to include this software in this distribution under the Apache License.
> You can obtain a copy of the License at:
> http://apache.org/licenses/LICENSE-2.0
> Instead, it should contain the exact content from the NOTICE of the Guice 
> JAR. 
> Google Guice - Core Library
> Copyright 2006-2011 Google, Inc.
> This product includes software developed at
> The Apache Software Foundation (http://www.apache.org/).
> http://mail-archives.apache.org/mod_mbox/incubator-general/201709.mbox/%3CCAOqetn-zPeOanD1fVZHVsjfwqn5qnmN9WXWjb1jDJAE8JgQ_Zg%40mail.gmail.com%3E



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (TEPHRA-265) Tephra Guice License

2017-10-15 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/TEPHRA-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16205455#comment-16205455
 ] 

ASF GitHub Bot commented on TEPHRA-265:
---

Github user gokulavasan commented on the issue:

https://github.com/apache/incubator-tephra/pull/63
  
@johnament Thanks for the review John. Please take another look when you 
get a chance.


> Tephra Guice License
> 
>
> Key: TEPHRA-265
> URL: https://issues.apache.org/jira/browse/TEPHRA-265
> Project: Tephra
>  Issue Type: Bug
>Affects Versions: 0.13.0-incubating
>Reporter: Gokul Gunasekaran
>Assignee: Gokul Gunasekaran
> Fix For: 0.14.0-incubating
>
>
> The NOTICE for Guice in 0.13.0-incubating release contains (which was added 
> as part of the fix for TEPHRA-231): 
> Apache Tephra includes Guice v3.0 and Guice Assisted Inject v3.0. Tephra
> elects to include this software in this distribution under the Apache License.
> You can obtain a copy of the License at:
> http://apache.org/licenses/LICENSE-2.0
> Instead, it should contain the exact content from the NOTICE of the Guice 
> JAR. 
> Google Guice - Core Library
> Copyright 2006-2011 Google, Inc.
> This product includes software developed at
> The Apache Software Foundation (http://www.apache.org/).
> http://mail-archives.apache.org/mod_mbox/incubator-general/201709.mbox/%3CCAOqetn-zPeOanD1fVZHVsjfwqn5qnmN9WXWjb1jDJAE8JgQ_Zg%40mail.gmail.com%3E



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TEPHRA-265) Tephra Guice License

2017-10-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/TEPHRA-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16204272#comment-16204272
 ] 

ASF GitHub Bot commented on TEPHRA-265:
---

Github user johnament commented on a diff in the pull request:

https://github.com/apache/incubator-tephra/pull/63#discussion_r144667984
  
--- Diff: tephra-distribution/NOTICE_BINARY ---
@@ -6,10 +6,19 @@ The Apache Software Foundation (http://www.apache.org/).
 
 Apache Tephra - notice for binary distribution
 ==
-Apache Tephra includes Guice v3.0 and Guice Assisted Inject v3.0. Tephra
-elects to include this software in this distribution under the Apache 
License.
-You can obtain a copy of the License at:
-http://apache.org/licenses/LICENSE-2.0
+Apache Tephra includes Guice v3.0.
+Google Guice - Core Library
+Copyright 2006-2011 Google, Inc.
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
+
+Apache Tephra includes Guice Assisted Inject v3.0.
+Google Guice - Extensions - AssistedInject
+Copyright 2006-2011 Google, Inc.
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
 
 Apache Tephra includes Guava v13.0.1. Tephra elects to include this 
software
--- End diff --

Just because a dependency is apache licensed doesn't mean it will have a 
NOTICE.  NOTICE is optional, so you shouldn't include one if none is present.


> Tephra Guice License
> 
>
> Key: TEPHRA-265
> URL: https://issues.apache.org/jira/browse/TEPHRA-265
> Project: Tephra
>  Issue Type: Bug
>Affects Versions: 0.13.0-incubating
>Reporter: Gokul Gunasekaran
>Assignee: Gokul Gunasekaran
> Fix For: 0.14.0-incubating
>
>
> The NOTICE for Guice in 0.13.0-incubating release contains (which was added 
> as part of the fix for TEPHRA-231): 
> Apache Tephra includes Guice v3.0 and Guice Assisted Inject v3.0. Tephra
> elects to include this software in this distribution under the Apache License.
> You can obtain a copy of the License at:
> http://apache.org/licenses/LICENSE-2.0
> Instead, it should contain the exact content from the NOTICE of the Guice 
> JAR. 
> Google Guice - Core Library
> Copyright 2006-2011 Google, Inc.
> This product includes software developed at
> The Apache Software Foundation (http://www.apache.org/).
> http://mail-archives.apache.org/mod_mbox/incubator-general/201709.mbox/%3CCAOqetn-zPeOanD1fVZHVsjfwqn5qnmN9WXWjb1jDJAE8JgQ_Zg%40mail.gmail.com%3E



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TEPHRA-265) Tephra Guice License

2017-10-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/TEPHRA-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16204244#comment-16204244
 ] 

ASF GitHub Bot commented on TEPHRA-265:
---

Github user poornachandra commented on the issue:

https://github.com/apache/incubator-tephra/pull/63
  
@gokulavasan Do you have time to take this PR to completion?


> Tephra Guice License
> 
>
> Key: TEPHRA-265
> URL: https://issues.apache.org/jira/browse/TEPHRA-265
> Project: Tephra
>  Issue Type: Bug
>Affects Versions: 0.13.0-incubating
>Reporter: Gokul Gunasekaran
>Assignee: Gokul Gunasekaran
> Fix For: 0.14.0-incubating
>
>
> The NOTICE for Guice in 0.13.0-incubating release contains (which was added 
> as part of the fix for TEPHRA-231): 
> Apache Tephra includes Guice v3.0 and Guice Assisted Inject v3.0. Tephra
> elects to include this software in this distribution under the Apache License.
> You can obtain a copy of the License at:
> http://apache.org/licenses/LICENSE-2.0
> Instead, it should contain the exact content from the NOTICE of the Guice 
> JAR. 
> Google Guice - Core Library
> Copyright 2006-2011 Google, Inc.
> This product includes software developed at
> The Apache Software Foundation (http://www.apache.org/).
> http://mail-archives.apache.org/mod_mbox/incubator-general/201709.mbox/%3CCAOqetn-zPeOanD1fVZHVsjfwqn5qnmN9WXWjb1jDJAE8JgQ_Zg%40mail.gmail.com%3E



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TEPHRA-265) Tephra Guice License

2017-09-21 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/TEPHRA-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175357#comment-16175357
 ] 

ASF GitHub Bot commented on TEPHRA-265:
---

Github user gokulavasan commented on a diff in the pull request:

https://github.com/apache/incubator-tephra/pull/63#discussion_r140343798
  
--- Diff: tephra-distribution/NOTICE_BINARY ---
@@ -6,10 +6,19 @@ The Apache Software Foundation (http://www.apache.org/).
 
 Apache Tephra - notice for binary distribution
 ==
-Apache Tephra includes Guice v3.0 and Guice Assisted Inject v3.0. Tephra
-elects to include this software in this distribution under the Apache 
License.
-You can obtain a copy of the License at:
-http://apache.org/licenses/LICENSE-2.0
+Apache Tephra includes Guice v3.0.
+Google Guice - Core Library
+Copyright 2006-2011 Google, Inc.
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
+
+Apache Tephra includes Guice Assisted Inject v3.0.
+Google Guice - Extensions - AssistedInject
+Copyright 2006-2011 Google, Inc.
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
 
 Apache Tephra includes Guava v13.0.1. Tephra elects to include this 
software
--- End diff --

@johnament Should I remove these lines? I couldn't find a NOTICE in Guava, 
Gson, javax.inject JARs.


> Tephra Guice License
> 
>
> Key: TEPHRA-265
> URL: https://issues.apache.org/jira/browse/TEPHRA-265
> Project: Tephra
>  Issue Type: Bug
>Affects Versions: 0.13.0-incubating
>Reporter: Gokul Gunasekaran
>Assignee: Gokul Gunasekaran
> Fix For: 0.14.0-incubating
>
>
> The NOTICE for Guice in 0.13.0-incubating release contains (which was added 
> as part of the fix for TEPHRA-231): 
> Apache Tephra includes Guice v3.0 and Guice Assisted Inject v3.0. Tephra
> elects to include this software in this distribution under the Apache License.
> You can obtain a copy of the License at:
> http://apache.org/licenses/LICENSE-2.0
> Instead, it should contain the exact content from the NOTICE of the Guice 
> JAR. 
> Google Guice - Core Library
> Copyright 2006-2011 Google, Inc.
> This product includes software developed at
> The Apache Software Foundation (http://www.apache.org/).
> http://mail-archives.apache.org/mod_mbox/incubator-general/201709.mbox/%3CCAOqetn-zPeOanD1fVZHVsjfwqn5qnmN9WXWjb1jDJAE8JgQ_Zg%40mail.gmail.com%3E



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TEPHRA-265) Tephra Guice License

2017-09-21 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/TEPHRA-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175331#comment-16175331
 ] 

ASF GitHub Bot commented on TEPHRA-265:
---

Github user johnament commented on a diff in the pull request:

https://github.com/apache/incubator-tephra/pull/63#discussion_r140340041
  
--- Diff: tephra-distribution/NOTICE_BINARY ---
@@ -6,10 +6,19 @@ The Apache Software Foundation (http://www.apache.org/).
 
 Apache Tephra - notice for binary distribution
 ==
-Apache Tephra includes Guice v3.0 and Guice Assisted Inject v3.0. Tephra
-elects to include this software in this distribution under the Apache 
License.
-You can obtain a copy of the License at:
-http://apache.org/licenses/LICENSE-2.0
+Apache Tephra includes Guice v3.0.
+Google Guice - Core Library
+Copyright 2006-2011 Google, Inc.
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
+
+Apache Tephra includes Guice Assisted Inject v3.0.
+Google Guice - Extensions - AssistedInject
+Copyright 2006-2011 Google, Inc.
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
 
 Apache Tephra includes Guava v13.0.1. Tephra elects to include this 
software
--- End diff --

most of these lines are still not relevant.


> Tephra Guice License
> 
>
> Key: TEPHRA-265
> URL: https://issues.apache.org/jira/browse/TEPHRA-265
> Project: Tephra
>  Issue Type: Bug
>Affects Versions: 0.13.0-incubating
>Reporter: Gokul Gunasekaran
>Assignee: Gokul Gunasekaran
> Fix For: 0.14.0-incubating
>
>
> The NOTICE for Guice in 0.13.0-incubating release contains (which was added 
> as part of the fix for TEPHRA-231): 
> Apache Tephra includes Guice v3.0 and Guice Assisted Inject v3.0. Tephra
> elects to include this software in this distribution under the Apache License.
> You can obtain a copy of the License at:
> http://apache.org/licenses/LICENSE-2.0
> Instead, it should contain the exact content from the NOTICE of the Guice 
> JAR. 
> Google Guice - Core Library
> Copyright 2006-2011 Google, Inc.
> This product includes software developed at
> The Apache Software Foundation (http://www.apache.org/).
> http://mail-archives.apache.org/mod_mbox/incubator-general/201709.mbox/%3CCAOqetn-zPeOanD1fVZHVsjfwqn5qnmN9WXWjb1jDJAE8JgQ_Zg%40mail.gmail.com%3E



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TEPHRA-265) Tephra Guice License

2017-09-21 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/TEPHRA-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175238#comment-16175238
 ] 

ASF GitHub Bot commented on TEPHRA-265:
---

GitHub user gokulavasan opened a pull request:

https://github.com/apache/incubator-tephra/pull/63

TEPHRA-265 Fix NOTICE_BINARY for Guice and Guice Assisted Inject libraries

JIRA : https://issues.apache.org/jira/browse/TEPHRA-265

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gokulavasan/incubator-tephra 
feature/tephra-notice-fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-tephra/pull/63.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #63


commit 1d34e0b4ec8c1c2492fc94821106660a9fb33cbd
Author: Gokul Gunasekaran 
Date:   2017-09-20T18:10:56Z

TEPHRA-265 Fix NOTICE_BINARY for Guice and Guice Assisted Inject libraries




> Tephra Guice License
> 
>
> Key: TEPHRA-265
> URL: https://issues.apache.org/jira/browse/TEPHRA-265
> Project: Tephra
>  Issue Type: Bug
>Affects Versions: 0.13.0-incubating
>Reporter: Gokul Gunasekaran
>Assignee: Gokul Gunasekaran
> Fix For: 0.14.0-incubating
>
>
> The NOTICE for Guice in 0.13.0-incubating release contains (which was added 
> as part of the fix for TEPHRA-231): 
> Apache Tephra includes Guice v3.0 and Guice Assisted Inject v3.0. Tephra
> elects to include this software in this distribution under the Apache License.
> You can obtain a copy of the License at:
> http://apache.org/licenses/LICENSE-2.0
> Instead, it should contain the exact content from the NOTICE of the Guice 
> JAR. 
> Google Guice - Core Library
> Copyright 2006-2011 Google, Inc.
> This product includes software developed at
> The Apache Software Foundation (http://www.apache.org/).
> http://mail-archives.apache.org/mod_mbox/incubator-general/201709.mbox/%3CCAOqetn-zPeOanD1fVZHVsjfwqn5qnmN9WXWjb1jDJAE8JgQ_Zg%40mail.gmail.com%3E



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)