[
https://issues.apache.org/jira/browse/THRIFT-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13527400#comment-13527400
]
Henrique Mendonca commented on THRIFT-1782:
---
Hi Carl,
Thanks for the patch,
[
https://issues.apache.org/jira/browse/THRIFT-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13527439#comment-13527439
]
Carl Yeksigian commented on THRIFT-1782:
Thanks for the feedback.
The async
[
https://issues.apache.org/jira/browse/THRIFT-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13527524#comment-13527524
]
Jens Geyer commented on THRIFT-1782:
Hi Carl,
Agree, async is more than welcome in
[
https://issues.apache.org/jira/browse/THRIFT-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13527527#comment-13527527
]
Henrique Mendonca commented on THRIFT-1782:
---
but yeah, async await is awesome!
[
https://issues.apache.org/jira/browse/THRIFT-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carl Yeksigian updated THRIFT-1782:
---
Attachment: 1782-v2.patch
async only defined in silverlight
[
https://issues.apache.org/jira/browse/THRIFT-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13527543#comment-13527543
]
Carl Yeksigian commented on THRIFT-1782:
I've attached v2 which does not break
[
https://issues.apache.org/jira/browse/THRIFT-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13527546#comment-13527546
]
Jens Geyer commented on THRIFT-1780:
Nice!
But ... using your patch I get without
[
https://issues.apache.org/jira/browse/THRIFT-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13527546#comment-13527546
]
Jens Geyer edited comment on THRIFT-1780 at 12/9/12 5:56 PM:
-
[
https://issues.apache.org/jira/browse/THRIFT-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13527546#comment-13527546
]
Jens Geyer edited comment on THRIFT-1780 at 12/9/12 5:55 PM:
-
[
https://issues.apache.org/jira/browse/THRIFT-1630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kamil Salas updated THRIFT-1630:
Attachment: 0001-THRIFT-1630-Add-sorted_containers-switch-to-java-gen.patch
I've created patch
[
https://issues.apache.org/jira/browse/THRIFT-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13527558#comment-13527558
]
Jens Geyer commented on THRIFT-1782:
+1 from me.
Would be perfect if the CTP is
[
https://issues.apache.org/jira/browse/THRIFT-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13527560#comment-13527560
]
Carl Yeksigian commented on THRIFT-1780:
Yes, I agree.
One problem with this
[
https://issues.apache.org/jira/browse/THRIFT-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carl Yeksigian updated THRIFT-1782:
---
Attachment: 1782-v3.patch
Removed CTP from help screen.
async only
[
https://issues.apache.org/jira/browse/THRIFT-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13527563#comment-13527563
]
Jens Geyer commented on THRIFT-1742:
Can't say much about the hash itslf, but this
[
https://issues.apache.org/jira/browse/THRIFT-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13527563#comment-13527563
]
Jens Geyer edited comment on THRIFT-1742 at 12/9/12 6:29 PM:
-
[
https://issues.apache.org/jira/browse/THRIFT-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13527563#comment-13527563
]
Jens Geyer edited comment on THRIFT-1742 at 12/9/12 6:31 PM:
-
[
https://issues.apache.org/jira/browse/THRIFT-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13527563#comment-13527563
]
Jens Geyer edited comment on THRIFT-1742 at 12/9/12 6:33 PM:
-
[
https://issues.apache.org/jira/browse/THRIFT-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13527576#comment-13527576
]
Jens Geyer commented on THRIFT-1780:
{quote}
One problem with this approach (either
[
https://issues.apache.org/jira/browse/THRIFT-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carl Yeksigian updated THRIFT-1780:
---
Attachment: 1780-v2.patch
Updated version of the patch; removes need for __isset in cases
[
https://issues.apache.org/jira/browse/THRIFT-1781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carl Yeksigian closed THRIFT-1781.
--
Resolution: Invalid
Problem wasn't comments not being copied -- it was lack of comments.
[
https://issues.apache.org/jira/browse/THRIFT-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13527636#comment-13527636
]
Jens Geyer commented on THRIFT-1782:
+1
async only defined in
[
https://issues.apache.org/jira/browse/THRIFT-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13527637#comment-13527637
]
Jens Geyer commented on THRIFT-1780:
The C# code used to use _isset fields even for
Jens Geyer created THRIFT-1783:
--
Summary: C# doesn't handle required fields correctly
Key: THRIFT-1783
URL: https://issues.apache.org/jira/browse/THRIFT-1783
Project: Thrift
Issue Type: Bug
[
https://issues.apache.org/jira/browse/THRIFT-1783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer updated THRIFT-1783:
---
Description:
The following IDL
{code}
struct MyStruct {
1 : required i32 ID,
2 : optional
[
https://issues.apache.org/jira/browse/THRIFT-1783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer updated THRIFT-1783:
---
Description:
The following IDL
{code}
struct MyStruct {
1 : required i32 ID,
2 : optional
[
https://issues.apache.org/jira/browse/THRIFT-1783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer updated THRIFT-1783:
---
Description:
The following IDL
{code}
struct MyStruct {
1 : required i32 ID,
2 : optional
[
https://issues.apache.org/jira/browse/THRIFT-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13527637#comment-13527637
]
Jens Geyer edited comment on THRIFT-1780 at 12/9/12 9:59 PM:
-
[
https://issues.apache.org/jira/browse/THRIFT-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13527643#comment-13527643
]
Jens Geyer commented on THRIFT-1780:
The non-nullable case is broken by the patch,
28 matches
Mail list logo
