[GitHub] thrift pull request: [THRIFT-3086] fix a few minor valgrind identi...

Github user jeking3 closed the pull request at: https://github.com/apache/thrift/pull/429 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (THRIFT-2441) Cannot shutdown TThreadedServer when clients are still connected

[ https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487648#comment-14487648 ] Ben Craig commented on THRIFT-2441: --- oh, sorry about that. I wasn't sure if this had

[jira] [Commented] (THRIFT-3081) C++ Consolidate client processing loops in TServers

[ https://issues.apache.org/jira/browse/THRIFT-3081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14488316#comment-14488316 ] ASF GitHub Bot commented on THRIFT-3081: Github user jeking3 commented on the

[jira] [Commented] (THRIFT-3013) make thrift compiler accept a list of input files

[ https://issues.apache.org/jira/browse/THRIFT-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487595#comment-14487595 ] James E. King, III commented on THRIFT-3013: I see no reason to shy away from

[jira] [Commented] (THRIFT-3077) C++ TFileTransport ignores return code from ftruncate

[ https://issues.apache.org/jira/browse/THRIFT-3077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487612#comment-14487612 ] ASF GitHub Bot commented on THRIFT-3077: Github user jeking3 closed the pull

[jira] [Commented] (THRIFT-3077) C++ TFileTransport ignores return code from ftruncate

[ https://issues.apache.org/jira/browse/THRIFT-3077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487611#comment-14487611 ] ASF GitHub Bot commented on THRIFT-3077: Github user jeking3 commented on the

[jira] [Commented] (THRIFT-2157) generated code would cause ClassCastException

[ https://issues.apache.org/jira/browse/THRIFT-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487529#comment-14487529 ] Iker Jimenez commented on THRIFT-2157: -- Hey, got a chance to work on this yet?

[jira] [Issue Comment Deleted] (THRIFT-2157) generated code would cause ClassCastException

[ https://issues.apache.org/jira/browse/THRIFT-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Iker Jimenez updated THRIFT-2157: - Comment: was deleted (was: Hey, got a chance to work on this yet?) generated code would cause

[jira] [Commented] (THRIFT-2157) generated code would cause ClassCastException

[ https://issues.apache.org/jira/browse/THRIFT-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487530#comment-14487530 ] Iker Jimenez commented on THRIFT-2157: -- Hey, got a chance to work on this yet?

[GitHub] thrift pull request: THRIFT-3081 consolidate client processing loo...

GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/433 THRIFT-3081 consolidate client processing loops This pull request consolidates the client processing loops contained within TSimpleServer, TThreadedServer, TThreadPoolServer that were all similar

[GitHub] thrift pull request: [THRIFT-3077] TFileTransport fix ignored ftru...

Github user jeking3 closed the pull request at: https://github.com/apache/thrift/pull/426 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: THRIFT-3081 consolidate client processing loo...

Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/428#issuecomment-91361228 Build failed though no fault of my own, so closing this and opening a new one. --- If your project is set up for it, you can reply to this email and have your reply

[jira] [Commented] (THRIFT-2441) Cannot shutdown TThreadedServer when clients are still connected

[ https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487599#comment-14487599 ] James E. King, III commented on THRIFT-2441: What's the next step I need to

[jira] [Commented] (THRIFT-3081) C++ Consolidate client processing loops in TServers

[ https://issues.apache.org/jira/browse/THRIFT-3081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487602#comment-14487602 ] James E. King, III commented on THRIFT-3081: [~ben.craig] recommended this

[jira] [Commented] (THRIFT-3081) C++ Consolidate client processing loops in TServers

[ https://issues.apache.org/jira/browse/THRIFT-3081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14488321#comment-14488321 ] ASF GitHub Bot commented on THRIFT-3081: GitHub user jeking3 opened a pull

[GitHub] thrift pull request: THRIFT-3081 consolidate client processing loo...

Github user jeking3 closed the pull request at: https://github.com/apache/thrift/pull/428 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (THRIFT-2441) Cannot shutdown TThreadedServer when clients are still connected

[ https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487663#comment-14487663 ] James E. King, III commented on THRIFT-2441: Note that although peek had to

[GitHub] thrift pull request: [THRIFT-3077] TFileTransport fix ignored ftru...

Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/426#issuecomment-91281448 Closing as the code has been merged into the project. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[jira] [Commented] (THRIFT-3088) TThreadPoolServer with Sasl auth may leak CLOSE_WAIT socket

[ https://issues.apache.org/jira/browse/THRIFT-3088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14486930#comment-14486930 ] ASF GitHub Bot commented on THRIFT-3088: GitHub user punwinger opened a pull

[jira] [Commented] (THRIFT-3081) C++ Consolidate client processing loops in TServers

[ https://issues.apache.org/jira/browse/THRIFT-3081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487629#comment-14487629 ] ASF GitHub Bot commented on THRIFT-3081: Github user jeking3 commented on the

[jira] [Issue Comment Deleted] (THRIFT-3086) C++ Valgrind Error Cleanup

[ https://issues.apache.org/jira/browse/THRIFT-3086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-3086: --- Comment: was deleted (was: Should I close the PR on this now?) C++ Valgrind Error

[jira] [Commented] (THRIFT-3086) C++ Valgrind Error Cleanup

[ https://issues.apache.org/jira/browse/THRIFT-3086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487617#comment-14487617 ] ASF GitHub Bot commented on THRIFT-3086: Github user jeking3 commented on the

[jira] [Commented] (THRIFT-3086) C++ Valgrind Error Cleanup

[ https://issues.apache.org/jira/browse/THRIFT-3086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487618#comment-14487618 ] ASF GitHub Bot commented on THRIFT-3086: Github user jeking3 closed the pull

[jira] [Commented] (THRIFT-3081) C++ Consolidate client processing loops in TServers

[ https://issues.apache.org/jira/browse/THRIFT-3081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14488317#comment-14488317 ] ASF GitHub Bot commented on THRIFT-3081: Github user jeking3 closed the pull

[jira] [Commented] (THRIFT-3086) C++ Valgrind Error Cleanup

[ https://issues.apache.org/jira/browse/THRIFT-3086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487610#comment-14487610 ] James E. King, III commented on THRIFT-3086: Should I close the PR on this

[GitHub] thrift pull request: [THRIFT-3088] TThreadPoolServer with Sasl aut...

GitHub user punwinger opened a pull request: https://github.com/apache/thrift/pull/432 [THRIFT-3088] TThreadPoolServer with Sasl auth may leak CLOSE_WAIT socket Start TThreadPoolServer to server with TSaslServerTransport.Factory as transportFactory. While using nc to test the

[jira] [Created] (THRIFT-3088) TThreadPoolServer with Sasl auth may leak CLOSE_WAIT socket

punwinger created THRIFT-3088: - Summary: TThreadPoolServer with Sasl auth may leak CLOSE_WAIT socket Key: THRIFT-3088 URL: https://issues.apache.org/jira/browse/THRIFT-3088 Project: Thrift

[GitHub] thrift pull request: [THRIFT-3086] fix a few minor valgrind identi...

Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/429#issuecomment-91282080 The code has been merged so I am closing the pull request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] thrift pull request: THRIFT-3081 consolidate client processing loo...

Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/428#issuecomment-91284246 There was no conflict with master however I need to base THRIFT-3083 on top of these changes so I needed to refresh it. --- If your project is set up for it, you can

[jira] [Commented] (THRIFT-2157) generated code would cause ClassCastException

[ https://issues.apache.org/jira/browse/THRIFT-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487592#comment-14487592 ] deepankar commented on THRIFT-2157: --- Sorry, I worked on it a little, let me see if I