[jira] [Commented] (THRIFT-3786) Node.js TLS emits 'connect' before connection is ready

[ https://issues.apache.org/jira/browse/THRIFT-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15236440#comment-15236440 ] Hudson commented on THRIFT-3786: FAILURE: Integrated in Thrift-precommit #404 (See

Build failed in Jenkins: Thrift-precommit #404

See Changes: [james.reggio] THRIFT-3786 Fix premature firing of `connect` event for secure sockets -- [...truncated 6681 lines...] dmd -O -release -ofunittest/release/thrift/protocol/compact

[jira] [Commented] (THRIFT-3768) TThreadedServer may crash if it is destroyed immediately after it returns from serve(); TThreadedServer disconnects clients when they connec

[ https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15236356#comment-15236356 ] ASF GitHub Bot commented on THRIFT-3768: Github user jeking3 commented on a diff in the pull

[GitHub] thrift pull request: THRIFT-3768: ensure TThreadedServer guarantee...

Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/980#discussion_r59306037 --- Diff: lib/cpp/src/thrift/server/TThreadedServer.h --- @@ -83,12 +88,56 @@ class TThreadedServer : public TServerFramework { virtual void serve();

[jira] [Commented] (THRIFT-3768) TThreadedServer may crash if it is destroyed immediately after it returns from serve(); TThreadedServer disconnects clients when they connec

[ https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15236354#comment-15236354 ] ASF GitHub Bot commented on THRIFT-3768: Github user jeking3 commented on a diff in the pull

[GitHub] thrift pull request: THRIFT-3768: ensure TThreadedServer guarantee...

Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/980#discussion_r59306085 --- Diff: lib/cpp/src/thrift/server/TThreadedServer.cpp --- @@ -90,31 +95,71 @@ TThreadedServer::~TThreadedServer() { } void

[jira] [Commented] (THRIFT-3768) TThreadedServer may crash if it is destroyed immediately after it returns from serve(); TThreadedServer disconnects clients when they connec

[ https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15236340#comment-15236340 ] ASF GitHub Bot commented on THRIFT-3768: Github user tpcwang commented on a diff in the pull

[GitHub] thrift pull request: THRIFT-3768: ensure TThreadedServer guarantee...

Github user tpcwang commented on a diff in the pull request: https://github.com/apache/thrift/pull/980#discussion_r59305327 --- Diff: lib/cpp/src/thrift/server/TThreadedServer.cpp --- @@ -90,31 +95,71 @@ TThreadedServer::~TThreadedServer() { } void

[jira] [Commented] (THRIFT-3768) TThreadedServer may crash if it is destroyed immediately after it returns from serve(); TThreadedServer disconnects clients when they connec

[ https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15236329#comment-15236329 ] ASF GitHub Bot commented on THRIFT-3768: Github user tpcwang commented on a diff in the pull

[GitHub] thrift pull request: THRIFT-3768: ensure TThreadedServer guarantee...

Github user tpcwang commented on a diff in the pull request: https://github.com/apache/thrift/pull/980#discussion_r59304879 --- Diff: lib/cpp/src/thrift/server/TThreadedServer.h --- @@ -83,12 +88,56 @@ class TThreadedServer : public TServerFramework { virtual void serve();

[GitHub] thrift pull request: THRIFT-3768: ensure TThreadedServer guarantee...

Github user tpcwang commented on a diff in the pull request: https://github.com/apache/thrift/pull/980#discussion_r59304884 --- Diff: lib/cpp/src/thrift/server/TThreadedServer.cpp --- @@ -90,31 +95,71 @@ TThreadedServer::~TThreadedServer() { } void

[jira] [Commented] (THRIFT-3768) TThreadedServer may crash if it is destroyed immediately after it returns from serve(); TThreadedServer disconnects clients when they connec

[ https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15236327#comment-15236327 ] ASF GitHub Bot commented on THRIFT-3768: Github user tpcwang commented on a diff in the pull

[jira] [Commented] (THRIFT-3786) Node.js TLS emits 'connect' before connection is ready

[ https://issues.apache.org/jira/browse/THRIFT-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15236064#comment-15236064 ] James Reggio commented on THRIFT-3786: -- Thanks for the quick merge, [~codesf]. > Node.js TLS emits

[jira] [Resolved] (THRIFT-3156) Node TLS: server executes processing logic two full times

[ https://issues.apache.org/jira/browse/THRIFT-3156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randy Abernethy resolved THRIFT-3156. - Resolution: Fixed Fix Version/s: 0.10.0 Thanks for the report, spot on. Fixed by

[jira] [Resolved] (THRIFT-3786) Node.js TLS emits 'connect' before connection is ready

[ https://issues.apache.org/jira/browse/THRIFT-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randy Abernethy resolved THRIFT-3786. - Resolution: Fixed Fix Version/s: 0.10.0 great patch, thanks! committed with minor

[jira] [Commented] (THRIFT-3786) Node.js TLS emits 'connect' before connection is ready

[ https://issues.apache.org/jira/browse/THRIFT-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15236027#comment-15236027 ] ASF GitHub Bot commented on THRIFT-3786: Github user asfgit closed the pull request at:

[GitHub] thrift pull request: THRIFT-3786 Fix premature firing of `connect`...

Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/985 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Assigned] (THRIFT-3786) Node.js TLS emits 'connect' before connection is ready

[ https://issues.apache.org/jira/browse/THRIFT-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randy Abernethy reassigned THRIFT-3786: --- Assignee: Randy Abernethy > Node.js TLS emits 'connect' before connection is ready

[jira] [Commented] (THRIFT-3768) TThreadedServer may crash if it is destroyed immediately after it returns from serve(); TThreadedServer disconnects clients when they connec

[ https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235785#comment-15235785 ] ASF GitHub Bot commented on THRIFT-3768: Github user jeking3 commented on the pull request:

[GitHub] thrift pull request: THRIFT-3768: ensure TThreadedServer guarantee...

Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/980#issuecomment-208513794 I'm starting to believe that the TThreadServerPool implementation may have the same issue. The cores I have been able to produce through repeated testing are showing a

[GitHub] thrift pull request: THRIFT-3786 Fix premature firing of `connect`...

GitHub user jamesreggio opened a pull request: https://github.com/apache/thrift/pull/985 THRIFT-3786 Fix premature firing of `connect` event for secure sockets `tls.connect()` returns a socket that will fire a `connect` event when the initial socket is connected, followed by a

[jira] [Commented] (THRIFT-3786) Node.js TLS emits 'connect' before connection is ready

[ https://issues.apache.org/jira/browse/THRIFT-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235614#comment-15235614 ] ASF GitHub Bot commented on THRIFT-3786: GitHub user jamesreggio opened a pull request:

[jira] [Commented] (THRIFT-3786) Node.js TLS emits 'connect' before connection is ready

[ https://issues.apache.org/jira/browse/THRIFT-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235590#comment-15235590 ] James Reggio commented on THRIFT-3786: -- These two issues share an root cause; specifically, code is

[jira] [Created] (THRIFT-3786) Node.js TLS emits 'connect' before connection is ready

James Reggio created THRIFT-3786: Summary: Node.js TLS emits 'connect' before connection is ready Key: THRIFT-3786 URL: https://issues.apache.org/jira/browse/THRIFT-3786 Project: Thrift

[GitHub] thrift pull request: THRIFT-3746 JSON protocol left in incorrect s...

Github user tylertreat-wf commented on the pull request: https://github.com/apache/thrift/pull/955#issuecomment-208372015 @nsuke Interesting, I'm not entirely sure why this would be happening. I would expect the `writer` reset to be a safe operation to perform on `WriteMessageBegin`.

[jira] [Commented] (THRIFT-3746) JSON protocol left in incorrect state on read errors

[ https://issues.apache.org/jira/browse/THRIFT-3746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235159#comment-15235159 ] ASF GitHub Bot commented on THRIFT-3746: Github user tylertreat-wf commented on the pull request:

[jira] [Updated] (THRIFT-3769) Fix logic of THRIFT-2268

[ https://issues.apache.org/jira/browse/THRIFT-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Harsh J updated THRIFT-3769: Patch Info: Patch Available > Fix logic of THRIFT-2268 > > > Key:

[jira] [Updated] (THRIFT-3769) Fix logic of THRIFT-2268

[ https://issues.apache.org/jira/browse/THRIFT-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Harsh J updated THRIFT-3769: Flags: Patch > Fix logic of THRIFT-2268 > > > Key: THRIFT-3769 >