[jira] [Commented] (THRIFT-3932) C++ ThreadManager has a rare termination race

[ https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15542525#comment-15542525 ] ASF GitHub Bot commented on THRIFT-3932: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1103: THRIFT-3932: fixed ThreadManager concurrency issues, add...

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1103 I re-enabled these tests and they have all passed in Travis and in Appveyor. I also brought the time on TInterruptTest down by 90 seconds. The entire suite runs in about 60 seconds on Windows

[jira] [Commented] (THRIFT-3925) Client service recieves string instead of buffer when using TCompactProtocol with node.js library.

[ https://issues.apache.org/jira/browse/THRIFT-3925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15542288#comment-15542288 ] Roman Poliakov commented on THRIFT-3925: Yes, indeed it is fixed in master branch. I cannot find

[jira] [Commented] (THRIFT-3932) C++ ThreadManager has a rare termination race

[ https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15542125#comment-15542125 ] ASF GitHub Bot commented on THRIFT-3932: Github user jeking3 commented on a diff in the pull

[GitHub] thrift pull request #1103: THRIFT-3932: fixed ThreadManager concurrency issu...

Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1103#discussion_r81527972 --- Diff: lib/cpp/src/thrift/concurrency/ThreadManager.cpp --- @@ -339,103 +357,88 @@ void ThreadManager::Impl::addWorker(size_t value) {

[jira] [Commented] (THRIFT-3932) C++ ThreadManager has a rare termination race

[ https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15542093#comment-15542093 ] ASF GitHub Bot commented on THRIFT-3932: Github user jeking3 commented on a diff in the pull

[GitHub] thrift pull request #1103: THRIFT-3932: fixed ThreadManager concurrency issu...

Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1103#discussion_r81525843 --- Diff: lib/cpp/src/thrift/concurrency/ThreadManager.cpp --- @@ -339,103 +357,88 @@ void ThreadManager::Impl::addWorker(size_t value) {

[jira] [Commented] (THRIFT-3932) C++ ThreadManager has a rare termination race

[ https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15542090#comment-15542090 ] ASF GitHub Bot commented on THRIFT-3932: Github user jeking3 commented on a diff in the pull

[GitHub] thrift pull request #1103: THRIFT-3932: fixed ThreadManager concurrency issu...

Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1103#discussion_r81525567 --- Diff: lib/cpp/src/thrift/concurrency/ThreadManager.cpp --- @@ -339,103 +357,88 @@ void ThreadManager::Impl::addWorker(size_t value) {

[jira] [Commented] (THRIFT-3932) C++ ThreadManager has a rare termination race

[ https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15542065#comment-15542065 ] ASF GitHub Bot commented on THRIFT-3932: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1103: THRIFT-3932: fixed ThreadManager concurrency issues, add...

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1103 I made this single change: > +++ b/lib/cpp/test/processor/ProcessorTest.cpp > uint32_t checkNewConnEvents(const boost::shared_ptr& log) { >// Check for an ET_CONN_CREATED event