[
https://issues.apache.org/jira/browse/THRIFT-4261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16102695#comment-16102695
]
Can Celasun commented on THRIFT-4261:
-
{quote}1. support backward compatibility for old function
[
https://issues.apache.org/jira/browse/THRIFT-4261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16102306#comment-16102306
]
Yicheng Qin commented on THRIFT-4261:
-
The change would further break projects depending on thrift at
[
https://issues.apache.org/jira/browse/THRIFT-4261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16102295#comment-16102295
]
Can Celasun commented on THRIFT-4261:
-
Thanks, now I get what you mean. But that's not really
[
https://issues.apache.org/jira/browse/THRIFT-4261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16102270#comment-16102270
]
Yicheng Qin commented on THRIFT-4261:
-
> I'm afraid I don't understand. The repo, at any given
David Hull created THRIFT-4266:
--
Summary: Erlang library throws during skipping fields of composite
type (maps, lists, structs, sets)
Key: THRIFT-4266
URL: https://issues.apache.org/jira/browse/THRIFT-4266
[
https://issues.apache.org/jira/browse/THRIFT-4261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16102230#comment-16102230
]
Jens Geyer commented on THRIFT-4261:
{quote}
If you are suggesting that master [...] should never
[
https://issues.apache.org/jira/browse/THRIFT-4265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Hull closed THRIFT-4265.
--
Resolution: Invalid
> Erlang library missing a struct_end call in decoder
>
[
https://issues.apache.org/jira/browse/THRIFT-4261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer closed THRIFT-4261.
--
Resolution: Not A Problem
Assignee: Jens Geyer (was: taozle)
Fix Version/s: 0.11.0
>
[
https://issues.apache.org/jira/browse/THRIFT-4265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16102231#comment-16102231
]
David Hull commented on THRIFT-4265:
I am closing this bug report. This was indeed an issue in Thrift
David Hull created THRIFT-4265:
--
Summary: Erlang library missing a struct_end call in decoder
Key: THRIFT-4265
URL: https://issues.apache.org/jira/browse/THRIFT-4265
Project: Thrift
Issue Type:
[
https://issues.apache.org/jira/browse/THRIFT-4262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer resolved THRIFT-4262.
Resolution: Fixed
Fix Version/s: 0.11.0
Committed.
> Invalid binding to
[
https://issues.apache.org/jira/browse/THRIFT-4261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16102213#comment-16102213
]
Can Celasun commented on THRIFT-4261:
-
bq. My concern is for much longer term, when part of repo uses
[
https://issues.apache.org/jira/browse/THRIFT-4264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16102155#comment-16102155
]
ASF GitHub Bot commented on THRIFT-4264:
Github user norrs commented on the issue:
Github user norrs commented on the issue:
https://github.com/apache/thrift/pull/1315
https://issues.apache.org/jira/browse/THRIFT-4264
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
[
https://issues.apache.org/jira/browse/THRIFT-4261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16102143#comment-16102143
]
Yicheng Qin commented on THRIFT-4261:
-
> No, they don't. There are about a dozen different dependency
[
https://issues.apache.org/jira/browse/THRIFT-4264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16102140#comment-16102140
]
ASF GitHub Bot commented on THRIFT-4264:
GitHub user norrs opened a pull request:
GitHub user norrs opened a pull request:
https://github.com/apache/thrift/pull/1315
THRIFT-4264: Fix PHP tests requiring sockets.so
The PHP library requires sockets.so for the socket_import_stream() function.
Make it available for the tests by symlinking in the module.
Github user norrs commented on the issue:
https://github.com/apache/thrift/pull/1314
Side story:
Ok, I was hoping travis would run the cross compile tests with php7, but
sadly it doesn't. As I was hoping the build would fail with the test case
before submitting, as this is
[
https://issues.apache.org/jira/browse/THRIFT-4263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16102123#comment-16102123
]
ASF GitHub Bot commented on THRIFT-4263:
Github user norrs commented on the issue:
[
https://issues.apache.org/jira/browse/THRIFT-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16102063#comment-16102063
]
ASF GitHub Bot commented on THRIFT-4248:
Github user sokac commented on the issue:
Github user sokac commented on the issue:
https://github.com/apache/thrift/pull/1307
Correct, is not the same as . However, (C++)
is very similar to (C), with only difference that cstring is part of
std and usually preferred for C++
[
https://issues.apache.org/jira/browse/THRIFT-4263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16101879#comment-16101879
]
ASF GitHub Bot commented on THRIFT-4263:
GitHub user norrs opened a pull request:
GitHub user norrs opened a pull request:
https://github.com/apache/thrift/pull/1314
THRIFT-4263: Fix use after free bug for thrown exceptions
Exceptions thrown through PHPExceptionWrapper are prematurely freed at the
end
of the catch block, even though
Roy Sindre Norangshol created THRIFT-4263:
-
Summary: Fix use after free bug for thrown exceptions
Key: THRIFT-4263
URL: https://issues.apache.org/jira/browse/THRIFT-4263
Project: Thrift
[
https://issues.apache.org/jira/browse/THRIFT-4262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer updated THRIFT-4262:
---
Attachment: 0001-THRIFT-4262-Invalid-binding-to-InterlockedCompareExc.patch
> Invalid binding to
Jens Geyer created THRIFT-4262:
--
Summary: Invalid binding to InterlockedCompareExchange64() with
64-bit targets
Key: THRIFT-4262
URL: https://issues.apache.org/jira/browse/THRIFT-4262
Project: Thrift
[
https://issues.apache.org/jira/browse/THRIFT-4261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16101634#comment-16101634
]
Jens Geyer edited comment on THRIFT-4261 at 7/26/17 12:57 PM:
--
Can, thanks
[
https://issues.apache.org/jira/browse/THRIFT-4261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16101634#comment-16101634
]
Jens Geyer commented on THRIFT-4261:
Thanks for your comments & valuable input. Actually, the last
[
https://issues.apache.org/jira/browse/THRIFT-4261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16101334#comment-16101334
]
Can Celasun edited comment on THRIFT-4261 at 7/26/17 12:42 PM:
---
bq. Go
[
https://issues.apache.org/jira/browse/THRIFT-4261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Can Celasun updated THRIFT-4261:
Component/s: Go - Library
Go - Compiler
> Go context generation issue: breaking
[
https://issues.apache.org/jira/browse/THRIFT-4261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16101334#comment-16101334
]
Can Celasun commented on THRIFT-4261:
-
> Go projects always use `glide` as version management, which
[
https://issues.apache.org/jira/browse/THRIFT-4261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer reassigned THRIFT-4261:
--
Assignee: taozle
> Go context generation issue: breaking change in generated code regarding
[
https://issues.apache.org/jira/browse/THRIFT-4261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16101296#comment-16101296
]
Jens Geyer commented on THRIFT-4261:
{quote}One option IMO is to support backward compatibility for
33 matches
Mail list logo
