[GitHub] thrift pull request #1320: THRIFT-4270: Generate Erlang mapping functions fo...

2017-07-28 Thread dhull
GitHub user dhull opened a pull request: https://github.com/apache/thrift/pull/1320 THRIFT-4270: Generate Erlang mapping functions for const maps and lists The Erlang generator now creates a new constants module containing two functions for each const map and list. The

[jira] [Created] (THRIFT-4270) Generate Erlang mapping functions for const maps and lists

2017-07-28 Thread David Hull (JIRA)
David Hull created THRIFT-4270: -- Summary: Generate Erlang mapping functions for const maps and lists Key: THRIFT-4270 URL: https://issues.apache.org/jira/browse/THRIFT-4270 Project: Thrift

[GitHub] thrift issue #1311: Fix for constant assignments to optional fields in Go.

2017-07-28 Thread davinchia
Github user davinchia commented on the issue: https://github.com/apache/thrift/pull/1311 @Jens-G Github must have hidden my comments. My latest commit combined the functions and removed the toString function as per your suggestions. Not sure why one of the integration tests

[jira] [Commented] (THRIFT-4269) Don't append '.' to Erlang namespace if it ends in '_'.

2017-07-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16105435#comment-16105435 ] ASF GitHub Bot commented on THRIFT-4269: GitHub user dhull opened a pull request:

[GitHub] thrift pull request #1319: THRIFT-4269: Don't append '.' to Erlang namespace...

2017-07-28 Thread dhull
GitHub user dhull opened a pull request: https://github.com/apache/thrift/pull/1319 THRIFT-4269: Don't append '.' to Erlang namespace if it ends in '_'. THRIFT-3834 added support for namespaces to the Erlang code generator. However, that support uses a `.` between the namespace

[jira] [Updated] (THRIFT-4269) Don't append '.' to Erlang namespace if it ends in '_'.

2017-07-28 Thread David Hull (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Hull updated THRIFT-4269: --- Description: THRIFT-3834 added support for namespaces to the Erlang code generator. However, that

[jira] [Created] (THRIFT-4269) Don't append '.' to Erlang namespace if it ends in '_'.

2017-07-28 Thread David Hull (JIRA)
David Hull created THRIFT-4269: -- Summary: Don't append '.' to Erlang namespace if it ends in '_'. Key: THRIFT-4269 URL: https://issues.apache.org/jira/browse/THRIFT-4269 Project: Thrift Issue

[jira] [Commented] (THRIFT-3593) Enable server-side to issue requests to clients on the same connection (push notifications)

2017-07-28 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16105052#comment-16105052 ] James E. King, III commented on THRIFT-3593: At some point this year I would like to