Re: Compiler plug-ins

I don't currently use it, but I wasn't aware of it until recently. The issue that we run into at my company is that the exception types generated by Thrift aren't the types that we want to use in our code. As a result, after code generation, we end up writing lots of boilerplate to convert from

[jira] [Resolved] (THRIFT-4377) haxe. socket handles leak in TSimpleServer

[ https://issues.apache.org/jira/browse/THRIFT-4377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-4377. Resolution: Fixed Fix Version/s: 0.11.0 Committed, thanks for catching this! > haxe.

Re: Compiler plug-ins

I am a fan of tenacious elimination of complexity. Thrift should be fast and easy. A low level platform upon which you can build your own higher level abstractions. -1 compiler plug ins -1 recursive data structs etc... --Randy On Sun, Oct 29, 2017 at 9:50 AM, Jens Geyer

Re: Compiler plug-ins

Not so long ago some people absolutely want it to have ... Thank god we're not in the same position as protobuf (it can't do anything out of the box, you always need plugins) where it is a highly needed feature. I'd still like to hear the opinion of the people who wanted it, but I personally

[jira] [Commented] (THRIFT-4377) haxe. socket handles leak in TSimpleServer

[ https://issues.apache.org/jira/browse/THRIFT-4377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224058#comment-16224058 ] ASF GitHub Bot commented on THRIFT-4377: GitHub user oprudkyi opened a pull request:

[GitHub] thrift pull request #1407: THRIFT-4377: close socket after processing reques...

GitHub user oprudkyi opened a pull request: https://github.com/apache/thrift/pull/1407 THRIFT-4377: close socket after processing request You can merge this pull request into a Git repository by running: $ git pull https://github.com/oprudkyi/thrift THRIFT-4377 Alternatively

[jira] [Created] (THRIFT-4377) haxe. socket handles leak in TSimpleServer

Oleksii Prudkyi created THRIFT-4377: --- Summary: haxe. socket handles leak in TSimpleServer Key: THRIFT-4377 URL: https://issues.apache.org/jira/browse/THRIFT-4377 Project: Thrift Issue

Re: Compiler plug-ins

We don't. (As in, the company I work for). AFAIK, Twitter doesn't as well, but I'd love for someone there to confirm. From: James E. King, III Sent: Sunday, October 29, 2017 10:38:37 AM To: dev@thrift.apache.org Subject: Compiler plug-ins I'm

[jira] [Commented] (THRIFT-3973) Remove MSVC C++ projects to improve maintainability; document building Thrift on Windows using CMake to generate project files

[ https://issues.apache.org/jira/browse/THRIFT-3973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224015#comment-16224015 ] James E. King, III commented on THRIFT-3973: Also fixing up the cmake build environment for

Compiler plug-ins

I'm curious if anyone uses the thrift compiler plug-in feature? It adds a complexity to the build system and the compiler, and if it does not provide value, it should be considered for removal. I'd like to know what the use cases are for having a binary plug-in system when the source code is

[jira] [Commented] (THRIFT-4343) Change CI builds to use node.js 8.x LTS once available

[ https://issues.apache.org/jira/browse/THRIFT-4343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224009#comment-16224009 ] ASF GitHub Bot commented on THRIFT-4343: Github user asfgit closed the pull request at:

[jira] [Resolved] (THRIFT-4343) Change CI builds to use node.js 8.x LTS once available

[ https://issues.apache.org/jira/browse/THRIFT-4343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4343. Resolution: Fixed Fix Version/s: 0.11.0 ubuntu-xenial tests node 4.x and

[GitHub] thrift pull request #1406: THRIFT-4343: enable nodejs-8.x on ubuntu-artful i...

Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1406 ---

[GitHub] thrift issue #1289: fix TypeError when a py3 str is passed to the function.

Github user nsuke commented on the issue: https://github.com/apache/thrift/pull/1289 Basically yes with some note. It's typically not a UTF-8 encoded binary. To write utf8 strings we can use `writeString`. The point is that `writeBinary` is for writing binaries. The

[jira] [Issue Comment Deleted] (THRIFT-4163) The debian package / autoconf build environment is not setting NDEBUG on production builds, leaving assertions active

[ https://issues.apache.org/jira/browse/THRIFT-4163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4163: --- Comment: was deleted (was: I tried doing that but it got a bit messy. I'm thinking

[jira] [Issue Comment Deleted] (THRIFT-4163) The debian package / autoconf build environment is not setting NDEBUG on production builds, leaving assertions active

[ https://issues.apache.org/jira/browse/THRIFT-4163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4163: --- Comment: was deleted (was: To fix this I am pulling in an autoconf module to

[jira] [Commented] (THRIFT-4376) Coverity high impact issue resolution

[ https://issues.apache.org/jira/browse/THRIFT-4376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223954#comment-16223954 ] ASF GitHub Bot commented on THRIFT-4376: Github user asfgit closed the pull request at:

[GitHub] thrift pull request #1405: THRIFT-4376: fix more high impact coverity defect...

Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1405 ---

[jira] [Resolved] (THRIFT-4376) Coverity high impact issue resolution

[ https://issues.apache.org/jira/browse/THRIFT-4376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4376. Resolution: Fixed Fix Version/s: 0.11.0 Resolved all high and some other

[jira] [Commented] (THRIFT-4343) Change CI builds to use node.js 8.x LTS once available

[ https://issues.apache.org/jira/browse/THRIFT-4343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223948#comment-16223948 ] ASF GitHub Bot commented on THRIFT-4343: GitHub user jeking3 opened a pull request:

[GitHub] thrift pull request #1406: THRIFT-4343: enable nodejs-8.x on ubuntu-artful i...

GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/1406 THRIFT-4343: enable nodejs-8.x on ubuntu-artful image and update grunt-jsdoc also fix a perl failure as we were using a deprecated language feature in the cross test server for perl.

[jira] [Commented] (THRIFT-3737) Improve TSocket isOpen() implementation to give more accurate connection status.

[ https://issues.apache.org/jira/browse/THRIFT-3737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223893#comment-16223893 ] ASF GitHub Bot commented on THRIFT-3737: Github user cherrot closed the pull request at:

[jira] [Commented] (THRIFT-3737) Improve TSocket isOpen() implementation to give more accurate connection status.

[ https://issues.apache.org/jira/browse/THRIFT-3737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223892#comment-16223892 ] ASF GitHub Bot commented on THRIFT-3737: Github user cherrot commented on the issue:

[GitHub] thrift pull request #945: THRIFT-3737 Improve isOpen() to give accurate tcp ...

Github user cherrot closed the pull request at: https://github.com/apache/thrift/pull/945 ---

[GitHub] thrift issue #945: THRIFT-3737 Improve isOpen() to give accurate tcp connect...

Github user cherrot commented on the issue: https://github.com/apache/thrift/pull/945 OK I agree to close this PR. ---