[
https://issues.apache.org/jira/browse/THRIFT-4480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346303#comment-16346303
]
ASF GitHub Bot commented on THRIFT-4480:
GitHub user bforbis opened a pull request:
GitHub user bforbis opened a pull request:
https://github.com/apache/thrift/pull/1487
THRIFT-4480 - Handle seqid = 0
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bforbis/thrift THRIFT-4480
Alternatively you can review and
[
https://issues.apache.org/jira/browse/THRIFT-4484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346264#comment-16346264
]
ASF GitHub Bot commented on THRIFT-4484:
Github user ringerc commented on the issue:
[
https://issues.apache.org/jira/browse/THRIFT-4484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Craig Ringer updated THRIFT-4484:
-
Description:
Support was added for self-referential objects in in
Github user ringerc commented on the issue:
https://github.com/apache/thrift/pull/84
Created as https://issues.apache.org/jira/browse/THRIFT-4484
---
Craig Ringer created THRIFT-4484:
Summary: C++ codegen invalid for optional self-membership
Key: THRIFT-4484
URL: https://issues.apache.org/jira/browse/THRIFT-4484
Project: Thrift
Issue
Github user ringerc commented on the issue:
https://github.com/apache/thrift/pull/84
I see a bunch of mutual recursive structure support in the tests, but
nothing for an optional single self-referential member, like
```
struct RecSelf {
1: i16 item
2:
Dan Burkert created THRIFT-4483:
---
Summary: Java TSaslTransport does not respect SASL RAW_SEND_SIZE
Key: THRIFT-4483
URL: https://issues.apache.org/jira/browse/THRIFT-4483
Project: Thrift
Issue
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1380
I can't (well, won't) merge a PR with 100 commits. I also fixed dmd
invocation on linux earlier today and fixed the link ordering issue. So if you
can rebase and squash to one commit, that would
Michel Max created THRIFT-4482:
--
Summary: error making c++ library on windows 8.1 using cygwin
Key: THRIFT-4482
URL: https://issues.apache.org/jira/browse/THRIFT-4482
Project: Thrift
Issue
Anton Shchyrov created THRIFT-4481:
--
Summary: TBinaryProtocol.writeMessageEnd isn't trowable exception
Key: THRIFT-4481
URL: https://issues.apache.org/jira/browse/THRIFT-4481
Project: Thrift
[
https://issues.apache.org/jira/browse/THRIFT-4337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345284#comment-16345284
]
ASF GitHub Bot commented on THRIFT-4337:
GitHub user dmvolod opened a pull request:
GitHub user dmvolod opened a pull request:
https://github.com/apache/thrift/pull/1486
THRIFT-4337: Able to set keyStore and trustStore as InputStream in the
TSSLTransportFactory.TSSLTransportParameters
Plus some tests cleanup
You can merge this pull request into a Git repository
[
https://issues.apache.org/jira/browse/THRIFT-4480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brian Forbis updated THRIFT-4480:
-
Priority: Minor (was: Trivial)
> NodeJS warning on binary_protocol writeMessageEnd when seqid =
Brian Forbis created THRIFT-4480:
Summary: NodeJS warning on binary_protocol writeMessageEnd when
seqid = 0
Key: THRIFT-4480
URL: https://issues.apache.org/jira/browse/THRIFT-4480
Project: Thrift
[
https://issues.apache.org/jira/browse/THRIFT-4474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345134#comment-16345134
]
ASF GitHub Bot commented on THRIFT-4474:
Github user jeking3 commented on the issue:
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1479
If we are making breaking changes, they need to be documented very clearly
in the php/README.md file as part of any commit. See my breaking changes for
0.10.0 and 0.11.0 in the perl/README.md for
[
https://issues.apache.org/jira/browse/THRIFT-4474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345043#comment-16345043
]
ASF GitHub Bot commented on THRIFT-4474:
Github user RobberPhex commented on the issue:
Github user RobberPhex commented on the issue:
https://github.com/apache/thrift/pull/1479
Personally, I think we can mark classmap/old-style PHP compiler deprecated.
And can be removed in future.
And, ThriftClassLoader can also be removed in future, to migrate composer
[
https://issues.apache.org/jira/browse/THRIFT-4474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345039#comment-16345039
]
ASF GitHub Bot commented on THRIFT-4474:
Github user RobberPhex commented on the issue:
Github user RobberPhex commented on the issue:
https://github.com/apache/thrift/pull/1479
There are some break changes:
1. for generated code, old struct is `Types.php` for all args, results,
`.php` for `ServiceIf`, `ServiceClient`, etc.
new struct is `.php` for ``.
Github user RobberPhex commented on the issue:
https://github.com/apache/thrift/pull/1484
CI isn't stable.
It's so headache. :(
---
[
https://issues.apache.org/jira/browse/THRIFT-4308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III resolved THRIFT-4308.
Resolution: Fixed
Fix Version/s: 0.12.0
> D language docker images need
[
https://issues.apache.org/jira/browse/THRIFT-4308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345005#comment-16345005
]
ASF GitHub Bot commented on THRIFT-4308:
Github user asfgit closed the pull request at:
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1483
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1483
The concurrency test failed, which is a known intermittent issue.
---
[
https://issues.apache.org/jira/browse/THRIFT-4308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344992#comment-16344992
]
ASF GitHub Bot commented on THRIFT-4308:
Github user jeking3 commented on the issue:
[
https://issues.apache.org/jira/browse/THRIFT-4477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-4477:
---
Priority: Minor (was: Major)
> TBufferedTransport must have underlying transport
>
[
https://issues.apache.org/jira/browse/THRIFT-4477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344990#comment-16344990
]
ASF GitHub Bot commented on THRIFT-4477:
Github user asfgit closed the pull request at:
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1484
---
[
https://issues.apache.org/jira/browse/THRIFT-4477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III resolved THRIFT-4477.
Resolution: Fixed
Fix Version/s: 0.12.0
Committed - thanks.
>
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1484
The build failures are unrelated. mingw on Windows has been failing;
go-dart is a new possibly intermittant cross test failure.
---
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1484#discussion_r164729770
--- Diff: lib/php/lib/Transport/TBufferedTransport.php ---
@@ -22,6 +22,7 @@
namespace Thrift\Transport;
+use
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1484#discussion_r164729591
--- Diff: lib/php/lib/Factory/TStringFuncFactory.php ---
@@ -21,8 +21,9 @@
namespace Thrift\Factory;
-use Thrift\StringFunc\Mbstring;
[
https://issues.apache.org/jira/browse/THRIFT-4429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344718#comment-16344718
]
ASF GitHub Bot commented on THRIFT-4429:
GitHub user dmvolod opened a pull request:
GitHub user dmvolod opened a pull request:
https://github.com/apache/thrift/pull/1485
THRIFT-4429: Make TThreadPoolServer.executorService_ available in inherited
classes and refactor methods to be able customization
Plus some classes cleanup from unused imports
You can merge this
36 matches
Mail list logo
