[jira] [Commented] (THRIFT-4476) Typecasting problem on list items

2018-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372820#comment-16372820 ] ASF GitHub Bot commented on THRIFT-4476: Github user ozymaxx commented on the issue:

[GitHub] thrift issue #1496: THRIFT-4476: Typecasting problem on list items (+ low pr...

2018-02-22 Thread ozymaxx
Github user ozymaxx commented on the issue: https://github.com/apache/thrift/pull/1496 It appears that there is another compilation problem in Erlang. In the file `test/DoubleConstantsTest.thrift`, the double literal `100.1` is compiled to `1e+06`. However, Erlang does not accept

[jira] [Commented] (THRIFT-4498) add phpcs back

2018-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372622#comment-16372622 ] ASF GitHub Bot commented on THRIFT-4498: GitHub user RobberPhex opened a pull request:

[GitHub] thrift pull request #1498: THRIFT-4498: add phpcs back

2018-02-22 Thread RobberPhex
GitHub user RobberPhex opened a pull request: https://github.com/apache/thrift/pull/1498 THRIFT-4498: add phpcs back ref You can merge this pull request into a Git repository by running: $ git pull

[jira] [Created] (THRIFT-4498) add phpcs back

2018-02-22 Thread Robert Lu (JIRA)
Robert Lu created THRIFT-4498: - Summary: add phpcs back Key: THRIFT-4498 URL: https://issues.apache.org/jira/browse/THRIFT-4498 Project: Thrift Issue Type: Improvement Components: PHP