fishy opened a new pull request, #2724:
URL: https://github.com/apache/thrift/pull/2724
Client: go
The go library itself does not have any third-party dependencies. We have
one third party dependency from the test code, which kind of polluted from
top-level go.mod file to the users
Oh I think I figured it out.
In lib/go/Makefile.am, we only add `test` to SUBDIR if WITH_TEST is
defined. In github actions we likely didn't define that so that's not
included.
On Wed, Oct 12, 2022 at 4:19 PM Yuxuan Wang wrote:
> I have to admit I'm not too familiar with gnu make and how is it
[
https://issues.apache.org/jira/browse/THRIFT-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christopher Friedt updated THRIFT-5666:
---
Component/s: (was: C glib - Library)
> use poll.h instead of sys/poll.h
>
[
https://issues.apache.org/jira/browse/THRIFT-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christopher Friedt updated THRIFT-5666:
---
Description:
The sys/poll.h header is not actually specified by POSIX and is
cfriedt opened a new pull request, #2723:
URL: https://github.com/apache/thrift/pull/2723
In the interest of portability, use `poll.h` instead of `sys/poll.h` since
`poll.h` is part of POSIX whereas `sys/poll.h` is not.
- [x] Did you create an [Apache
Christopher Friedt created THRIFT-5666:
--
Summary: use poll.h instead of sys/poll.h
Key: THRIFT-5666
URL: https://issues.apache.org/jira/browse/THRIFT-5666
Project: Thrift
Issue Type:
>Either way the Rust server/client implementations should have some max
memory bound. I should have included that.
Time to implement TConfiguration in Rust :) (
https://github.com/apache/thrift/blob/master/doc/specs/thrift-tconfiguration.md
)
On Fri, Oct 28, 2022 at 6:44 AM Allen George wrote:
Hmm. My naive guess is that either the Rust server is interpreting the
list/string length incorrectly and just allocating memory for an absurd number
of elements. We’d have to see if the client is generating properly encoded data
or if the Rust server has incorrect decoding.
Either way the
[
https://issues.apache.org/jira/browse/THRIFT-5664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17625714#comment-17625714
]
Erik commented on THRIFT-5664:
--
full files are attached
> fairly simple .thrift service call in rust ,
[
https://issues.apache.org/jira/browse/THRIFT-5664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erik updated THRIFT-5664:
-
Description:
A fairly small simple .thrift file of mine... when used with RUST on the server
side.. seems to
[
https://issues.apache.org/jira/browse/THRIFT-5663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer updated THRIFT-5663:
---
Summary: usleep was not declared in this scope (was: lib: cpp: usleep was
not declared in this
[
https://issues.apache.org/jira/browse/THRIFT-5665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christopher Friedt closed THRIFT-5665.
--
Resolution: Fixed
It looks like it's not an include order issue after all
>
Christopher Friedt created THRIFT-5665:
--
Summary: include-order issue in TSocket.cpp
Key: THRIFT-5665
URL: https://issues.apache.org/jira/browse/THRIFT-5665
Project: Thrift
Issue Type:
[
https://issues.apache.org/jira/browse/THRIFT-5664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erik updated THRIFT-5664:
-
Attachment: test.rs
> fairly simple .thrift service call in rust , attempts to allocate too much
> memory and
[
https://issues.apache.org/jira/browse/THRIFT-5664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erik updated THRIFT-5664:
-
Attachment: Cargo.toml
> fairly simple .thrift service call in rust , attempts to allocate too much
> memory
[
https://issues.apache.org/jira/browse/THRIFT-5664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erik updated THRIFT-5664:
-
Attachment: main.rs
> fairly simple .thrift service call in rust , attempts to allocate too much
> memory and
[
https://issues.apache.org/jira/browse/THRIFT-5664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erik updated THRIFT-5664:
-
Attachment: test.thrift
> fairly simple .thrift service call in rust , attempts to allocate too much
> memory
Erik created THRIFT-5664:
Summary: fairly simple .thrift service call in rust , attempts to
allocate too much memory and crashes
Key: THRIFT-5664
URL: https://issues.apache.org/jira/browse/THRIFT-5664
18 matches
Mail list logo