[jira] [Comment Edited] (THRIFT-4484) C++ codegen invalid for optional self-membership

2018-08-22 Thread Craig Ringer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589667#comment-16589667 ] Craig Ringer edited comment on THRIFT-4484 at 8/23/18 4:01 AM: --- I think

[jira] [Commented] (THRIFT-4484) C++ codegen invalid for optional self-membership

2018-08-22 Thread Craig Ringer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589667#comment-16589667 ] Craig Ringer commented on THRIFT-4484: -- I think it's related to #1528 too > C++ codegen invalid

[jira] [Comment Edited] (THRIFT-4484) C++ codegen invalid for optional self-membership

2018-02-01 Thread Craig Ringer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349662#comment-16349662 ] Craig Ringer edited comment on THRIFT-4484 at 2/2/18 2:09 AM: -- If I attempt

[jira] [Comment Edited] (THRIFT-4484) C++ codegen invalid for optional self-membership

2018-02-01 Thread Craig Ringer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349631#comment-16349631 ] Craig Ringer edited comment on THRIFT-4484 at 2/2/18 2:05 AM: -- Also, the

[jira] [Commented] (THRIFT-4484) C++ codegen invalid for optional self-membership

2018-02-01 Thread Craig Ringer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349662#comment-16349662 ] Craig Ringer commented on THRIFT-4484: -- If I attempt to actually use {{cpp.ref}} in my code as used

[jira] [Commented] (THRIFT-2471) Make cpp.ref annotation language agnostic

2018-02-01 Thread Craig Ringer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349640#comment-16349640 ] Craig Ringer commented on THRIFT-2471: -- I think a mistake may have been made in this commit, because

[jira] [Comment Edited] (THRIFT-4484) C++ codegen invalid for optional self-membership

2018-02-01 Thread Craig Ringer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349631#comment-16349631 ] Craig Ringer edited comment on THRIFT-4484 at 2/2/18 1:43 AM: -- Also, the

[jira] [Commented] (THRIFT-4484) C++ codegen invalid for optional self-membership

2018-02-01 Thread Craig Ringer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349631#comment-16349631 ] Craig Ringer commented on THRIFT-4484: -- Also, the regression tests show that both {{cpp.ref}} and

[jira] [Comment Edited] (THRIFT-4484) C++ codegen invalid for optional self-membership

2018-02-01 Thread Craig Ringer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349623#comment-16349623 ] Craig Ringer edited comment on THRIFT-4484 at 2/2/18 1:18 AM: --

[jira] [Commented] (THRIFT-4484) C++ codegen invalid for optional self-membership

2018-02-01 Thread Craig Ringer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349623#comment-16349623 ] Craig Ringer commented on THRIFT-4484: -- [~davejwatson] Hrm, too soon. {{&}} generates bogus code

[jira] [Commented] (THRIFT-4484) C++ codegen invalid for optional self-membership

2018-02-01 Thread Craig Ringer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16348660#comment-16348660 ] Craig Ringer commented on THRIFT-4484: -- [~davejwatson] Brilliant! Apparently it's now spelled "&",

[jira] [Comment Edited] (THRIFT-4484) C++ codegen invalid for optional self-membership

2018-01-31 Thread Craig Ringer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346460#comment-16346460 ] Craig Ringer edited comment on THRIFT-4484 at 1/31/18 11:25 AM: 3On 31

[jira] [Comment Edited] (THRIFT-4484) C++ codegen invalid for optional self-membership

2018-01-31 Thread Craig Ringer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346460#comment-16346460 ] Craig Ringer edited comment on THRIFT-4484 at 1/31/18 11:24 AM: On 31

[jira] [Commented] (THRIFT-4484) C++ codegen invalid for optional self-membership

2018-01-31 Thread Craig Ringer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346460#comment-16346460 ] Craig Ringer commented on THRIFT-4484: -- On 31 Jan. 2018 16:11, "Jens Geyer (JIRA)"

[jira] [Updated] (THRIFT-4484) C++ codegen invalid for optional self-membership

2018-01-30 Thread Craig Ringer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Craig Ringer updated THRIFT-4484: - Description: Support was added for self-referential objects in in

[jira] [Created] (THRIFT-4484) C++ codegen invalid for optional self-membership

2018-01-30 Thread Craig Ringer (JIRA)
Craig Ringer created THRIFT-4484: Summary: C++ codegen invalid for optional self-membership Key: THRIFT-4484 URL: https://issues.apache.org/jira/browse/THRIFT-4484 Project: Thrift Issue