[jira] [Commented] (THRIFT-4138) Fix remaining undefined behavior invalid vptr casts in C++ library

2019-01-30 Thread Jim Apple (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16756793#comment-16756793 ] Jim Apple commented on THRIFT-4138: --- It seems like I should also check {{str.fail()}}, but I wonder if

[jira] [Commented] (THRIFT-4138) Fix remaining undefined behavior invalid vptr casts in C++ library

2019-01-30 Thread Jim Apple (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16756765#comment-16756765 ] Jim Apple commented on THRIFT-4138: --- OK, if I'm re-reading this correctly, the very problem is that, 

[jira] [Commented] (THRIFT-4138) Fix remaining undefined behavior invalid vptr casts in C++ library

2019-01-30 Thread Jim Apple (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16756759#comment-16756759 ] Jim Apple commented on THRIFT-4138: --- What is the type of {{t}} in that gdb snippet? I want to repro

[jira] [Resolved] (THRIFT-4134) Fix remaining undefined behavior invalid vptr casts

2017-04-01 Thread Jim Apple (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Apple resolved THRIFT-4134. --- Resolution: Fixed See subtasks for commits that fixed this > Fix remaining undefined behavior

[jira] [Commented] (THRIFT-4134) Fix remaining undefined behavior invalid vptr casts

2017-03-26 Thread Jim Apple (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942397#comment-15942397 ] Jim Apple commented on THRIFT-4134: --- Correction: there is one use in

[jira] [Commented] (THRIFT-4134) Fix remaining undefined behavior invalid vptr casts

2017-03-26 Thread Jim Apple (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942387#comment-15942387 ] Jim Apple commented on THRIFT-4134: --- Here are a few options to fix the boost error: 1. Write a

[jira] [Updated] (THRIFT-4134) Fix remaining undefined behavior invalid vptr casts

2017-03-26 Thread Jim Apple (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Apple updated THRIFT-4134: -- Attachment: thrift-vptr-travis.txt I have attached {{thrift-vptr-travis.log}}, which is the raw log

[jira] [Commented] (THRIFT-4133) Flaky Dart build

2017-03-26 Thread Jim Apple (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942276#comment-15942276 ] Jim Apple commented on THRIFT-4133: --- TravisCI seems to fail during this step more often than it does

[jira] [Commented] (THRIFT-4134) Fix remaining undefined behavior invalid vptr casts

2017-03-25 Thread Jim Apple (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15941959#comment-15941959 ] Jim Apple commented on THRIFT-4134: --- [~jensg], that Haxe patch looks good to me. Did you try and run it

[jira] [Created] (THRIFT-4134) Fix remaining undefined behavior invalid vptr casts

2017-03-25 Thread Jim Apple (JIRA)
Jim Apple created THRIFT-4134: - Summary: Fix remaining undefined behavior invalid vptr casts Key: THRIFT-4134 URL: https://issues.apache.org/jira/browse/THRIFT-4134 Project: Thrift Issue Type:

[jira] [Created] (THRIFT-4133) Flaky Dart build

2017-03-25 Thread Jim Apple (JIRA)
Jim Apple created THRIFT-4133: - Summary: Flaky Dart build Key: THRIFT-4133 URL: https://issues.apache.org/jira/browse/THRIFT-4133 Project: Thrift Issue Type: Bug Components: Dart -

[jira] [Commented] (THRIFT-4026) TSSLSocket doesn't work with Python < 2.7.9

2017-03-18 Thread Jim Apple (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15931533#comment-15931533 ] Jim Apple commented on THRIFT-4026: --- [~nsuke] Yes. > TSSLSocket doesn't work with Python < 2.7.9 >

[jira] [Commented] (THRIFT-4026) TSSLSocket doesn't work with Python < 2.7.9

2017-03-18 Thread Jim Apple (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15931525#comment-15931525 ] Jim Apple commented on THRIFT-4026: --- [~nsuke], I am running {{make check}}. I already have both

[jira] [Commented] (THRIFT-4026) TSSLSocket doesn't work with Python < 2.7.9

2017-03-18 Thread Jim Apple (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15931383#comment-15931383 ] Jim Apple commented on THRIFT-4026: --- [~jensg], would you also be willing to Reopen this one? >

[jira] [Commented] (THRIFT-4026) TSSLSocket doesn't work with Python < 2.7.9

2017-03-18 Thread Jim Apple (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15931355#comment-15931355 ] Jim Apple commented on THRIFT-4026: --- I'm still getting the error [~tsuna] mentioned above, ending in

[jira] [Commented] (THRIFT-2026) Fix TCompactProtocol 64 bit builds

2017-03-18 Thread Jim Apple (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15931090#comment-15931090 ] Jim Apple commented on THRIFT-2026: --- There is still undefined behavior in TCompactProtocol. For