[GitHub] thrift pull request: THRIFT-3485 don't publish extra files to npm

2015-12-13 Thread azylman
Github user azylman closed the pull request at: https://github.com/apache/thrift/pull/741 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] thrift pull request: THRIFT-3485 don't publish extra files to npm

2015-12-13 Thread azylman
Github user azylman commented on the pull request: https://github.com/apache/thrift/pull/741#issuecomment-164290342 @nsuke Is that commit published at all? I'm still seeing this behavior in the latest version published to npm (0.9.3) --- If your project is set up for it, you can

[GitHub] thrift pull request: THRIFT-3485 don't publish extra files to npm

2015-12-13 Thread azylman
Github user azylman commented on the pull request: https://github.com/apache/thrift/pull/741#issuecomment-164294334 @nsuke Looks like that's not published in 0.9.3. I just confirmed that master does _not_ have this problem, making this PR unnecessary. Hopefully that change can get

[GitHub] thrift pull request: THRIFT-3485 don't publish extra files to npm

2015-12-10 Thread azylman
GitHub user azylman opened a pull request: https://github.com/apache/thrift/pull/741 THRIFT-3485 don't publish extra files to npm The thrift npm package is as big as all of our other node dependencies combined. It currently publishes the entire thrift repository, which is ~30mb