[GitHub] thrift pull request #1487: THRIFT-4480 - Handle seqid = 0

2018-01-30 Thread bforbis
GitHub user bforbis opened a pull request: https://github.com/apache/thrift/pull/1487 THRIFT-4480 - Handle seqid = 0 You can merge this pull request into a Git repository by running: $ git pull https://github.com/bforbis/thrift THRIFT-4480 Alternatively you can review

[GitHub] thrift issue #1261: THRIFT-4382: Replace the use of Indirect Object Syntax c...

2017-12-08 Thread bforbis
Github user bforbis commented on the issue: https://github.com/apache/thrift/pull/1261 It would probably be a good idea to also update the code at `tutorial/perl/*` so that the main perl tutorial uses this preferred syntax. ---

[GitHub] thrift pull request #1388: THRIFT-4355 Fix javascript indentation of default...

2017-10-07 Thread bforbis
GitHub user bforbis opened a pull request: https://github.com/apache/thrift/pull/1388 THRIFT-4355 Fix javascript indentation of default values Using the following test thrift file to test indentation in generated ttypes output. ```struct Object { 1: map<str

[GitHub] thrift issue #1373: THRIFT-4334: Fix perl indentation for default attribute ...

2017-09-24 Thread bforbis
Github user bforbis commented on the issue: https://github.com/apache/thrift/pull/1373 I didn't see a testing infrastructure for testing the perl compiler, but I have put reproduction steps in the description of the associated JIRA ticket ---

[GitHub] thrift pull request #1373: THRIFT-4334: Fix perl indentation for default att...

2017-09-24 Thread bforbis
GitHub user bforbis opened a pull request: https://github.com/apache/thrift/pull/1373 THRIFT-4334: Fix perl indentation for default attribute values You can merge this pull request into a Git repository by running: $ git pull https://github.com/bforbis/thrift THRIFT-4334-perl