Github user jbapple-cloudera commented on the issue:
https://github.com/apache/thrift/pull/1232
UBSan refuses to report an error more than once, and unfortunately it does
not have a way to override this behavior. So, once you've seen one UBSan error
at a particular line
GitHub user jbapple-cloudera opened a pull request:
https://github.com/apache/thrift/pull/1232
THRIFT-4138: Remove undefined behavior imported from Boost
Client: C++
There is undefined behavior in boost::lexical_cast that was fixed in
https://github.com/boostorg
Github user jbapple-cloudera commented on the issue:
https://github.com/apache/thrift/pull/1223
I can take a look at the Boost problem next weekend.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user jbapple-cloudera commented on the issue:
https://github.com/apache/thrift/pull/1223
@jeking3 It looks to me like this is failing in TravisCI at the UBSan test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user jbapple-cloudera commented on the issue:
https://github.com/apache/thrift/pull/1222
How about
```
void t_json_generator::write_type_spec(t_type* ttype) {
ttype = ttype->get_true_type();
write_string(get_type_name(ttype));
if (tt
Github user jbapple-cloudera commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1222#discussion_r108063510
--- Diff: build/docker/scripts/ubsan.sh ---
@@ -15,7 +15,7 @@ export CXX=clang++-3.8
# undefined casting, aka "vptr".
#
#
Github user jbapple-cloudera commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1222#discussion_r108061946
--- Diff: compiler/cpp/src/thrift/generate/t_json_generator.cc ---
@@ -273,10 +273,14 @@ void t_json_generator::write_type_spec(t_type* ttype
Github user jbapple-cloudera commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1222#discussion_r108061961
--- Diff: compiler/cpp/src/thrift/generate/t_xml_generator.cc ---
@@ -391,11 +391,16 @@ void t_xml_generator::write_type(t_type* ttype
Github user jbapple-cloudera commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1222#discussion_r108061917
--- Diff: build/docker/scripts/ubsan.sh ---
@@ -15,7 +15,7 @@ export CXX=clang++-3.8
# undefined casting, aka "vptr".
#
#
Github user jbapple-cloudera commented on the issue:
https://github.com/apache/thrift/pull/1214
OK, this new patch does not change the definitions of any `enum`s, only
their usages. It also adds undefined behavior checking to the pre-merge CI
tests on Travis to discourage regressions
Github user jbapple-cloudera commented on the issue:
https://github.com/apache/thrift/pull/1214
Agreed. I'l get to that as soon as I have a chance and then I'll ping this
PR for review when it has addressed that.
---
If your project is set up for it, you can reply to this email
Github user jbapple-cloudera commented on the issue:
https://github.com/apache/thrift/pull/1214
Can this be on hold for a bit? I would like to add the UBSan checks to
.travis.yml first, which may take a couple of days for me to have time for.
---
If your project is set up
Github user jbapple-cloudera commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1214#discussion_r106796226
--- Diff: lib/c_glib/src/thrift/c_glib/protocol/thrift_compact_protocol.c
---
@@ -120,7 +120,11 @@ thrift_bitwise_cast_gdouble (const guint64 v
Github user jbapple-cloudera commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1214#discussion_r106796208
--- Diff: compiler/cpp/src/thrift/parse/t_field.h ---
@@ -68,7 +68,7 @@ class t_field : public t_doc {
int32_t get_key() const
Github user jbapple-cloudera commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1214#discussion_r106796209
--- Diff: lib/cpp/src/thrift/protocol/TCompactProtocol.tcc ---
@@ -387,7 +389,11 @@ uint32_t
TCompactProtocolT::writeVarint64(uint64_t n
Github user jbapple-cloudera commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1214#discussion_r106794729
--- Diff: lib/c_glib/src/thrift/c_glib/protocol/thrift_compact_protocol.c
---
@@ -120,7 +120,11 @@ thrift_bitwise_cast_gdouble (const guint64 v
Github user jbapple-cloudera commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1214#discussion_r106794199
--- Diff: compiler/cpp/src/thrift/parse/t_field.h ---
@@ -68,7 +68,7 @@ class t_field : public t_doc {
int32_t get_key() const
Github user jbapple-cloudera commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1214#discussion_r106794187
--- Diff: lib/c_glib/src/thrift/c_glib/protocol/thrift_compact_protocol.c
---
@@ -120,7 +120,11 @@ thrift_bitwise_cast_gdouble (const guint64 v
GitHub user jbapple-cloudera opened a pull request:
https://github.com/apache/thrift/pull/1214
THRIFT-2026: Eliminate some undefined behavior in C/C++
Clients: glib, C++
Patch: Jim Apple <jbapple-imp...@apache.org>
These examples of undefined behavior were found
19 matches
Mail list logo
