[GitHub] thrift issue #1034: THRIFT-3857

2017-04-07 Thread leaves4j
Github user leaves4j commented on the issue: https://github.com/apache/thrift/pull/1034 @jeking3 it's not a breaking change --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] thrift issue #1034: THRIFT-3857

2017-04-05 Thread leaves4j
Github user leaves4j commented on the issue: https://github.com/apache/thrift/pull/1034 I have rebased on upstream/master and add those commits into latest branch @jeking3 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] thrift issue #1034: THRIFT-3857

2016-07-04 Thread leaves4j
Github user leaves4j commented on the issue: https://github.com/apache/thrift/pull/1034 What should I do with the fail checks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] thrift pull request #1034: THRIFT-3857

2016-06-27 Thread leaves4j
GitHub user leaves4j opened a pull request: https://github.com/apache/thrift/pull/1034 THRIFT-3857 thrift js:node complier support an object as parameter not an instance of struct You can merge this pull request into a Git repository by running: $ git pull https://github.com