[GitHub] thrift issue #1521: THRIFT-4531 (#1)

2018-03-27 Thread margars
Github user margars commented on the issue: https://github.com/apache/thrift/pull/1521 Build failed with Gradle POM parsing error which has nothing to do with the commit. ---

[GitHub] thrift pull request #1521: THRIFT-4531 (#1)

2018-03-27 Thread margars
GitHub user margars opened a pull request: https://github.com/apache/thrift/pull/1521 THRIFT-4531 (#1) THRIFT-4531: Fix generated Python read() method for immutable structs with optional members. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] thrift issue #1520: THRIFT-4531

2018-03-27 Thread margars
Github user margars commented on the issue: https://github.com/apache/thrift/pull/1520 I am behind corporate firewall and don't know how to squash from the web interface, will try from scratch. ---

[GitHub] thrift pull request #1520: THRIFT-4531

2018-03-27 Thread margars
Github user margars closed the pull request at: https://github.com/apache/thrift/pull/1520 ---

[GitHub] thrift issue #1520: THRIFT-4531

2018-03-27 Thread margars
Github user margars commented on the issue: https://github.com/apache/thrift/pull/1520 Sorry, I am not familiar with all this setup and rules. ---

[GitHub] thrift pull request #1520: THRIFT-4531

2018-03-27 Thread margars
GitHub user margars opened a pull request: https://github.com/apache/thrift/pull/1520 THRIFT-4531 I am not familiar with your rules for contributions. This issue is described in JIRA THRIFT-4531. You can merge this pull request into a Git repository by running: $ git pull