[GitHub] thrift issue #1031: THRIFT-3859: Unix Domain Socket Support in Objective-C

Github user gaoshanyu commented on the issue: https://github.com/apache/thrift/pull/1031 Who can tell me why the cocoa lib has Swift2.3 codes? Where I can download full Objective-C lib? Or is there a way to make the lib to support Swift 3 +? --- If your project is set up for it, you

[GitHub] thrift issue #1031: THRIFT-3859: Unix Domain Socket Support in Objective-C

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1031 Okay, well I'm going to approve and merge, and open a Jira item to add crosstest support for cocoa (if not there, I'll check) and for unix sockets in cocoa. --- If your project is set up for it,

[GitHub] thrift issue #1031: THRIFT-3859: Unix Domain Socket Support in Objective-C

Github user clindsay commented on the issue: https://github.com/apache/thrift/pull/1031 I've been using it in a project since last summer, communicating between a python process and a Swift/Objective-C process. The project has been in beta with a few hundred users, and no reports of

[GitHub] thrift issue #1031: THRIFT-3859: Unix Domain Socket Support in Objective-C

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1031 Have you used this in a project and know that it works? Given this is an improvement I'd like to get it in, but if you don't have time right now to add make cross support, I can add a story in

[GitHub] thrift issue #1031: THRIFT-3859: Unix Domain Socket Support in Objective-C

Github user clindsay commented on the issue: https://github.com/apache/thrift/pull/1031 Hey @jeking3, sorry for going silent there. I've had a lot of other things on my plate, and haven't gotten to this yet, but I still intend to add this support when I have a chance! --- If your

[GitHub] thrift issue #1031: THRIFT-3859: Unix Domain Socket Support in Objective-C

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1031 Hi @clindsay just checking in to see if you had made any progress on adding cross test support for cocoa. If not that's okay... it would be really nice to have it though. --- If your project is

[GitHub] thrift issue #1031: THRIFT-3859: Unix Domain Socket Support in Objective-C

Github user clindsay commented on the issue: https://github.com/apache/thrift/pull/1031 Thanks @jeking3. Sorry for the slow response, a bit busy these days! Just to clarify, as far as I can tell there isn't a cocoa test client today. Is this correct? So, in order to add these

[GitHub] thrift issue #1031: THRIFT-3859: Unix Domain Socket Support in Objective-C

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1031 To enable "make cross" support you can follow the pattern in test/tests.json to add the "domain" transport to your cocoa test. Your cocoa test_client needs to understand that transport and create

[GitHub] thrift issue #1031: THRIFT-3859: Unix Domain Socket Support in Objective-C

Github user clindsay commented on the issue: https://github.com/apache/thrift/pull/1031 No problem. Just rebased on master. I will work on adding to the "make cross" test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] thrift issue #1031: THRIFT-3859: Unix Domain Socket Support in Objective-C

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1031 Would it be possible to rebase this on master so we can get a clean CI build? Also enabling unix socket transport in the "make cross" test would be really nice to validate this code. --- If your