Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1034
I'll keep monitoring. I would prefer a code review from someone else who
uses node.js; it looks like a positive change to me.
---
If your project is set up for it, you can reply to this email and
Github user leaves4j commented on the issue:
https://github.com/apache/thrift/pull/1034
@jeking3 it's not a breaking change
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1034
The only build failure can be attributed to THRIFT-4071. Otherwise, this
is just waiting for someone with node.js experience to review. Specifically I
need to know if this change is backwards
Github user leaves4j commented on the issue:
https://github.com/apache/thrift/pull/1034
I have rebased on upstream/master and add those commits into latest branch
@jeking3
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user leaves4j commented on the issue:
https://github.com/apache/thrift/pull/1034
What should I do with the fail checks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
