[GitHub] thrift issue #1058: Node.js: Set/unset client seqid for json_protocol and co...

2018-03-13 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1058 In general I want to make sure all clients send a seqid and all servers put that seqid in the result. Without this we won't be able to have clients that can have multiple outstanding requests in

[GitHub] thrift issue #1058: Node.js: Set/unset client seqid for json_protocol and co...

2018-03-13 Thread bananer
Github user bananer commented on the issue: https://github.com/apache/thrift/pull/1058 @jeking3 To be honest, I don't know why this is useful/necessary. I think there is no need for a seqid because the connection between request and response is handled through callbacks

[GitHub] thrift issue #1058: Node.js: Set/unset client seqid for json_protocol and co...

2018-03-13 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1058 @bananer is this worth pulling forward if it passes a build? ---

[GitHub] thrift issue #1058: Node.js: Set/unset client seqid for json_protocol and co...

2017-10-25 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1058 This change needs a Jira ticket; please see https://thrift.apache.org/docs/HowToContribute. Also if you can rebase on master and push that will kick a new CI build; CI needs to pass (or failures

[GitHub] thrift issue #1058: Node.js: Set/unset client seqid for json_protocol and co...

2017-04-06 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1058 This change needs a Jira ticket; please see https://thrift.apache.org/docs/HowToContribute. Also if you can rebase on master and push that will kick a new CI build; CI needs to pass (or failures