[GitHub] thrift issue #1075: THRIFT-3916 Throw proper errors from JS, not strings

2018-03-13 Thread bananer
Github user bananer commented on the issue: https://github.com/apache/thrift/pull/1075 @jeking3 This is a well-intended change but I think it is not implemented correctly and will break error handling for users. In some places in the compiler the input to `render_recv_throw`

[GitHub] thrift issue #1075: THRIFT-3916 Throw proper errors from JS, not strings

2018-03-13 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1075 @bananer is this worth pulling forward if it passes a build? Is it a breaking change? ---

[GitHub] thrift issue #1075: THRIFT-3916 Throw proper errors from JS, not strings

2017-10-25 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1075 @SimenB if you are interested in resurrecting this let me know - rebase on current master and push to CI will run all our tests. ---

[GitHub] thrift issue #1075: THRIFT-3916 Throw proper errors from JS, not strings

2017-09-22 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1075 @SimenB if you are interested in resurrecting this let me know - rebase on current master and push to CI will run all our tests. ---

[GitHub] thrift issue #1075: THRIFT-3916 Throw proper errors from JS, not strings

2016-09-02 Thread nsuke
Github user nsuke commented on the issue: https://github.com/apache/thrift/pull/1075 @SimenB we have `Dokerfile` s for build env inside build/docker/ subdirectories. You can also do `docker pull thrift/ubuntu` or thrift/debian. --- If your project is set up for it, you can reply