[GitHub] thrift issue #1157: THRIFT-4033 disable compiler plug-ins for standard debia...

2017-01-19 Thread jfarrell
Github user jfarrell commented on the issue: https://github.com/apache/thrift/pull/1157 sure, or modify the ticket description to 'disable compiler plug-ins by default for all builds' --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] thrift issue #1157: THRIFT-4033 disable compiler plug-ins for standard debia...

2017-01-19 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1157 I'm okay making the default for plug-in support "OFF", and you have to enable it specifically. Would it be okay to merge this as it fixes the ticket as described, and open a new one to change the

[GitHub] thrift issue #1157: THRIFT-4033 disable compiler plug-ins for standard debia...

2017-01-19 Thread jfarrell
Github user jfarrell commented on the issue: https://github.com/apache/thrift/pull/1157 We have had issues with plugin support being on by default in a couple build instances now, and this does not fix when we pull out autoconf that it wont reappear with cmake. I'd like to see us

[GitHub] thrift issue #1157: THRIFT-4033 disable compiler plug-ins for standard debia...

2017-01-19 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1157 @jfarrell I'd like one review of this before I merge it. It did fix the issue I had with the stock 0.10.0 debian package for the compiler not working. --- If your project is set up for it, you