Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1211
THRIFT-4160
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1211
Please rebase this branch against upstream/master and force push to kick
off a new build. I would like to see the CI build pass (or get much closer
than it is now) before merging.
---
If your
Github user xiaosuo commented on the issue:
https://github.com/apache/thrift/pull/1211
I think this patch doesn't introduce any inconsistency. And the correctness
of the number of active processors deserves another separated patch. We'd
better not mix fixes into a huge patch.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1211
If you have the fixes let's get them all in together. The current fix is
not complete and causes counting errors, which lead to - I don't know...
---
If your project is set up for it, you can
Github user xiaosuo commented on the issue:
https://github.com/apache/thrift/pull/1211
@jeking3 Did you mean that we should fix all issues about the number of
active processors in this patch instead of a separated one?
---
If your project is set up for it, you can reply to this
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1211
@xiaosuo just a reminder, if you have additional fixes (it sounds like you
do)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1211
This patch as-is causes a counting error, so if you can amend this one with
those changes we can get them all fixed together.
---
If your project is set up for it, you can reply to this email and
Github user xiaosuo commented on the issue:
https://github.com/apache/thrift/pull/1211
@jeking3 you are correct. In fact, we had found this issue, and we should
do such things at all the error path when notifying the io threads. I will
address this issue in a separated patch.
Github user xiaosuo commented on the issue:
https://github.com/apache/thrift/pull/1211
I had tried to find my password, but nothing was received. It seems that
Jira doesn't work properly with gmail. Could you help me?
---
If your project is set up for it, you can reply to this email
