[GitHub] thrift issue #1216: TNonblockingServer: Fix using uninitialized event_

2017-04-02 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1216 THRIFT-4161 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] thrift issue #1216: TNonblockingServer: Fix using uninitialized event_

2017-03-30 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1216 Please rebase against upstream/master and force push to kick a new build. I'd like to see CI pass (or get much closer) before merging. --- If your project is set up for it, you can reply to this

[GitHub] thrift issue #1216: TNonblockingServer: Fix using uninitialized event_

2017-03-23 Thread xiaosuo
Github user xiaosuo commented on the issue: https://github.com/apache/thrift/pull/1216 However when closing the connection, we don't check if eventFlags_ is zero. For a new connection, event_ isn't initialized by the constructor() or init(), and if we fail to pass it to the