[GitHub] thrift issue #1497: Do not call workSocket() in TNonblockigServer without en...

2018-03-11 Thread bgedik
Github user bgedik commented on the issue: https://github.com/apache/thrift/pull/1497 @jeking3 There is already a Jira item: https://issues.apache.org/jira/browse/THRIFT-4465 Btw, it makes sense that the fix resolves the framed transport failures. Because the bug was about

[GitHub] thrift issue #1497: Do not call workSocket() in TNonblockigServer without en...

2018-03-11 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1497 Cool so that last test run was without the fix (I thought it had it, but it only had my fixes to TestServer.cpp), and adding your fix seems to have taken care of the header failures somehow:

[GitHub] thrift issue #1497: Do not call workSocket() in TNonblockigServer without en...

2018-03-11 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1497 You need to create a Jira ticket in the THRIFT project (https://issues.apache.org/jira/projects/THRIFT/issues) that describes the bug and resolution so that I can merge it. --- I

[GitHub] thrift issue #1497: Do not call workSocket() in TNonblockigServer without en...

2018-03-11 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1497 What's the Jira ticket ID for this work? ---

[GitHub] thrift issue #1497: Do not call workSocket() in TNonblockigServer without en...

2018-03-11 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1497 Wow, haven't seen a green build in a while. Of course, none of the cross tests exercise nonblocking code. :( Would be nice to add this as another matrix option. ---

[GitHub] thrift issue #1497: Do not call workSocket() in TNonblockigServer without en...

2018-03-10 Thread bgedik
Github user bgedik commented on the issue: https://github.com/apache/thrift/pull/1497 @jeking3 I think all tests have passed. ---

[GitHub] thrift issue #1497: Do not call workSocket() in TNonblockigServer without en...

2018-03-09 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1497 Rebase on master and let's see what happens, thanks. ---

[GitHub] thrift issue #1497: Do not call workSocket() in TNonblockigServer without en...

2018-02-28 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1497 I'm not aware of those being common or known. I have a bit of work to do in order to stabilize the CI builds and get them back to green... ---

[GitHub] thrift issue #1497: Do not call workSocket() in TNonblockigServer without en...

2018-02-26 Thread ozymaxx
Github user ozymaxx commented on the issue: https://github.com/apache/thrift/pull/1497 I also encounter the same error, but it does not show up every time I run the tests on Travis CI. ---

[GitHub] thrift issue #1497: Do not call workSocket() in TNonblockigServer without en...

2018-02-19 Thread bgedik
Github user bgedik commented on the issue: https://github.com/apache/thrift/pull/1497 @jeking3 The ``client_pool_tests`` failed in 2 of the bots within Travis-CI. I don't think it is related to my change. Are these known to fail every now and then? ```