Github user flandr commented on the pull request:
https://github.com/apache/thrift/pull/271#issuecomment-94001280
Of course, and it was https://issues.apache.org/jira/browse/THRIFT-2836
was merged. Not sure exactly how, tho clearly not through this interface ;)
---
If your project
Github user jfarrell commented on the pull request:
https://github.com/apache/thrift/pull/271#issuecomment-93617107
Thanks for your patch @flandr, in order for us to accept a pull request we
need to have a jira ticket associated with it. Please see our contributing
guide at
Github user flandr commented on the pull request:
https://github.com/apache/thrift/pull/271#issuecomment-66502287
The ci job is getting compiler failures; not sure what version of GCC
Travis is running
---
If your project is set up for it, you can reply to this email and have your
Github user flandr commented on the pull request:
https://github.com/apache/thrift/pull/271#issuecomment-66313618
Sounds good; fixed merge conflicts and ran `make style` for conformance.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user flandr commented on the pull request:
https://github.com/apache/thrift/pull/271#issuecomment-66141457
Is there any specific reason for adding an option for this?
* If you're thinking of a reason to _not_ emit MoveConstructible/Assignable
types, I'd certainly like
Github user bufferoverflow commented on the pull request:
https://github.com/apache/thrift/pull/271#issuecomment-66181001
I'm fine with this, could you fix the merge conflicts and I will commit.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user bufferoverflow commented on the pull request:
https://github.com/apache/thrift/pull/271#issuecomment-65940029
Is there any specific reason for adding an option for this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user flandr commented on the pull request:
https://github.com/apache/thrift/pull/271#issuecomment-65947358
Is there any specific reason for adding an option for this?
My motivation for adding the functionality was avoiding copies for Thrift
container types (e.g. list,
GitHub user flandr opened a pull request:
https://github.com/apache/thrift/pull/271
Add moveable_types option to C++ generator
Setting this option enables generation of MoveConstructible types,
allowing types to be bound via move in std::bind. This is especially
pleasant
