Github user mygityf closed the pull request at:
https://github.com/apache/thrift/pull/864
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user nsuke commented on the pull request:
https://github.com/apache/thrift/pull/864#issuecomment-185796578
please close this PR as it's merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user nsuke commented on the pull request:
https://github.com/apache/thrift/pull/864#issuecomment-185778986
Nice, the last commit fixed the problem. I guess it's a Lua 5.3 issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user mygityf commented on the pull request:
https://github.com/apache/thrift/pull/864#issuecomment-185568709
@nsuke Integer is convert to string without dot. can you try again in your
env to check whether it work well or not, thanks.
---
If your project is set up for it, you
Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/864#discussion_r53268905
--- Diff: lib/lua/TJsonProtocol.lua ---
@@ -0,0 +1,725 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one
+-- or more contributor
Github user nsuke commented on the pull request:
https://github.com/apache/thrift/pull/864#issuecomment-185531813
sender side.
used lua client against cpp / py server and extracted the json in the
packet with tcpdump.
---
If your project is set up for it, you can reply to this
Github user mygityf commented on the pull request:
https://github.com/apache/thrift/pull/864#issuecomment-185525091
@nsuke issue of i8(byte) and i32 values are encoded like 1.0 instead of 1.
It is reproduced in receiver side or sender side or both side?
---
If your project is
Github user mygityf commented on a diff in the pull request:
https://github.com/apache/thrift/pull/864#discussion_r53265228
--- Diff: lib/lua/TJsonProtocol.lua ---
@@ -0,0 +1,725 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one
+-- or more
Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/864#discussion_r53193197
--- Diff: lib/lua/TJsonProtocol.lua ---
@@ -0,0 +1,725 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one
+-- or more contributor
Github user nsuke commented on the pull request:
https://github.com/apache/thrift/pull/864#issuecomment-185259237
I've tested this on my local env but i8(byte) and i32 values are encoded
like 1.0 instead of 1, and naturally the receiver side fails to handle this.
I'm using Lua
Github user mygityf commented on the pull request:
https://github.com/apache/thrift/pull/864#issuecomment-184037495
The solution to the test failure:
pull request for C++ thrift https://github.com/apache/thrift/pull/870.
---
If your project is set up for it, you can reply to this
Github user mygityf commented on the pull request:
https://github.com/apache/thrift/pull/864#issuecomment-184034288
The precision is 15 bits after dot of format casting from double to string
in Thrift-cpp-library- json-protocol.
But the precision is 16 bits after dot in
Github user mygityf commented on the pull request:
https://github.com/apache/thrift/pull/864#issuecomment-183865602
@nsuke
I move THRIFT-3631 to new branch and keep only the THRIFT-3631 commit in
this pull request.
---
If your project is set up for it, you can reply to this
Github user nsuke commented on the pull request:
https://github.com/apache/thrift/pull/864#issuecomment-183876908
@mygityf the tests passed against all but C++ server.
https://travis-ci.org/apache/thrift/jobs/109138968#L8071
Could you look into the failures ?
You can
GitHub user mygityf opened a pull request:
https://github.com/apache/thrift/pull/864
THRIFT-3631 Lua- JSON protocol implement for thrift-lua library.
THRIFT-3631 Lua-This is JSON protocol implement for thrift-lua library.
TJsonProtocol.lua is new source of lua for thrift JSON
15 matches
Mail list logo
