Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/743
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user bgould commented on a diff in the pull request:
https://github.com/apache/thrift/pull/743#discussion_r47486573
--- Diff: lib/java/test/org/apache/thrift/TestStruct.java ---
@@ -309,11 +309,33 @@ public void testToString() throws Exception {
}
public
Github user Gospodzin commented on a diff in the pull request:
https://github.com/apache/thrift/pull/743#discussion_r47491721
--- Diff: lib/java/test/org/apache/thrift/TestStruct.java ---
@@ -309,11 +309,33 @@ public void testToString() throws Exception {
}
Github user bgould commented on a diff in the pull request:
https://github.com/apache/thrift/pull/743#discussion_r47486416
--- Diff: lib/java/test/org/apache/thrift/TestStruct.java ---
@@ -309,11 +309,33 @@ public void testToString() throws Exception {
}
public
Github user Gospodzin commented on a diff in the pull request:
https://github.com/apache/thrift/pull/743#discussion_r47469406
--- Diff: lib/java/test/org/apache/thrift/TestStruct.java ---
@@ -309,11 +309,33 @@ public void testToString() throws Exception {
}
GitHub user bgould opened a pull request:
https://github.com/apache/thrift/pull/743
Thrift 3486 - Java generated `getFieldValue` is incompatible with
`setFieldValue` for binary values.
For binary fields, the compiler generates Java getter/setter methods for
primitive byte arrays
Github user Gospodzin commented on a diff in the pull request:
https://github.com/apache/thrift/pull/743#discussion_r47467283
--- Diff: lib/java/test/org/apache/thrift/TestStruct.java ---
@@ -309,11 +309,33 @@ public void testToString() throws Exception {
}
