[jira] [Commented] (THRIFT-4236) Support context in go generated code.

2017-07-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16097390#comment-16097390 ] ASF GitHub Bot commented on THRIFT-4236: Github user asfgit closed the pull request at:

[jira] [Commented] (THRIFT-4236) Support context in go generated code.

2017-07-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094403#comment-16094403 ] ASF GitHub Bot commented on THRIFT-4236: GitHub user taozle reopened a pull request:

[jira] [Commented] (THRIFT-4236) Support context in go generated code.

2017-07-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094402#comment-16094402 ] ASF GitHub Bot commented on THRIFT-4236: Github user taozle closed the pull request at:

[jira] [Commented] (THRIFT-4236) Support context in go generated code.

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16090063#comment-16090063 ] ASF GitHub Bot commented on THRIFT-4236: GitHub user taozle opened a pull request:

[jira] [Commented] (THRIFT-4236) Support context in go generated code.

2017-07-12 Thread taozle (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16084196#comment-16084196 ] taozle commented on THRIFT-4236: Maybe i can work on this this weekend or next week if it was not too

[jira] [Commented] (THRIFT-4236) Support context in go generated code.

2017-07-12 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16084085#comment-16084085 ] Jens Geyer commented on THRIFT-4236: We have more than once decided to focus on newer versions, so I

[jira] [Commented] (THRIFT-4236) Support context in go generated code.

2017-07-12 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16084098#comment-16084098 ] Can Celasun commented on THRIFT-4236: - {quote}So if you have a better idea, please do!{quote} I

[jira] [Commented] (THRIFT-4236) Support context in go generated code.

2017-07-11 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16083445#comment-16083445 ] Can Celasun commented on THRIFT-4236: - I realize I'm a bit late to notice this PR since it's already

[jira] [Commented] (THRIFT-4236) Support context in go generated code.

2017-07-02 Thread taozle (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071878#comment-16071878 ] taozle commented on THRIFT-4236: Awesome! I am considering making this the default behavior in 1.0, any

[jira] [Commented] (THRIFT-4236) Support context in go generated code.

2017-07-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071294#comment-16071294 ] ASF GitHub Bot commented on THRIFT-4236: Github user asfgit closed the pull request at:

[jira] [Commented] (THRIFT-4236) Support context in go generated code.

2017-07-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071260#comment-16071260 ] ASF GitHub Bot commented on THRIFT-4236: Github user Jens-G commented on the issue:

[jira] [Commented] (THRIFT-4236) Support context in go generated code.

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16070292#comment-16070292 ] ASF GitHub Bot commented on THRIFT-4236: GitHub user taozle reopened a pull request:

[jira] [Commented] (THRIFT-4236) Support context in go generated code.

2017-06-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16070291#comment-16070291 ] ASF GitHub Bot commented on THRIFT-4236: Github user taozle closed the pull request at:

[jira] [Commented] (THRIFT-4236) Support context in go generated code.

2017-06-30 Thread taozle (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069956#comment-16069956 ] taozle commented on THRIFT-4236: {quote}Could you adjust the build scripts version checks

[jira] [Commented] (THRIFT-4236) Support context in go generated code.

2017-06-29 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16067982#comment-16067982 ] Jens Geyer commented on THRIFT-4236: {quote} or should we just simple require go >= 1.7? {quote} I

[jira] [Commented] (THRIFT-4236) Support context in go generated code.

2017-06-27 Thread taozle (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16065827#comment-16065827 ] taozle commented on THRIFT-4236: Hi, [~jensg], I fired a pull request for adding context support in

[jira] [Commented] (THRIFT-4236) Support context in go generated code.

2017-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16064944#comment-16064944 ] ASF GitHub Bot commented on THRIFT-4236: GitHub user taozle reopened a pull request:

[jira] [Commented] (THRIFT-4236) Support context in go generated code.

2017-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16064943#comment-16064943 ] ASF GitHub Bot commented on THRIFT-4236: Github user taozle closed the pull request at:

[jira] [Commented] (THRIFT-4236) Support context in go generated code.

2017-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16064407#comment-16064407 ] ASF GitHub Bot commented on THRIFT-4236: GitHub user taozle opened a pull request:

[jira] [Commented] (THRIFT-4236) Support context in go generated code.

2017-06-26 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16063806#comment-16063806 ] Jens Geyer commented on THRIFT-4236: {quote} > other framework like grpc will pass a context for the

[jira] [Commented] (THRIFT-4236) Support context in go generated code.

2017-06-26 Thread taozle (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16062841#comment-16062841 ] taozle commented on THRIFT-4236: I don't think the {{THeaderTransport}} is what i want. The {{context}}

[jira] [Commented] (THRIFT-4236) Support context in go generated code.

2017-06-26 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16062790#comment-16062790 ] Jens Geyer commented on THRIFT-4236: There is {{THeaderTransport}}, currently only implemented for