[jira] [Commented] (THRIFT-4484) C++ codegen invalid for optional self-membership

[ https://issues.apache.org/jira/browse/THRIFT-4484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589667#comment-16589667 ] Craig Ringer commented on THRIFT-4484: -- I think it's related to #1528 too > C++ codegen invalid

[jira] [Commented] (THRIFT-4484) C++ codegen invalid for optional self-membership

[ https://issues.apache.org/jira/browse/THRIFT-4484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349662#comment-16349662 ] Craig Ringer commented on THRIFT-4484: -- If I attempt to actually use {{cpp.ref}} in my code as used

[jira] [Commented] (THRIFT-4484) C++ codegen invalid for optional self-membership

[ https://issues.apache.org/jira/browse/THRIFT-4484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349631#comment-16349631 ] Craig Ringer commented on THRIFT-4484: -- Also, the regression tests show that both {{cpp.ref}} and

[jira] [Commented] (THRIFT-4484) C++ codegen invalid for optional self-membership

[ https://issues.apache.org/jira/browse/THRIFT-4484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349623#comment-16349623 ] Craig Ringer commented on THRIFT-4484: -- [~davejwatson] Hrm, too soon. {{&}} generates bogus code

[jira] [Commented] (THRIFT-4484) C++ codegen invalid for optional self-membership

[ https://issues.apache.org/jira/browse/THRIFT-4484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16348660#comment-16348660 ] Craig Ringer commented on THRIFT-4484: -- [~davejwatson] Brilliant! Apparently it's now spelled "&",

[jira] [Commented] (THRIFT-4484) C++ codegen invalid for optional self-membership

[ https://issues.apache.org/jira/browse/THRIFT-4484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347488#comment-16347488 ] Dave Watson commented on THRIFT-4484: - IIRC cpp needs "cpp.ref = "true"" on the field to make it a

[jira] [Commented] (THRIFT-4484) C++ codegen invalid for optional self-membership

[ https://issues.apache.org/jira/browse/THRIFT-4484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346460#comment-16346460 ] Craig Ringer commented on THRIFT-4484: -- On 31 Jan. 2018 16:11, "Jens Geyer (JIRA)"

[jira] [Commented] (THRIFT-4484) C++ codegen invalid for optional self-membership

[ https://issues.apache.org/jira/browse/THRIFT-4484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346405#comment-16346405 ] Jens Geyer commented on THRIFT-4484: The more interesting question is whether it makes sense to do

[jira] [Commented] (THRIFT-4484) C++ codegen invalid for optional self-membership

[ https://issues.apache.org/jira/browse/THRIFT-4484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346264#comment-16346264 ] ASF GitHub Bot commented on THRIFT-4484: Github user ringerc commented on the issue: