[jira] [Commented] (THRIFT-4506) [CVE-2018-1320] Remove assertion in Java SASL code that would be ignored in release builds

[ https://issues.apache.org/jira/browse/THRIFT-4506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16791922#comment-16791922 ] James E. King III commented on THRIFT-4506: --- Good points, I will add this to our release

[jira] [Commented] (THRIFT-4506) [CVE-2018-1320] Remove assertion in Java SASL code that would be ignored in release builds

[ https://issues.apache.org/jira/browse/THRIFT-4506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16791902#comment-16791902 ] Christopher Tubbs commented on THRIFT-4506: --- Thanks, [~jking3]! FWIW, I did try to look at,

[jira] [Commented] (THRIFT-4506) [CVE-2018-1320] Remove assertion in Java SASL code that would be ignored in release builds

[ https://issues.apache.org/jira/browse/THRIFT-4506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16791668#comment-16791668 ] James E. King III commented on THRIFT-4506: --- To see the exact changes in 0.9.3.1 refer to this

[jira] [Commented] (THRIFT-4506) [CVE-2018-1320] Remove assertion in Java SASL code that would be ignored in release builds

[ https://issues.apache.org/jira/browse/THRIFT-4506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16789754#comment-16789754 ] Mike Yoder commented on THRIFT-4506: FWIW, [~jking3], I'm glad you made the release. :) >

[jira] [Commented] (THRIFT-4506) [CVE-2018-1320] Remove assertion in Java SASL code that would be ignored in release builds

[ https://issues.apache.org/jira/browse/THRIFT-4506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788723#comment-16788723 ] Christopher Tubbs commented on THRIFT-4506: --- [~jking3] The ASF release process applies to any

[jira] [Commented] (THRIFT-4506) [CVE-2018-1320] Remove assertion in Java SASL code that would be ignored in release builds

[ https://issues.apache.org/jira/browse/THRIFT-4506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788726#comment-16788726 ] Christopher Tubbs commented on THRIFT-4506: --- > Sorry for the trouble I've caused. Mistakes

[jira] [Commented] (THRIFT-4506) [CVE-2018-1320] Remove assertion in Java SASL code that would be ignored in release builds

[ https://issues.apache.org/jira/browse/THRIFT-4506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788724#comment-16788724 ] James E. King III commented on THRIFT-4506: --- Vote on 0.9.3.1 is out now, release candidate

[jira] [Commented] (THRIFT-4506) [CVE-2018-1320] Remove assertion in Java SASL code that would be ignored in release builds

[ https://issues.apache.org/jira/browse/THRIFT-4506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788699#comment-16788699 ] Jens Geyer commented on THRIFT-4506: [~ctubbsii], I see the point. As I understand it, the

[jira] [Commented] (THRIFT-4506) [CVE-2018-1320] Remove assertion in Java SASL code that would be ignored in release builds

[ https://issues.apache.org/jira/browse/THRIFT-4506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788702#comment-16788702 ] James E. King III commented on THRIFT-4506: --- I'm manually applying the changes to the 0.9.3

[jira] [Commented] (THRIFT-4506) [CVE-2018-1320] Remove assertion in Java SASL code that would be ignored in release builds

[ https://issues.apache.org/jira/browse/THRIFT-4506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788697#comment-16788697 ] James E. King III commented on THRIFT-4506: --- It is a single language patch for a CVE.  It did

[jira] [Commented] (THRIFT-4506) [CVE-2018-1320] Remove assertion in Java SASL code that would be ignored in release builds

[ https://issues.apache.org/jira/browse/THRIFT-4506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788465#comment-16788465 ] Christopher Tubbs commented on THRIFT-4506: --- Where was the release vote for 0.9.3-1? And why

[jira] [Commented] (THRIFT-4506) [CVE-2018-1320] Remove assertion in Java SASL code that would be ignored in release builds

[ https://issues.apache.org/jira/browse/THRIFT-4506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16780358#comment-16780358 ] Norbert Kalmar commented on THRIFT-4506: Thank you! > [CVE-2018-1320] Remove assertion in Java

[jira] [Commented] (THRIFT-4506) [CVE-2018-1320] Remove assertion in Java SASL code that would be ignored in release builds

[ https://issues.apache.org/jira/browse/THRIFT-4506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779326#comment-16779326 ] James E. King III commented on THRIFT-4506: --- I just pushed an 0.9.3.1 branch to origin for you

[jira] [Commented] (THRIFT-4506) [CVE-2018-1320] Remove assertion in Java SASL code that would be ignored in release builds

[ https://issues.apache.org/jira/browse/THRIFT-4506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779324#comment-16779324 ] James E. King III commented on THRIFT-4506: --- All I did was take 0.9.3 and apply 

[jira] [Commented] (THRIFT-4506) [CVE-2018-1320] Remove assertion in Java SASL code that would be ignored in release builds

[ https://issues.apache.org/jira/browse/THRIFT-4506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1693#comment-1693 ] Norbert Kalmar commented on THRIFT-4506: Typo: git *branch We need it to re-generate the thrift

[jira] [Commented] (THRIFT-4506) [CVE-2018-1320] Remove assertion in Java SASL code that would be ignored in release builds

[ https://issues.apache.org/jira/browse/THRIFT-4506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1691#comment-1691 ] Norbert Kalmar commented on THRIFT-4506: Hi [~jking3], Can you point me to the github ranch from

[jira] [Commented] (THRIFT-4506) [CVE-2018-1320] Remove assertion in Java SASL code that would be ignored in release builds

[ https://issues.apache.org/jira/browse/THRIFT-4506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16772770#comment-16772770 ] Norbert Kalmar commented on THRIFT-4506: Nevermind, I guess the index file hasn,t updated yet.

[jira] [Commented] (THRIFT-4506) [CVE-2018-1320] Remove assertion in Java SASL code that would be ignored in release builds

[ https://issues.apache.org/jira/browse/THRIFT-4506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16772765#comment-16772765 ] Norbert Kalmar commented on THRIFT-4506: Thank you [~jking3] ! Am I missing something, I can't

[jira] [Commented] (THRIFT-4506) [CVE-2018-1320] Remove assertion in Java SASL code that would be ignored in release builds

[ https://issues.apache.org/jira/browse/THRIFT-4506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16772303#comment-16772303 ] Mike Yoder commented on THRIFT-4506: Awesome, thanks again! -Mike > [CVE-2018-1320] Remove

[jira] [Commented] (THRIFT-4506) [CVE-2018-1320] Remove assertion in Java SASL code that would be ignored in release builds

[ https://issues.apache.org/jira/browse/THRIFT-4506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16772298#comment-16772298 ] James E. King III commented on THRIFT-4506: --- libthrift 0.9.3-1 has been published to maven

[jira] [Commented] (THRIFT-4506) [CVE-2018-1320] Remove assertion in Java SASL code that would be ignored in release builds

[ https://issues.apache.org/jira/browse/THRIFT-4506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16772181#comment-16772181 ] Mike Yoder commented on THRIFT-4506: 0.9.3_1 Builds fine here. > [CVE-2018-1320] Remove assertion

[jira] [Commented] (THRIFT-4506) [CVE-2018-1320] Remove assertion in Java SASL code that would be ignored in release builds

[ https://issues.apache.org/jira/browse/THRIFT-4506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16772180#comment-16772180 ] James E. King III commented on THRIFT-4506: --- Thanks for that - it does look like I will need

[jira] [Commented] (THRIFT-4506) [CVE-2018-1320] Remove assertion in Java SASL code that would be ignored in release builds

[ https://issues.apache.org/jira/browse/THRIFT-4506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16772126#comment-16772126 ] Mike Yoder commented on THRIFT-4506: Thanks for your work!  It looks OK; we're going to try a build

[jira] [Commented] (THRIFT-4506) [CVE-2018-1320] Remove assertion in Java SASL code that would be ignored in release builds

[ https://issues.apache.org/jira/browse/THRIFT-4506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16771067#comment-16771067 ] James E. King III commented on THRIFT-4506: --- [~yoderme] could you inspect the following staged

[jira] [Commented] (THRIFT-4506) [CVE-2018-1320] Remove assertion in Java SASL code that would be ignored in release builds

[ https://issues.apache.org/jira/browse/THRIFT-4506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767609#comment-16767609 ] James E. King III commented on THRIFT-4506: --- I Added "mavenHome" as a property, but it still

[jira] [Commented] (THRIFT-4506) [CVE-2018-1320] Remove assertion in Java SASL code that would be ignored in release builds

[ https://issues.apache.org/jira/browse/THRIFT-4506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767575#comment-16767575 ] James E. King III commented on THRIFT-4506: --- Well isn't that annoying.. {noformat}

[jira] [Commented] (THRIFT-4506) [CVE-2018-1320] Remove assertion in Java SASL code that would be ignored in release builds

[ https://issues.apache.org/jira/browse/THRIFT-4506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767562#comment-16767562 ] James E. King III commented on THRIFT-4506: --- Trying to use the ubuntu-trusty image, or the

[jira] [Commented] (THRIFT-4506) [CVE-2018-1320] Remove assertion in Java SASL code that would be ignored in release builds

[ https://issues.apache.org/jira/browse/THRIFT-4506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767489#comment-16767489 ] James E. King III commented on THRIFT-4506: --- Let me see what I can do. > [CVE-2018-1320]

[jira] [Commented] (THRIFT-4506) [CVE-2018-1320] Remove assertion in Java SASL code that would be ignored in release builds

[ https://issues.apache.org/jira/browse/THRIFT-4506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767423#comment-16767423 ] Mike Yoder commented on THRIFT-4506: [~jking3] - do you have any plans to work on this further, or

[jira] [Commented] (THRIFT-4506) [CVE-2018-1320] Remove assertion in Java SASL code that would be ignored in release builds

[ https://issues.apache.org/jira/browse/THRIFT-4506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762494#comment-16762494 ] Norbert Kalmar commented on THRIFT-4506: Following this guide -

[jira] [Commented] (THRIFT-4506) [CVE-2018-1320] Remove assertion in Java SASL code that would be ignored in release builds

[ https://issues.apache.org/jira/browse/THRIFT-4506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16761346#comment-16761346 ] James E. King III commented on THRIFT-4506: --- I was not able to build 0.9.3 plus the

[jira] [Commented] (THRIFT-4506) [CVE-2018-1320] Remove assertion in Java SASL code that would be ignored in release builds

[ https://issues.apache.org/jira/browse/THRIFT-4506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16760114#comment-16760114 ] Mike Yoder commented on THRIFT-4506: Any news on the rebuild / release effort? Thanks, -Mike >

[jira] [Commented] (THRIFT-4506) [CVE-2018-1320] Remove assertion in Java SASL code that would be ignored in release builds

[ https://issues.apache.org/jira/browse/THRIFT-4506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16755499#comment-16755499 ] Mike Yoder commented on THRIFT-4506: Thanks _so much_ for the effort.   Version numbers: as far as

[jira] [Commented] (THRIFT-4506) [CVE-2018-1320] Remove assertion in Java SASL code that would be ignored in release builds

[ https://issues.apache.org/jira/browse/THRIFT-4506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16755458#comment-16755458 ] James E. King III commented on THRIFT-4506: --- I was able to cherry-pick the commit of

[jira] [Commented] (THRIFT-4506) [CVE-2018-1320] Remove assertion in Java SASL code that would be ignored in release builds

[ https://issues.apache.org/jira/browse/THRIFT-4506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16755451#comment-16755451 ] James E. King III commented on THRIFT-4506: --- This proposal is predicated on whether the build

[jira] [Commented] (THRIFT-4506) [CVE-2018-1320] Remove assertion in Java SASL code that would be ignored in release builds

[ https://issues.apache.org/jira/browse/THRIFT-4506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16755337#comment-16755337 ] Todd Lipcon commented on THRIFT-4506: - Another option to consider is whether the project could do a

[jira] [Commented] (THRIFT-4506) [CVE-2018-1320] Remove assertion in Java SASL code that would be ignored in release builds

[ https://issues.apache.org/jira/browse/THRIFT-4506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16755330#comment-16755330 ] Mike Yoder commented on THRIFT-4506: It's not just hive - by my count (of the projects I care about)

[jira] [Commented] (THRIFT-4506) [CVE-2018-1320] Remove assertion in Java SASL code that would be ignored in release builds

[ https://issues.apache.org/jira/browse/THRIFT-4506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753378#comment-16753378 ] James E. King III commented on THRIFT-4506: --- I opened HIVE-21173 to track updating Apache

[jira] [Commented] (THRIFT-4506) [CVE-2018-1320] Remove assertion in Java SASL code that would be ignored in release builds

[ https://issues.apache.org/jira/browse/THRIFT-4506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753303#comment-16753303 ] David Phillips commented on THRIFT-4506: Could you apply this to the 0.9.x branch and release