[ 
https://issues.apache.org/jira/browse/THRIFT-5788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17849405#comment-17849405
 ] 

Jens Geyer commented on THRIFT-5788:
------------------------------------

Potentially breaking changes:
 * IsReadOnly never became TRUE, was not fully implemented at all and 
inconsistent with other/usual containers => completely removed
 * CopyTo() is error prone and also inconsistent with other/usual containers => 
completely removed

> Refactor and streamline hash set implementation
> -----------------------------------------------
>
>                 Key: THRIFT-5788
>                 URL: https://issues.apache.org/jira/browse/THRIFT-5788
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Delphi - Library
>            Reporter: Jens Geyer
>            Assignee: Jens Geyer
>            Priority: Major
>              Labels: breaking
>         Attachments: 
> 0001-THRIFT-5788-Refactor-and-streamline-hash-set-impleme.patch
>
>
> Compared to list<T> and map<K,V>, the set<T> implementation in TThriftHashSet 
> has a few quirks, both w/regard to the inconsistent public interface as well 
> as the overly complicated internal implementation.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to