[jira] [Commented] (THRIFT-2441) Cannot shutdown TThreadedServer when clients are still connected

2015-03-30 Thread Randy Abernethy (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14386277#comment-14386277 ] Randy Abernethy commented on THRIFT-2441: - Hey Ben, I agree with your rational,

[jira] [Updated] (THRIFT-3059) Performance issues of TThreadedSelectorServer

2015-03-30 Thread Xiaoshuang LU (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaoshuang LU updated THRIFT-3059: -- Description: Let's assume that there is a client or a thread talks with

[jira] [Updated] (THRIFT-3059) Performance issues of TThreadedSelectorServer

2015-03-30 Thread Xiaoshuang LU (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaoshuang LU updated THRIFT-3059: -- Description: Let's Assume that there is a client or a thread talks with

[GitHub] thrift pull request: Add compiler/cpp/lex.yythriftl.cc to gitignor...

2015-03-30 Thread huerlisi
GitHub user huerlisi opened a pull request: https://github.com/apache/thrift/pull/412 Add compiler/cpp/lex.yythriftl.cc to gitignore. I've accidentially checked that file in in another PR. So this commit adds that file to the .gitignore. Might be that this is only a

[jira] [Commented] (THRIFT-2441) Cannot shutdown TThreadedServer when clients are still connected

2015-03-30 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14386646#comment-14386646 ] James E. King, III commented on THRIFT-2441: I believe this change is an

[jira] [Commented] (THRIFT-2441) Cannot shutdown TThreadedServer when clients are still connected

2015-03-30 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14386681#comment-14386681 ] Ben Craig commented on THRIFT-2441: --- however this patch applies after the listening

[jira] [Commented] (THRIFT-2441) Cannot shutdown TThreadedServer when clients are still connected

2015-03-30 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14386696#comment-14386696 ] Ben Craig commented on THRIFT-2441: --- When there is a network disconnect, the socket

[jira] [Commented] (THRIFT-2441) Cannot shutdown TThreadedServer when clients are still connected

2015-03-30 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14386751#comment-14386751 ] James E. King, III commented on THRIFT-2441: The code in TSocket and

[jira] [Commented] (THRIFT-2441) Cannot shutdown TThreadedServer when clients are still connected

2015-03-30 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14386763#comment-14386763 ] Ben Craig commented on THRIFT-2441: --- I am leery in general of closing a transport in

[GitHub] thrift pull request: Fixes nodejs readme syntax

2015-03-30 Thread huerlisi
GitHub user huerlisi opened a pull request: https://github.com/apache/thrift/pull/411 Fixes nodejs readme syntax The README for nodejs examples had strange syntax letting Markdown thinking everything is a header. You can merge this pull request into a Git repository by running:

[GitHub] thrift pull request: Fixes nodejs readme syntax

2015-03-30 Thread huerlisi
Github user huerlisi commented on the pull request: https://github.com/apache/thrift/pull/411#issuecomment-87633148 Fixed, ready for review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] thrift pull request: Fixes nodejs readme syntax

2015-03-30 Thread huerlisi
Github user huerlisi commented on the pull request: https://github.com/apache/thrift/pull/411#issuecomment-87639738 The failing test (Haskel: https://travis-ci.org/apache/thrift/jobs/56395742) seems to be unrelated to my changes. --- If your project is set up for it, you can reply

[GitHub] thrift pull request: Fixes nodejs readme syntax

2015-03-30 Thread huerlisi
Github user huerlisi commented on the pull request: https://github.com/apache/thrift/pull/411#issuecomment-87632748 Sorry, accidentally checked in a generated file, will fix and amend the last commit. --- If your project is set up for it, you can reply to this email and have your

[jira] [Created] (THRIFT-3059) Performance issues of TThreadedSelectorServer

2015-03-30 Thread Xiaoshuang LU (JIRA)
Xiaoshuang LU created THRIFT-3059: - Summary: Performance issues of TThreadedSelectorServer Key: THRIFT-3059 URL: https://issues.apache.org/jira/browse/THRIFT-3059 Project: Thrift Issue Type:

[jira] [Commented] (THRIFT-2441) Cannot shutdown TThreadedServer when clients are still connected

2015-03-30 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14386836#comment-14386836 ] James E. King, III commented on THRIFT-2441: I understand now, and your

[jira] [Commented] (THRIFT-3060) Node.js client retry logic doesn't flush offline queue on reconnect

2015-03-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14386927#comment-14386927 ] ASF GitHub Bot commented on THRIFT-3060: Github user cjthompson commented on the

[jira] [Created] (THRIFT-3061) C++ TSSLSocket shutdown delay/vulnerability

2015-03-30 Thread James E. King, III (JIRA)
James E. King, III created THRIFT-3061: -- Summary: C++ TSSLSocket shutdown delay/vulnerability Key: THRIFT-3061 URL: https://issues.apache.org/jira/browse/THRIFT-3061 Project: Thrift

[jira] [Commented] (THRIFT-2441) Cannot shutdown TThreadedServer when clients are still connected

2015-03-30 Thread Randy Abernethy (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14386953#comment-14386953 ] Randy Abernethy commented on THRIFT-2441: - Indeed, good example. Cannot

[jira] [Created] (THRIFT-3062) C++ TServerSocket invalid port number (over 999999) causes stack corruption

2015-03-30 Thread James E. King, III (JIRA)
James E. King, III created THRIFT-3062: -- Summary: C++ TServerSocket invalid port number (over 99) causes stack corruption Key: THRIFT-3062 URL: https://issues.apache.org/jira/browse/THRIFT-3062

[jira] [Commented] (THRIFT-3033) Perl: Support for Multiplexing Services on any Transport, Protocol and Server

2015-03-30 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14387522#comment-14387522 ] Jens Geyer commented on THRIFT-3033: Hi [~hs2323], I modified the makefile and added

[jira] [Commented] (THRIFT-3051) Go Thrift generator creates bad go code

2015-03-30 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14387362#comment-14387362 ] Jens Geyer commented on THRIFT-3051: Hi [~swsnider], would it be possible for you to

[jira] [Commented] (THRIFT-3050) Client certificate authentication for non-http TLS in C#

2015-03-30 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14387528#comment-14387528 ] Hudson commented on THRIFT-3050: SUCCESS: Integrated in Thrift #1487 (See

[jira] [Commented] (THRIFT-3051) Go Thrift generator creates bad go code

2015-03-30 Thread Silas Snider (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14387386#comment-14387386 ] Silas Snider commented on THRIFT-3051: -- No: I took a look at the generator code, and

[jira] [Commented] (THRIFT-3050) Client certificate authentication for non-http TLS in C#

2015-03-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14387477#comment-14387477 ] ASF GitHub Bot commented on THRIFT-3050: Github user asfgit closed the pull

[GitHub] thrift pull request: THRIFT-3050 TLS Client cert validation TLS C#

2015-03-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/410 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Resolved] (THRIFT-3050) Client certificate authentication for non-http TLS in C#

2015-03-30 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-3050. Resolution: Fixed Fix Version/s: 0.9.3 Committed, thank you! Client certificate

[jira] [Updated] (THRIFT-3062) C++ TServerSocket invalid port number (over 999999) causes stack corruption

2015-03-30 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-3062: --- Labels: security (was: ) C++ TServerSocket invalid port number (over 99) causes stack

[jira] [Updated] (THRIFT-3060) Node.js client retry logic doesn't flush offline queue on reconnect

2015-03-30 Thread Chris Thompson (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Thompson updated THRIFT-3060: --- Attachment: thrift-3060-fix_retry_logic.patch Node.js client retry logic doesn't flush

[GitHub] thrift pull request: NodeJS Client: Fix connection retry logic

2015-03-30 Thread cjthompson
Github user cjthompson commented on the pull request: https://github.com/apache/thrift/pull/395#issuecomment-87740047 I submitted a patch to issue THRIFT-3060. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[jira] [Commented] (THRIFT-3060) Node.js client retry logic doesn't flush offline queue on reconnect

2015-03-30 Thread Chris Thompson (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14386926#comment-14386926 ] Chris Thompson commented on THRIFT-3060: See GitHub PR :