[GitHub] thrift pull request #1311: Fix for constant assignments to optional fields i...

Github user davinchia commented on a diff in the pull request: https://github.com/apache/thrift/pull/1311#discussion_r129124617 --- Diff: compiler/cpp/src/thrift/generate/t_go_generator.cc --- @@ -424,6 +424,52 @@ bool t_go_generator::is_pointer_field(t_field* tfield, bool

[jira] [Commented] (THRIFT-4260) Go context generation issue. Context is parameter in Interface not in implementation

[ https://issues.apache.org/jira/browse/THRIFT-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099187#comment-16099187 ] ASF GitHub Bot commented on THRIFT-4260: Github user asfgit closed the pull request at:

[GitHub] thrift pull request #1312: THRIFT-4260: Add context as first arg for client ...

Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1312 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (THRIFT-4260) Go context generation issue. Context is parameter in Interface not in implementation

[ https://issues.apache.org/jira/browse/THRIFT-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16098176#comment-16098176 ] ASF GitHub Bot commented on THRIFT-4260: GitHub user taozle reopened a pull request:

[GitHub] thrift pull request #1312: Add context as first arg for client method.

Github user taozle closed the pull request at: https://github.com/apache/thrift/pull/1312 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request #1312: Add context as first arg for client method.

GitHub user taozle reopened a pull request: https://github.com/apache/thrift/pull/1312 Add context as first arg for client method. Related: https://issues.apache.org/jira/browse/THRIFT-4260 You can merge this pull request into a Git repository by running: $ git pull

[jira] [Commented] (THRIFT-4260) Go context generation issue. Context is parameter in Interface not in implementation

[ https://issues.apache.org/jira/browse/THRIFT-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16098175#comment-16098175 ] ASF GitHub Bot commented on THRIFT-4260: Github user taozle closed the pull request at:

[GitHub] thrift issue #1312: THRIFT-4260: Add context as first arg for client method.

Github user dcelasun commented on the issue: https://github.com/apache/thrift/pull/1312 LGTM (once again, travis failure is unrelated) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Commented] (THRIFT-4260) Go context generation issue. Context is parameter in Interface not in implementation

[ https://issues.apache.org/jira/browse/THRIFT-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16098288#comment-16098288 ] ASF GitHub Bot commented on THRIFT-4260: Github user dcelasun commented on the issue: