[jira] [Closed] (THRIFT-4347) running build-thrift error when running tests
[ https://issues.apache.org/jira/browse/THRIFT-4347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gideon Korir closed THRIFT-4347. Resolution: Fixed > running build-thrift error when running tests > - > > Key: THRIFT-4347 > URL: https://issues.apache.org/jira/browse/THRIFT-4347 > Project: Thrift > Issue Type: Bug > Components: Build Process, Test Suite >Affects Versions: 0.10.0 > Environment: - Following the instructions at > [github|https://github.com/apache/thrift/tree/master/build/wincpp] to build > Thrift on Windows 7. I'm a bit out of my league there but I followed all the > instructions using: > # Branch: master > # Visual Studio 2017 Community > # CMake 3.9.3 > # WinFlexBison - latest > # OpenSsl 1.1.0-rc > # Zlib 1.2.9 > # libevent 2.1.7-rc > # ActivePerl 5.24.2.2403 x64 > # Boost boost_1_62_0-msvc-14.0-32 > Environment Variables: > # ARCH = x86 > # COMPILER = vc150 > # GENERATOR = Visual Studio 15 2017 >Reporter: Gideon Korir > > build-thrift.bat /NOTEST => SUCCESSFUL BUILD > build-thrift.bat => ERROR > SO FAR I've Isolated the error to the post-build event for RUN_TESTS project. > There error message is: > Error MSB3073 The command "setlocal > "C:\Program Files\CMake\bin\ctest.exe" --force-new-ctest-process -C Debug > if %errorlevel% neq 0 goto :cmEnd > :cmEnd > endlocal & call :cmErrorLevel %errorlevel% & goto :cmDone > :cmErrorLevel > exit /b %1 > :cmDone > if %errorlevel% neq 0 goto :VCEnd > :VCEnd" exited with code 8. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-4347) running build-thrift error when running tests
[ https://issues.apache.org/jira/browse/THRIFT-4347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16180943#comment-16180943 ] Gideon Korir commented on THRIFT-4347: -- This occurs because Ctest doesn't have correct boost libraries to link against. Fixed by adding path to boost libraries to my PATH system variable. > running build-thrift error when running tests > - > > Key: THRIFT-4347 > URL: https://issues.apache.org/jira/browse/THRIFT-4347 > Project: Thrift > Issue Type: Bug > Components: Build Process, Test Suite >Affects Versions: 0.10.0 > Environment: - Following the instructions at > [github|https://github.com/apache/thrift/tree/master/build/wincpp] to build > Thrift on Windows 7. I'm a bit out of my league there but I followed all the > instructions using: > # Branch: master > # Visual Studio 2017 Community > # CMake 3.9.3 > # WinFlexBison - latest > # OpenSsl 1.1.0-rc > # Zlib 1.2.9 > # libevent 2.1.7-rc > # ActivePerl 5.24.2.2403 x64 > # Boost boost_1_62_0-msvc-14.0-32 > Environment Variables: > # ARCH = x86 > # COMPILER = vc150 > # GENERATOR = Visual Studio 15 2017 >Reporter: Gideon Korir > > build-thrift.bat /NOTEST => SUCCESSFUL BUILD > build-thrift.bat => ERROR > SO FAR I've Isolated the error to the post-build event for RUN_TESTS project. > There error message is: > Error MSB3073 The command "setlocal > "C:\Program Files\CMake\bin\ctest.exe" --force-new-ctest-process -C Debug > if %errorlevel% neq 0 goto :cmEnd > :cmEnd > endlocal & call :cmErrorLevel %errorlevel% & goto :cmDone > :cmErrorLevel > exit /b %1 > :cmDone > if %errorlevel% neq 0 goto :VCEnd > :VCEnd" exited with code 8. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (THRIFT-4349) Linker error from auto-generated C++ code.
Peter Young created THRIFT-4349: --- Summary: Linker error from auto-generated C++ code. Key: THRIFT-4349 URL: https://issues.apache.org/jira/browse/THRIFT-4349 Project: Thrift Issue Type: Bug Components: C++ - Compiler Affects Versions: 0.9.3 Environment: Windows 10 VS Community 2013 - Version 12.0.40629.0 Update 5. Thrift v0.9.3 Reporter: Peter Young I have an odd issue whereby some of the function in one of my services cause the fail to build because the auto-generated C++ code for them somehow fails to match the linker requirement generated by another part of the code, but only for 32-bit builds (the 64-bit builds are fine.) The attached file, if I can get it to work contains my IDL and the source code generated from it. [[^XiSpoolersample.zip] If anyone can offer a reason as to why the code does not link for 32-bit but does for 64-bit I would be fascinated to know. I will most likely require the 32-bit code at some point in the not-too distant future but can work with the 64-bit version for now. Thanks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-4345) Create a docker build environment that uses the minimum supported language levels
[ https://issues.apache.org/jira/browse/THRIFT-4345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16180792#comment-16180792 ] ASF GitHub Bot commented on THRIFT-4345: Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1377 > Create a docker build environment that uses the minimum supported language > levels > - > > Key: THRIFT-4345 > URL: https://issues.apache.org/jira/browse/THRIFT-4345 > Project: Thrift > Issue Type: Improvement > Components: Build Process >Affects Versions: 0.10.0 > Environment: docker >Reporter: James E. King, III >Assignee: James E. King, III > > Following documentation of the supported language versions, we need to ensure > there is a CI job that will build and run all the unit tests for all the > minimum supported language levels. > Some examples of non-conformance right now: > ubuntu-trusty has perl 5.18.2 and xenial has 5.22.0, however all perl files > state minimum of 5.10, so we should be building with 5.10 *or* move the > minimum supported version up to 5.18.2. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift pull request #1377: THRIFT-4345: Added ubuntu-trusty to the CI builds...
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1377 ---
[jira] [Commented] (THRIFT-4348) Perl HTTP Client custom HTTP headers
[ https://issues.apache.org/jira/browse/THRIFT-4348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16180782#comment-16180782 ] ASF GitHub Bot commented on THRIFT-4348: Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1376 > Perl HTTP Client custom HTTP headers > > > Key: THRIFT-4348 > URL: https://issues.apache.org/jira/browse/THRIFT-4348 > Project: Thrift > Issue Type: Improvement > Components: Perl - Library >Affects Versions: 0.10.0 >Reporter: Carwyn Moore >Assignee: James E. King, III >Priority: Minor > Fix For: 0.11.0 > > > Allow setting of HTTP headers on the perl HTTP client , similar to: > - PHP - addHeaders > > https://github.com/apache/thrift/blob/master/lib/php/lib/Thrift/Transport/THttpClient.php > - Go - SetHeader > https://github.com/apache/thrift/blob/master/lib/go/thrift/http_client.go -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-4348) Perl HTTP Client custom HTTP headers
[ https://issues.apache.org/jira/browse/THRIFT-4348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16180778#comment-16180778 ] James E. King, III commented on THRIFT-4348: PR 1376 adds support in perl but not in go, so I will leave this open. > Perl HTTP Client custom HTTP headers > > > Key: THRIFT-4348 > URL: https://issues.apache.org/jira/browse/THRIFT-4348 > Project: Thrift > Issue Type: Proposal > Components: Perl - Library >Affects Versions: 0.10.0 >Reporter: Carwyn Moore >Priority: Trivial > > Allow setting of HTTP headers on the perl HTTP client , similar to: > - PHP - addHeaders > > https://github.com/apache/thrift/blob/master/lib/php/lib/Thrift/Transport/THttpClient.php > - Go - SetHeader > https://github.com/apache/thrift/blob/master/lib/go/thrift/http_client.go -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (THRIFT-4348) Perl HTTP Client custom HTTP headers
[ https://issues.apache.org/jira/browse/THRIFT-4348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reassigned THRIFT-4348: -- Assignee: James E. King, III > Perl HTTP Client custom HTTP headers > > > Key: THRIFT-4348 > URL: https://issues.apache.org/jira/browse/THRIFT-4348 > Project: Thrift > Issue Type: Improvement > Components: Perl - Library >Affects Versions: 0.10.0 >Reporter: Carwyn Moore >Assignee: James E. King, III >Priority: Minor > > Allow setting of HTTP headers on the perl HTTP client , similar to: > - PHP - addHeaders > > https://github.com/apache/thrift/blob/master/lib/php/lib/Thrift/Transport/THttpClient.php > - Go - SetHeader > https://github.com/apache/thrift/blob/master/lib/go/thrift/http_client.go -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Issue Comment Deleted] (THRIFT-4348) Perl HTTP Client custom HTTP headers
[ https://issues.apache.org/jira/browse/THRIFT-4348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4348: --- Comment: was deleted (was: PR 1376 adds support in perl but not in go, so I will leave this open.) > Perl HTTP Client custom HTTP headers > > > Key: THRIFT-4348 > URL: https://issues.apache.org/jira/browse/THRIFT-4348 > Project: Thrift > Issue Type: Improvement > Components: Perl - Library >Affects Versions: 0.10.0 >Reporter: Carwyn Moore >Priority: Minor > > Allow setting of HTTP headers on the perl HTTP client , similar to: > - PHP - addHeaders > > https://github.com/apache/thrift/blob/master/lib/php/lib/Thrift/Transport/THttpClient.php > - Go - SetHeader > https://github.com/apache/thrift/blob/master/lib/go/thrift/http_client.go -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift pull request #1376: THRIFT-4348 - Allow custom HTTP headers to be set...
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1376 ---
[jira] [Updated] (THRIFT-4348) Perl HTTP Client custom HTTP headers
[ https://issues.apache.org/jira/browse/THRIFT-4348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4348: --- Issue Type: Improvement (was: Proposal) > Perl HTTP Client custom HTTP headers > > > Key: THRIFT-4348 > URL: https://issues.apache.org/jira/browse/THRIFT-4348 > Project: Thrift > Issue Type: Improvement > Components: Perl - Library >Affects Versions: 0.10.0 >Reporter: Carwyn Moore >Priority: Trivial > > Allow setting of HTTP headers on the perl HTTP client , similar to: > - PHP - addHeaders > > https://github.com/apache/thrift/blob/master/lib/php/lib/Thrift/Transport/THttpClient.php > - Go - SetHeader > https://github.com/apache/thrift/blob/master/lib/go/thrift/http_client.go -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (THRIFT-4348) Perl HTTP Client custom HTTP headers
[ https://issues.apache.org/jira/browse/THRIFT-4348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4348: --- Priority: Minor (was: Trivial) > Perl HTTP Client custom HTTP headers > > > Key: THRIFT-4348 > URL: https://issues.apache.org/jira/browse/THRIFT-4348 > Project: Thrift > Issue Type: Improvement > Components: Perl - Library >Affects Versions: 0.10.0 >Reporter: Carwyn Moore >Priority: Minor > > Allow setting of HTTP headers on the perl HTTP client , similar to: > - PHP - addHeaders > > https://github.com/apache/thrift/blob/master/lib/php/lib/Thrift/Transport/THttpClient.php > - Go - SetHeader > https://github.com/apache/thrift/blob/master/lib/go/thrift/http_client.go -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (THRIFT-4348) Perl HTTP Client custom HTTP headers
[ https://issues.apache.org/jira/browse/THRIFT-4348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4348: --- Affects Version/s: 0.10.0 > Perl HTTP Client custom HTTP headers > > > Key: THRIFT-4348 > URL: https://issues.apache.org/jira/browse/THRIFT-4348 > Project: Thrift > Issue Type: Improvement > Components: Perl - Library >Affects Versions: 0.10.0 >Reporter: Carwyn Moore >Assignee: James E. King, III >Priority: Minor > > Allow setting of HTTP headers on the perl HTTP client , similar to: > - PHP - addHeaders > > https://github.com/apache/thrift/blob/master/lib/php/lib/Thrift/Transport/THttpClient.php > - Go - SetHeader > https://github.com/apache/thrift/blob/master/lib/go/thrift/http_client.go -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift issue #1375: THRIFT-4346: Allow ZlibTransportFactory to wrap other fa...
Github user dcelasun commented on the issue: https://github.com/apache/thrift/pull/1375 LGTM, CI failures are unrelated. cc @Jens-G ---
[jira] [Commented] (THRIFT-4346) Allow Zlib transport factory to wrap other transports
[ https://issues.apache.org/jira/browse/THRIFT-4346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16180674#comment-16180674 ] ASF GitHub Bot commented on THRIFT-4346: Github user dcelasun commented on the issue: https://github.com/apache/thrift/pull/1375 LGTM, CI failures are unrelated. cc @Jens-G > Allow Zlib transport factory to wrap other transports > - > > Key: THRIFT-4346 > URL: https://issues.apache.org/jira/browse/THRIFT-4346 > Project: Thrift > Issue Type: Improvement > Components: Go - Library >Affects Versions: 0.10.0 > Environment: Any >Reporter: Yuri Khrustalev >Priority: Minor > Labels: easyfix > > Thrift protocol allows to combine number of transports to transfer data, one > of the examples is to use zlib transport on top of the framed transport. > Turns out there is no such factory which could help building one for zlib > transport. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-4346) Allow Zlib transport factory to wrap other transports
[ https://issues.apache.org/jira/browse/THRIFT-4346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16180666#comment-16180666 ] ASF GitHub Bot commented on THRIFT-4346: Github user ykhrustalev commented on the issue: https://github.com/apache/thrift/pull/1375 It is not quite obvious what are the reasons for CI failures but they don't seem to be related to the patch. > Allow Zlib transport factory to wrap other transports > - > > Key: THRIFT-4346 > URL: https://issues.apache.org/jira/browse/THRIFT-4346 > Project: Thrift > Issue Type: Improvement > Components: Go - Library >Affects Versions: 0.10.0 > Environment: Any >Reporter: Yuri Khrustalev >Priority: Minor > Labels: easyfix > > Thrift protocol allows to combine number of transports to transfer data, one > of the examples is to use zlib transport on top of the framed transport. > Turns out there is no such factory which could help building one for zlib > transport. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift issue #1375: THRIFT-4346: Allow ZlibTransportFactory to wrap other fa...
Github user ykhrustalev commented on the issue: https://github.com/apache/thrift/pull/1375 It is not quite obvious what are the reasons for CI failures but they don't seem to be related to the patch. ---
