[GitHub] thrift pull request #1451: THRIFT-4438: delete trusty and requrie php56

GitHub user RobberPhex opened a pull request: https://github.com/apache/thrift/pull/1451 THRIFT-4438: delete trusty and requrie php56 * remove support php 5.3, 5.4 and 5.5 * remove test at ubuntu trusty(trusty only have php5.5, haven't php5.6) You can merge this pull request

[jira] [Commented] (THRIFT-4437) JS WebSocket client callbacks invoked twice on parallel requests

[ https://issues.apache.org/jira/browse/THRIFT-4437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305300#comment-16305300 ] Philip Frank commented on THRIFT-4437: -- This issue would have been caught by the `ThriftWS` test

[jira] [Commented] (THRIFT-4438) require php ^5.6 || ^7.0

[ https://issues.apache.org/jira/browse/THRIFT-4438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305340#comment-16305340 ] ASF GitHub Bot commented on THRIFT-4438: GitHub user RobberPhex opened a pull request:

[jira] [Commented] (THRIFT-4423) migrate php library to psr-4

[ https://issues.apache.org/jira/browse/THRIFT-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305408#comment-16305408 ] ASF GitHub Bot commented on THRIFT-4423: Github user jeking3 commented on a diff in the pull

[GitHub] thrift pull request #1445: THRIFT-4423 migrate to psr-4

Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1445#discussion_r158937682 --- Diff: lib/php/test/Makefile.am --- @@ -17,6 +17,8 @@ # under the License. # +PHPUNIT=./../../../vendor/bin/phpunit --- End diff

[jira] [Commented] (THRIFT-4423) migrate php library to psr-4

[ https://issues.apache.org/jira/browse/THRIFT-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305409#comment-16305409 ] ASF GitHub Bot commented on THRIFT-4423: Github user jeking3 commented on a diff in the pull

[jira] [Commented] (THRIFT-4423) migrate php library to psr-4

[ https://issues.apache.org/jira/browse/THRIFT-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305410#comment-16305410 ] ASF GitHub Bot commented on THRIFT-4423: Github user jeking3 commented on a diff in the pull

[GitHub] thrift pull request #1445: THRIFT-4423 migrate to psr-4

Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1445#discussion_r158937598 --- Diff: build/docker/scripts/sca.sh --- @@ -56,7 +56,3 @@ echo TODOs: `grep -r TODO * | wc -l` # LoC sloccount . - -# System Info

[jira] [Commented] (THRIFT-4437) JS WebSocket client callbacks invoked twice on parallel requests

[ https://issues.apache.org/jira/browse/THRIFT-4437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305425#comment-16305425 ] ASF GitHub Bot commented on THRIFT-4437: Github user asfgit closed the pull request at:

[jira] [Commented] (THRIFT-4423) migrate php library to psr-4

[ https://issues.apache.org/jira/browse/THRIFT-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305333#comment-16305333 ] RobberPhex commented on THRIFT-4423: Finally, all test passed. [~jking3] Is this pull request OK? >

[jira] [Created] (THRIFT-4438) require php ^5.6 || ^7.0

RobberPhex created THRIFT-4438: -- Summary: require php ^5.6 || ^7.0 Key: THRIFT-4438 URL: https://issues.apache.org/jira/browse/THRIFT-4438 Project: Thrift Issue Type: Improvement

[GitHub] thrift pull request #1450: THRIFT-4437: JavaScript WebSocket - fix duplicate...

Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1450 ---

[jira] [Assigned] (THRIFT-4437) JS WebSocket client callbacks invoked twice on parallel requests

[ https://issues.apache.org/jira/browse/THRIFT-4437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reassigned THRIFT-4437: -- Assignee: James E. King, III > JS WebSocket client callbacks invoked twice on

[jira] [Commented] (THRIFT-4406) JavaScript: Use modern Promise implementations

[ https://issues.apache.org/jira/browse/THRIFT-4406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305469#comment-16305469 ] ASF GitHub Bot commented on THRIFT-4406: GitHub user bananer opened a pull request:

[GitHub] thrift pull request #1452: THRIFT-4406: ES6 compatible JavaScript with Promi...

GitHub user bananer opened a pull request: https://github.com/apache/thrift/pull/1452 THRIFT-4406: ES6 compatible JavaScript with Promises You can merge this pull request into a Git repository by running: $ git pull https://github.com/bananer/thrift THRIFT-4406-pr

[GitHub] thrift issue #1450: THRIFT-4437: JavaScript WebSocket - fix duplicate callba...

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1450 Running autotools.sh locally on xenial to see if it was one of those annoying npm transient failures. ---

[jira] [Commented] (THRIFT-4437) JS WebSocket client callbacks invoked twice on parallel requests

[ https://issues.apache.org/jira/browse/THRIFT-4437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305413#comment-16305413 ] ASF GitHub Bot commented on THRIFT-4437: Github user jeking3 commented on the issue:

[jira] [Commented] (THRIFT-4439) Shouldn't download dart.deb directly.

[ https://issues.apache.org/jira/browse/THRIFT-4439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305906#comment-16305906 ] ASF GitHub Bot commented on THRIFT-4439: Github user RobberPhex commented on the issue:

[jira] [Created] (THRIFT-4439) Shouldn't download dart.deb directly.

RobberPhex created THRIFT-4439: -- Summary: Shouldn't download dart.deb directly. Key: THRIFT-4439 URL: https://issues.apache.org/jira/browse/THRIFT-4439 Project: Thrift Issue Type: Bug

[jira] [Commented] (THRIFT-4439) Shouldn't download dart.deb directly.

[ https://issues.apache.org/jira/browse/THRIFT-4439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305846#comment-16305846 ] ASF GitHub Bot commented on THRIFT-4439: GitHub user RobberPhex opened a pull request:

[GitHub] thrift pull request #1453: THRIFT-4439: use dartlang repo instead of downloa...

GitHub user RobberPhex opened a pull request: https://github.com/apache/thrift/pull/1453 THRIFT-4439: use dartlang repo instead of download dart.deb You can merge this pull request into a Git repository by running: $ git pull https://github.com/RobberPhex/thrift dartlang