[
https://issues.apache.org/jira/browse/THRIFT-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16404764#comment-16404764
]
ASF GitHub Bot commented on THRIFT-4187:
Github user allengeorge commented on the issue:
[
https://issues.apache.org/jira/browse/THRIFT-4515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405030#comment-16405030
]
ASF GitHub Bot commented on THRIFT-4515:
GitHub user jeking3 opened a pull request:
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1509
THRIFT-4515: cross server test improvement: graceful test server shutdown
### Problem ###
Test servers are not shut down gracefully - they are SIGKILLed once the
client exits.
###
Github user allengeorge commented on the issue:
https://github.com/apache/thrift/pull/1269
@jeking3 I've added unit tests around this behavior and enabled more cross
tests! Do you want me to roll that into this PR, or should I create another bug
and PR?
---
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1509
---
[
https://issues.apache.org/jira/browse/THRIFT-4515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405240#comment-16405240
]
ASF GitHub Bot commented on THRIFT-4515:
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/THRIFT-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405282#comment-16405282
]
ASF GitHub Bot commented on THRIFT-4489:
Github user jeking3 commented on the issue:
Github user ozymaxx commented on the issue:
https://github.com/apache/thrift/pull/1496
Thanks! I have just caught the meaning of squash since it's been the first
time i try to contribute an open source project. I will squash all into a
single one and let you know from here.
---
[
https://issues.apache.org/jira/browse/THRIFT-4476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405292#comment-16405292
]
ASF GitHub Bot commented on THRIFT-4476:
Github user ozymaxx commented on the issue:
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1491
Perhaps; my PR for THRIFT-4515 improves the stability and coverage of
crosstest by adding more controlled server shutdown, and it passed tests (I've
run it many times on my local fork as well). I
[
https://issues.apache.org/jira/browse/THRIFT-4515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III resolved THRIFT-4515.
Resolution: Fixed
Fix Version/s: 0.12.0
> Gracefully shutdown cross-test
[
https://issues.apache.org/jira/browse/THRIFT-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405242#comment-16405242
]
ASF GitHub Bot commented on THRIFT-4489:
Github user jeking3 commented on the issue:
[
https://issues.apache.org/jira/browse/THRIFT-4476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405251#comment-16405251
]
ASF GitHub Bot commented on THRIFT-4476:
Github user jeking3 commented on the issue:
[
https://issues.apache.org/jira/browse/THRIFT-4478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-4478:
---
Summary: Thrift will not build with dlang 2.078 or later (was: Thrift is
not
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1289
@nsuke there must be some common wisdom and/or tooling to facilitate the
conversion from py2 to py3 in this regard - what have other projects done when
facing this issue?
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1491
I am running a cross test on this locally; if it passes I will merge it, so
don't take any action.
---
[
https://issues.apache.org/jira/browse/THRIFT-4478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405234#comment-16405234
]
James E. King, III commented on THRIFT-4478:
Also:
{noformat}
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1496
Yes, however, it needs to be squashed to a single commit. I would prefer
if you did that, but I can do it if you really need me to. It's just a lot
more work for the committers to do that, and we
[
https://issues.apache.org/jira/browse/THRIFT-4523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer updated THRIFT-4523:
---
Attachment: 0001-THRIFT-4523-TStreamTransportImpl.GetOutputStream-bro.patch
>
Jens Geyer created THRIFT-4523:
--
Summary: TStreamTransportImpl.GetOutputStream broken
Key: THRIFT-4523
URL: https://issues.apache.org/jira/browse/THRIFT-4523
Project: Thrift
Issue Type: Bug
[
https://issues.apache.org/jira/browse/THRIFT-4515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405216#comment-16405216
]
ASF GitHub Bot commented on THRIFT-4515:
Github user jeking3 commented on the issue:
[
https://issues.apache.org/jira/browse/THRIFT-4523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer resolved THRIFT-4523.
Resolution: Fixed
Committed
> TStreamTransportImpl.GetOutputStream broken
>
[
https://issues.apache.org/jira/browse/THRIFT-4523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer updated THRIFT-4523:
---
Affects Version/s: 0.9.3
0.10.0
0.11.0
>
[
https://issues.apache.org/jira/browse/THRIFT-4523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer updated THRIFT-4523:
---
Priority: Trivial (was: Major)
> TStreamTransportImpl.GetOutputStream broken
>
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1509
The build failure in the artful check job is in lib/d unit tests and is a
sporadic issue that needs to be investigated, but will not hold up this work.
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1491
Okay so, here's the deal. This pull request has 9 commits and one of them
is a merge. If you want your name on the commit tag you will need to squash
and resubmit with a single commit and then I
[
https://issues.apache.org/jira/browse/THRIFT-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405372#comment-16405372
]
ASF GitHub Bot commented on THRIFT-4489:
Github user jeking3 commented on the issue:
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1491
I get an error that may be unrelated when I run cross tests on --server
nodejs locally. This one test failes sporadically and I don't know if it could
be related to these changes; the client has
[
https://issues.apache.org/jira/browse/THRIFT-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405377#comment-16405377
]
ASF GitHub Bot commented on THRIFT-4489:
Github user jeking3 commented on the issue:
29 matches
Mail list logo
